Uh oh!
There was an error while loading. Please reload this page.
cli: warm fast path spawns the harness in ~20ms; 10x faster cold launches - #258
Conversation
…d launches agent <persona> launches now keep the session's sandbox mount warm and record a digest-validated launch plan. The next launch of the same selector validates the plan with a handful of stats (~20ms including node boot), claims the warm mount by atomic rename, and spawns the harness immediately; the heavy CLI module loads afterward, reattaches the mount with the previous session's autosync state, and reconciles while the harness boots. Any change to the persona, source dirs, skills, dotfiles, or pinned env falls back to the full path (AGENTWORKFORCE_NO_FAST=1 disables). Cold launches populate mounts from git ls-files (local-mount population: 'auto'), start autosync from population-seeded state, skip the npm cache when mirroring skills, and lazy-load cloud subcommand handlers. In the relay repo: 26s -> 2.5s cold, ~20ms warm; teardown 11s -> <1s. Requires @relayfile/local-mount ^0.11.0 (release upstream first). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (1)
⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe CLI implementation moves into ChangesCLI runtime and warm launch
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant CLI as cli.ts
participant Runtime as cli-impl.ts
participant Mount as sandbox mount
participant Harness
User->>CLI: agent selector
CLI->>Runtime: delegate normal launch
Runtime->>Mount: configure and populate mount
Runtime->>Harness: spawn interactive session
Harness-->>Runtime: session exit
Runtime->>Mount: autosync and prepare warm plan
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…module load The harness child spawns before cli-impl loads; a child that exits during that import has already emitted 'close', so the resume must read the settled exitCode/signalCode instead of waiting forever for an event that fired with no listener. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review
This pull request introduces a warm-launch fast path for @agentworkforce/cli that allows repeat launches of the same persona to reuse the previous session's sandbox mount and a digest-validated launch plan, significantly reducing startup times. The changes include the addition of fast-launch.ts and its corresponding tests, as well as updating the @relayfile/local-mount dependency. Feedback on these changes suggests wrapping the validation phase of tryFastAgentLaunch in a try-catch block to prevent potential crashes from corrupted or manually edited launch plans. Additionally, it is recommended to normalize directory sizes to zero in statDigestOf to avoid filesystem-dependent mismatch noise and to document the limitations of using directory stats for change detection.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:39ae62851b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
All reported issues were addressed
Not reviewed (too large): packages/cli/src/cli.ts (~4,751 lines) - if these are generated or fixture files, add them to ignored paths to exclude them from future reviews.
Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.
Re-trigger cubic
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Corrupted/truncated launch plans fall back to the full launch instead of throwing (blanket guard in tryFastAgentLaunch) - Digest every persona JSON in every source layer, not just the winning file: same-id layers merge, and in-place edits don't touch dir mtimes. Directory digests pin size to 0 (filesystem-dependent noise) - Path-form sidecars (claudeMd/agentsMd file refs) make a launch ineligible for plan caching until those files join the digest set - Park async child spawn errors in fast-launch so an early 'error' can't crash during the heavy import and the session manager resolves 127 - A failed drain/sync-back after a clean harness exit returns exit code 1 instead of masquerading as success (matches the cold path) - persona-kit: bump @relayfile/local-mount to ^0.11.0 so pnpm hoists a single copy alongside the CLI's Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The relayfile release train shipped the fast-launch changes as 0.10.23 (lockstep patch), not the 0.11.0 this branch anticipated. Ranges in cli and persona-kit now track ^0.10.23 and the lockfile resolves the published package. Cold/warm E2E re-verified against the npm tarball: 2.8s cold, ~20ms warm to harness spawn in relay. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/cli/src/cli-impl.ts`:
- Around line 1617-1629: Update resolveBinOnPath to split process.env.PATH using
the platform-specific path.delimiter instead of a hardcoded colon. Ensure
Windows resolution also considers executable extensions such as .cmd and .exe
when checking candidates, while preserving existing absolute-path and Unix
behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: b5c5f8af-f917-4cb3-ac04-7cfd87a6104d
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (8)
CHANGELOG.mdpackages/cli/package.jsonpackages/cli/src/cli-impl.tspackages/cli/src/cli.test.tspackages/cli/src/cli.tspackages/cli/src/fast-launch.test.tspackages/cli/src/fast-launch.tspackages/persona-kit/package.json
Uh oh!
There was an error while loading. Please reload this page.
Windows PATHEXT shims stay unresolved by design — the warm fast path simply never engages there and launches take the full path. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
What this is
agentworkforce agent <persona>spawns the harness in ~20ms on repeat launches and ~2.5s cold (relay repo; previously ~26s), with session teardown under 1s (previously ~11s).Warm fast path
A successful mount session keeps its sandbox mount under
~/.agentworkforce/workforce/cache/warm-mounts/together with a launch plan: the resolved spawn (absolute bin + argv + default-derived env), stat digests of every input that fed resolution (persona file, persona source dirs + config,.agentignore/.agentreadonly, local skill sources), pinned env vars, and the skill-cache fingerprint.The next launch of the same selector runs a dependency-free entry (
fast-launch.ts, node builtins only): validate the plan, claim the warm mount by atomic rename, spawn the harness. The heavy CLI module loads after the child is running, reattaches the mount with the previous session's exported autosync state, reconciles against the repo while the harness TUI boots (~600ms, well inside harness startup), re-verifies the plan against live resolution, and runs the normal metadata/drain/sync-back/re-warm flow on exit.Plans hold no secrets by construction: eligibility refuses personas with
envmaps,mcpServers, ai-memory wiring, env-provided inputs, or (outside opencode, which ignores it) relay MCP config. Everything else — any flag, any digest mismatch, a set pinned env var, a due upstream-drift check, a lost rename race — falls back silently to the full launch, which rebuilds both plan and warm mount.AGENTWORKFORCE_NO_FAST=1disables;AGENTWORKFORCE_PERF=1prints launch-phase timings.Cold path
@relayfile/local-mountpopulation: 'auto'(git ls-files): 1,477 files instead of 38,561 in relay, and autosync starts from population-seeded state instead of byte-comparing every file pair (was 9.3s)..npm-cache(41MB) into the mount.deploy/invoke/runs/destroy/integrations/deployments) load lazily at dispatch — they pulled@agent-relay/cloudonto every launch (~180ms).cli.tsis now a thin entry; the implementation lives incli-impl.ts.Verified end-to-end (relay repo, harness stubbed)
Merge order
Requires
@relayfile/local-mount0.11.0 (AgentWorkforce/relayfile#349):population,attachMount,exportState, and the external-teardown safety guard. Release relayfile first, then land this; install/CI here stays red until that version is on npm.🤖 Generated with Claude Code