Uh oh!
There was an error while loading. Please reload this page.
fix(publish): add local-surface to the lockstep publish target list - #271
Conversation
@agentworkforce/local-surface was added in #263 but never added to the hardcoded package list in publish.yml, so it never went through the pnpm-pack step that rewrites workspace:* deps to concrete versions. It was published to npm out-of-band (likely a manual `npm publish`), leaving literal "workspace:*" strings in its published dependencies (@agentworkforce/deploy, persona-kit, runtime). Any plain `npm install` that resolves this package now crashes with "Unsupported URL Type workspace:" — npm-package-arg can't parse the pnpm workspace protocol. Slotting it into the topological list (after its deploy/persona-kit/ runtime deps, before its only consumer cli) lets the next publish run correctly pack and republish it via `pnpm pack`, superseding the broken 4.1.17. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
📝 WalkthroughWalkthroughThe publish workflow now includes ChangesPublish workflow
Estimated code review effort: 1 (Trivial) | ~3 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/publish.yml:
- Around line 98-102: Update the packageOrder definition in the release-note
generation logic to include local-surface between daytona-runner and cli,
matching the publish target list and preserving the intended release-note
ordering.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: a61f190e-0576-45ce-bbe6-3bbd19c64b60
📒 Files selected for processing (1)
.github/workflows/publish.yml
| # local-surface (→ deploy + persona-kit + runtime; consumed by cli) | ||
| # cli (→ persona-kit + workload-router + deploy + local-surface) | ||
| # agentworkforce (→ cli — umbrella wrapper, must publish last) | ||
| # personas-core publishes via the separate publish-personas.yml workflow. | ||
| echo "packages=events persona-kit runtime compose delivery workload-router deploy mcp-workforce daytona-runner cli agentworkforce" >> "$GITHUB_OUTPUT" | ||
| echo "packages=events persona-kit runtime compose delivery workload-router deploy mcp-workforce daytona-runner local-surface cli agentworkforce" >> "$GITHUB_OUTPUT" |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Keep release-note ordering in sync with the publish target list.
local-surface is now published, but it is missing from packageOrder at Lines 713-723. Its indexOf result is therefore -1, so release notes place it before the other packages instead of between daytona-runner and cli.
const packageOrder = [
// ...
'daytona-runner',
+ 'local-surface',
'cli',
'agentworkforce',
];🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/publish.yml around lines 98 - 102, Update the packageOrder
definition in the release-note generation logic to include local-surface between
daytona-runner and cli, matching the publish target list and preserving the
intended release-note ordering.
Summary
@agentworkforce/local-surface(added in feat(local-surface): fleet-node bridge for running proactive personas on a laptop #263) was never added to the hardcoded package list inpublish.yml's "Resolve target packages" step.pnpm packstep that rewritesworkspace:*deps to concrete versions beforenpm publish. It ended up on npm (v4.1.17, its only published version) with literal"workspace:*"strings still in itsdependenciesfor@agentworkforce/deploy,persona-kit, andruntime.npm installthat resolves this package now hard-crashes withUnsupported URL Type "workspace:": workspace:*(npm-package-arg can't parse the pnpm workspace protocol). This breaksnpm install -g agentworkforce@latestentirely, since@agentworkforce/clidepends onlocal-surface@4.1.17.local-surfaceto the topological package list, slotted after its workspace deps (deploy/persona-kit/runtime) and before its only consumer (cli).Test plan
yaml.safe_load)Publish Packagesworkflow run republisheslocal-surfaceat the new lockstep version viapnpm pack(confirms workspace refs are resolved in the published tarball)npm install -g agentworkforce@latestsucceeds after the new version is live🤖 Generated with Claude Code