16 changes: 14 additions & 2 deletions packages/cli/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -379,7 +379,9 @@ agentworkforce sources remove <dir|config-position>

Two fixed project sources always lead the cascade:
`<cwd>/.agentworkforce/workforce/personas/*.json`, then
`<cwd>/.agentworkforce/workforce/agents/<name>/persona.json`.
`<cwd>/.agentworkforce/workforce/agents/<name>/persona.json`. A third fixed
source, `~/.agentworkforce/workforce/agents/<name>/persona.json`, carries
personal agents and follows the personal personas dir wherever it ranks.

After that, the CLI reads an ordered list of configurable persona directories
from `~/.agentworkforce/workforce/config.json`. If no config exists, the list
Expand DownExpand Up@@ -477,13 +479,23 @@ wins):
2. `<cwd>/.agentworkforce/workforce/agents/<name>/persona.json` — **cwd:agents**
3. Configurable persona source dirs, in order. Default:
`~/.agentworkforce/workforce/personas/*.json` — **user**
4. Internal built-in system personas in `/personas/` — **library**
4. `~/.agentworkforce/workforce/agents/<name>/persona.json` — **user:agents**,
the personal mirror of `cwd:agents`. It rides directly behind the personal
personas dir, so moving that dir in the cascade moves both. The tables
printed by `list` and `sources list` show it as **personal:agents**,
following `user` → `personal`; `user:agents` is the value `--json` emits.
5. Internal built-in system personas in `/personas/` — **library**
Comment thread
cubic-dev-ai[bot] marked this conversation as resolved.

Local files are **partial overlays**: only the fields you set replace the
inherited value. Everything else cascades through from below.

### Agents that ship their own handler

The same directory layout works in a repo (`cwd:agents`) and in your personal
config (`user:agents`), so an agent you want everywhere lives in
`~/.agentworkforce/workforce/agents/<name>/` and a repo's own agents live in its
working tree. A repo agent outranks a personal one of the same id.

An agent with code of its own keeps persona, handler, tests, and README in one
directory:

Expand Down
280 changes: 279 additions & 1 deletion packages/cli/src/local-personas.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import test from 'node:test';
import assert from 'node:assert/strict';
import { mkdtempSync, mkdirSync, rmSync, writeFileSync } from 'node:fs';
import { mkdtempSync, mkdirSync, rmSync, utimesSync, writeFileSync } from 'node:fs';
import { tmpdir } from 'node:os';
import { join } from 'node:path';

Expand DownExpand Up@@ -1034,3 +1034,281 @@ test('a missing agents/ directory is not an error', () => {
assert.deepEqual(loaded.warnings, []);
});
});

// --- handler agents ---------------------------------------------------------
// An agent driven by its `onEvent` entry has no interactive launch to
// configure, so harness/model/systemPrompt are optional. Requiring them kept
// exactly these agents out of the cascade the agents/ dir was added for.

test('a handler persona loads without interactive fields', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Weekly digest handler.',
cloud: true,
onEvent: './agent.ts',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
const spec = loaded.byId.get('digest');
assert.ok(spec);
assert.equal(spec.onEvent, './agent.ts');
assert.equal(spec.cloud, true);
assert.equal(spec.harness, undefined);
assert.equal(spec.model, undefined);
assert.equal(spec.systemPrompt, undefined);
});
});

test('a standalone persona with no handler still requires harness', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'interactive');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'interactive',
intent: 'documentation',
description: 'No handler, so an operator launches it.',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.equal(loaded.byId.has('interactive'), false);
assert.match(loaded.warnings[0] ?? '', /harness is required for standalone personas/);
});
});

test('an overlay tweaking env keeps the handler entry it inherits', () => {
withAgentLayer(({ cwd, homeDir, pwdDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Weekly digest handler.',
cloud: true,
onEvent: './agent.ts',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
writeJson(join(pwdDir, 'digest.json'), { id: 'digest', env: { TONE: 'terse' } });

const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
const spec = loaded.byId.get('digest');
assert.equal(spec?.onEvent, './agent.ts');
assert.equal(spec?.cloud, true);
assert.equal(spec?.env?.TONE, 'terse');
});
});

test('onEvent may not escape the agent directory', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Escapes its directory.',
onEvent: '../../../elsewhere/agent.ts',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.equal(loaded.byId.has('digest'), false);
assert.match(loaded.warnings[0] ?? '', /onEvent must not contain "\.\." segments/);
});
});

test('a padded onEvent is normalized before it is stored', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Padded but legal handler path.',
onEvent: ' ./agent.ts',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
// Stored untrimmed this resolves against a directory named " .".
assert.equal(loaded.byId.get('digest')?.onEvent, './agent.ts');
});
});

test('onEvent must point at a handler source file', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Points at prose, not a handler.',
onEvent: 'README.md',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
// Without the extension rule this would read as a handler and skip the
// interactive fields it never declared.
assert.equal(loaded.byId.has('digest'), false);
assert.match(loaded.warnings[0] ?? '', /must point at a \.ts/);
});
});

test('a padded onEvent cannot smuggle a .. segment past the guard', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Escapes once trimmed.',
onEvent: ' ../outside/agent.ts ',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.equal(loaded.byId.has('digest'), false);
// Trimmed before validation, so the traversal guard sees the real path.
assert.match(loaded.warnings[0] ?? '', /onEvent must not contain "\.\." segments/);
});
});

test('a persona.json older than its authoring source warns but still loads', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'proposal-agent');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'proposal-agent',
extends: 'persona-maker',
env: { COMPILED: 'stale' }
});
writeFileSync(join(agentDir, 'persona.ts'), 'export default {}\n');
// Backdate the artifact rather than sleeping — same relation, no wall clock.
const past = new Date(Date.now() - 60_000);
utimesSync(join(agentDir, 'persona.json'), past, past);

const loaded = loadLocalPersonas({ cwd, homeDir });
assert.equal(loaded.warnings.length, 1);
assert.match(loaded.warnings[0] ?? '', /persona\.json is older than persona\.ts/);
assert.match(loaded.warnings[0] ?? '', /agentworkforce persona compile/);
// Still served: a forgotten compile must not read as a missing persona.
assert.equal(loaded.byId.get('proposal-agent')?.env?.COMPILED, 'stale');
});
});

test('a persona.json newer than its authoring source is silent', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'proposal-agent');
mkdirSync(agentDir, { recursive: true });
writeFileSync(join(agentDir, 'persona.ts'), 'export default {}\n');
writeJson(join(agentDir, 'persona.json'), {
id: 'proposal-agent',
extends: 'persona-maker'
});
const past = new Date(Date.now() - 60_000);
utimesSync(join(agentDir, 'persona.ts'), past, past);

const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
assert.ok(loaded.byId.has('proposal-agent'));
});
});

test('staleness is measured against the newest authoring file, not the first', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'proposal-agent');
mkdirSync(agentDir, { recursive: true });
// An abandoned persona.ts predates the artifact; the live persona.js is
// newer. Measuring against the .ts alone would call this fresh.
writeFileSync(join(agentDir, 'persona.ts'), 'export default {}\n');
writeJson(join(agentDir, 'persona.json'), { id: 'proposal-agent', extends: 'persona-maker' });
writeFileSync(join(agentDir, 'persona.js'), 'export default {}\n');

const old = new Date(Date.now() - 120_000);
utimesSync(join(agentDir, 'persona.ts'), old, old);
const mid = new Date(Date.now() - 60_000);
utimesSync(join(agentDir, 'persona.json'), mid, mid);

const loaded = loadLocalPersonas({ cwd, homeDir });
assert.equal(loaded.warnings.length, 1);
assert.match(loaded.warnings[0] ?? '', /persona\.json is older than persona\.js/);
});
});

// --- user:agents layer ------------------------------------------------------
// The personal mirror of cwd:agents — an agent-with-handler a user keeps
// across every repo, in the `agents/` sibling of their personal personas dir.

test('the personal agents dir loads as user:agents', () => {
withLayers(({ cwd, home, homeDir }) => {
const userAgents = join(home, '.agentworkforce', 'workforce', 'agents');
mkdirSync(join(userAgents, 'note-taker'), { recursive: true });
writeJson(join(userAgents, 'note-taker', 'persona.json'), {
id: 'note-taker',
extends: 'persona-maker',
env: { SCOPE: 'personal' }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
assert.equal(loaded.sources.get('note-taker'), 'user:agents');
assert.equal(loaded.byId.get('note-taker')?.env?.SCOPE, 'personal');
});
});

test('a personal agent resolves its skills against its own directory', () => {
withLayers(({ cwd, home, homeDir }) => {
const workforceHome = join(home, '.agentworkforce', 'workforce');
mkdirSync(join(workforceHome, 'skills'), { recursive: true });
writeFileSync(join(workforceHome, 'skills', 'voice.md'), '# voice\n');
const agentDir = join(workforceHome, 'agents', 'note-taker');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'note-taker',
extends: 'persona-maker',
skills: [{ id: 'local/voice', source: '../../skills/voice.md', description: 'voice' }]
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
assert.equal(
loaded.byId.get('note-taker')?.skills[0]?.source,
join(workforceHome, 'skills', 'voice.md')
);
});
});

test('a repo agent outranks a personal agent of the same id', () => {
withAgentLayer(({ cwd, home, homeDir, agentsDir }) => {
const userAgents = join(home, '.agentworkforce', 'workforce', 'agents');
mkdirSync(join(userAgents, 'note-taker'), { recursive: true });
writeJson(join(userAgents, 'note-taker', 'persona.json'), {
id: 'note-taker',
extends: 'persona-maker',
env: { SCOPE: 'personal', KEPT: 'yes' }
});
mkdirSync(join(agentsDir, 'note-taker'), { recursive: true });
writeJson(join(agentsDir, 'note-taker', 'persona.json'), {
id: 'note-taker',
env: { SCOPE: 'repo' }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
assert.equal(loaded.sources.get('note-taker'), 'cwd:agents');
const spec = loaded.byId.get('note-taker');
assert.equal(spec?.env?.SCOPE, 'repo');
assert.equal(spec?.env?.KEPT, 'yes');
});
});

test('user:agents displays as personal:agents, following user -> personal', () => {
assert.equal(formatPersonaSourceLabel('user:agents'), 'personal:agents');
assert.equal(formatPersonaSourceLabel('cwd:agents'), 'cwd:agents');
});

test('a missing personal agents dir is not an error', () => {
withLayers(({ cwd, homeDir }) => {
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
});
});
2 changes: 1 addition & 1 deletion packages/persona-registry/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@

Programmatic resolution for AgentWorkforce personas. It owns the same source
cascade used by the CLI: cwd personas, cwd agents, configured directories
(including the personal directory), then the built-in catalog.
(including the personal directory), personal agents, then the built-in catalog.

```ts
import { resolvePersonaReference } from '@agentworkforce/persona-registry';
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
16 changes: 14 additions & 2 deletions packages/cli/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -379,7 +379,9 @@ agentworkforce sources remove <dir|config-position>

Two fixed project sources always lead the cascade:
`<cwd>/.agentworkforce/workforce/personas/*.json`, then
`<cwd>/.agentworkforce/workforce/agents/<name>/persona.json`.
`<cwd>/.agentworkforce/workforce/agents/<name>/persona.json`. A third fixed
source, `~/.agentworkforce/workforce/agents/<name>/persona.json`, carries
personal agents and follows the personal personas dir wherever it ranks.

After that, the CLI reads an ordered list of configurable persona directories
from `~/.agentworkforce/workforce/config.json`. If no config exists, the list
Expand DownExpand Up@@ -477,13 +479,23 @@ wins):
2. `<cwd>/.agentworkforce/workforce/agents/<name>/persona.json` — **cwd:agents**
3. Configurable persona source dirs, in order. Default:
`~/.agentworkforce/workforce/personas/*.json` — **user**
4. Internal built-in system personas in `/personas/` — **library**
4. `~/.agentworkforce/workforce/agents/<name>/persona.json` — **user:agents**,
the personal mirror of `cwd:agents`. It rides directly behind the personal
personas dir, so moving that dir in the cascade moves both. The tables
printed by `list` and `sources list` show it as **personal:agents**,
following `user` → `personal`; `user:agents` is the value `--json` emits.
5. Internal built-in system personas in `/personas/` — **library**
Comment thread
cubic-dev-ai[bot] marked this conversation as resolved.

Local files are **partial overlays**: only the fields you set replace the
inherited value. Everything else cascades through from below.

### Agents that ship their own handler

The same directory layout works in a repo (`cwd:agents`) and in your personal
config (`user:agents`), so an agent you want everywhere lives in
`~/.agentworkforce/workforce/agents/<name>/` and a repo's own agents live in its
working tree. A repo agent outranks a personal one of the same id.

An agent with code of its own keeps persona, handler, tests, and README in one
directory:

Expand Down
280 changes: 279 additions & 1 deletion packages/cli/src/local-personas.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import test from 'node:test';
import assert from 'node:assert/strict';
import { mkdtempSync, mkdirSync, rmSync, writeFileSync } from 'node:fs';
import { mkdtempSync, mkdirSync, rmSync, utimesSync, writeFileSync } from 'node:fs';
import { tmpdir } from 'node:os';
import { join } from 'node:path';

Expand DownExpand Up@@ -1034,3 +1034,281 @@ test('a missing agents/ directory is not an error', () => {
assert.deepEqual(loaded.warnings, []);
});
});

// --- handler agents ---------------------------------------------------------
// An agent driven by its `onEvent` entry has no interactive launch to
// configure, so harness/model/systemPrompt are optional. Requiring them kept
// exactly these agents out of the cascade the agents/ dir was added for.

test('a handler persona loads without interactive fields', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Weekly digest handler.',
cloud: true,
onEvent: './agent.ts',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
const spec = loaded.byId.get('digest');
assert.ok(spec);
assert.equal(spec.onEvent, './agent.ts');
assert.equal(spec.cloud, true);
assert.equal(spec.harness, undefined);
assert.equal(spec.model, undefined);
assert.equal(spec.systemPrompt, undefined);
});
});

test('a standalone persona with no handler still requires harness', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'interactive');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'interactive',
intent: 'documentation',
description: 'No handler, so an operator launches it.',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.equal(loaded.byId.has('interactive'), false);
assert.match(loaded.warnings[0] ?? '', /harness is required for standalone personas/);
});
});

test('an overlay tweaking env keeps the handler entry it inherits', () => {
withAgentLayer(({ cwd, homeDir, pwdDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Weekly digest handler.',
cloud: true,
onEvent: './agent.ts',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
writeJson(join(pwdDir, 'digest.json'), { id: 'digest', env: { TONE: 'terse' } });

const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
const spec = loaded.byId.get('digest');
assert.equal(spec?.onEvent, './agent.ts');
assert.equal(spec?.cloud, true);
assert.equal(spec?.env?.TONE, 'terse');
});
});

test('onEvent may not escape the agent directory', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Escapes its directory.',
onEvent: '../../../elsewhere/agent.ts',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.equal(loaded.byId.has('digest'), false);
assert.match(loaded.warnings[0] ?? '', /onEvent must not contain "\.\." segments/);
});
});

test('a padded onEvent is normalized before it is stored', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Padded but legal handler path.',
onEvent: ' ./agent.ts',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
// Stored untrimmed this resolves against a directory named " .".
assert.equal(loaded.byId.get('digest')?.onEvent, './agent.ts');
});
});

test('onEvent must point at a handler source file', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Points at prose, not a handler.',
onEvent: 'README.md',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
// Without the extension rule this would read as a handler and skip the
// interactive fields it never declared.
assert.equal(loaded.byId.has('digest'), false);
assert.match(loaded.warnings[0] ?? '', /must point at a \.ts/);
});
});

test('a padded onEvent cannot smuggle a .. segment past the guard', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Escapes once trimmed.',
onEvent: ' ../outside/agent.ts ',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.equal(loaded.byId.has('digest'), false);
// Trimmed before validation, so the traversal guard sees the real path.
assert.match(loaded.warnings[0] ?? '', /onEvent must not contain "\.\." segments/);
});
});

test('a persona.json older than its authoring source warns but still loads', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'proposal-agent');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'proposal-agent',
extends: 'persona-maker',
env: { COMPILED: 'stale' }
});
writeFileSync(join(agentDir, 'persona.ts'), 'export default {}\n');
// Backdate the artifact rather than sleeping — same relation, no wall clock.
const past = new Date(Date.now() - 60_000);
utimesSync(join(agentDir, 'persona.json'), past, past);

const loaded = loadLocalPersonas({ cwd, homeDir });
assert.equal(loaded.warnings.length, 1);
assert.match(loaded.warnings[0] ?? '', /persona\.json is older than persona\.ts/);
assert.match(loaded.warnings[0] ?? '', /agentworkforce persona compile/);
// Still served: a forgotten compile must not read as a missing persona.
assert.equal(loaded.byId.get('proposal-agent')?.env?.COMPILED, 'stale');
});
});

test('a persona.json newer than its authoring source is silent', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'proposal-agent');
mkdirSync(agentDir, { recursive: true });
writeFileSync(join(agentDir, 'persona.ts'), 'export default {}\n');
writeJson(join(agentDir, 'persona.json'), {
id: 'proposal-agent',
extends: 'persona-maker'
});
const past = new Date(Date.now() - 60_000);
utimesSync(join(agentDir, 'persona.ts'), past, past);

const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
assert.ok(loaded.byId.has('proposal-agent'));
});
});

test('staleness is measured against the newest authoring file, not the first', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'proposal-agent');
mkdirSync(agentDir, { recursive: true });
// An abandoned persona.ts predates the artifact; the live persona.js is
// newer. Measuring against the .ts alone would call this fresh.
writeFileSync(join(agentDir, 'persona.ts'), 'export default {}\n');
writeJson(join(agentDir, 'persona.json'), { id: 'proposal-agent', extends: 'persona-maker' });
writeFileSync(join(agentDir, 'persona.js'), 'export default {}\n');

const old = new Date(Date.now() - 120_000);
utimesSync(join(agentDir, 'persona.ts'), old, old);
const mid = new Date(Date.now() - 60_000);
utimesSync(join(agentDir, 'persona.json'), mid, mid);

const loaded = loadLocalPersonas({ cwd, homeDir });
assert.equal(loaded.warnings.length, 1);
assert.match(loaded.warnings[0] ?? '', /persona\.json is older than persona\.js/);
});
});

// --- user:agents layer ------------------------------------------------------
// The personal mirror of cwd:agents — an agent-with-handler a user keeps
// across every repo, in the `agents/` sibling of their personal personas dir.

test('the personal agents dir loads as user:agents', () => {
withLayers(({ cwd, home, homeDir }) => {
const userAgents = join(home, '.agentworkforce', 'workforce', 'agents');
mkdirSync(join(userAgents, 'note-taker'), { recursive: true });
writeJson(join(userAgents, 'note-taker', 'persona.json'), {
id: 'note-taker',
extends: 'persona-maker',
env: { SCOPE: 'personal' }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
assert.equal(loaded.sources.get('note-taker'), 'user:agents');
assert.equal(loaded.byId.get('note-taker')?.env?.SCOPE, 'personal');
});
});

test('a personal agent resolves its skills against its own directory', () => {
withLayers(({ cwd, home, homeDir }) => {
const workforceHome = join(home, '.agentworkforce', 'workforce');
mkdirSync(join(workforceHome, 'skills'), { recursive: true });
writeFileSync(join(workforceHome, 'skills', 'voice.md'), '# voice\n');
const agentDir = join(workforceHome, 'agents', 'note-taker');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'note-taker',
extends: 'persona-maker',
skills: [{ id: 'local/voice', source: '../../skills/voice.md', description: 'voice' }]
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
assert.equal(
loaded.byId.get('note-taker')?.skills[0]?.source,
join(workforceHome, 'skills', 'voice.md')
);
});
});

test('a repo agent outranks a personal agent of the same id', () => {
withAgentLayer(({ cwd, home, homeDir, agentsDir }) => {
const userAgents = join(home, '.agentworkforce', 'workforce', 'agents');
mkdirSync(join(userAgents, 'note-taker'), { recursive: true });
writeJson(join(userAgents, 'note-taker', 'persona.json'), {
id: 'note-taker',
extends: 'persona-maker',
env: { SCOPE: 'personal', KEPT: 'yes' }
});
mkdirSync(join(agentsDir, 'note-taker'), { recursive: true });
writeJson(join(agentsDir, 'note-taker', 'persona.json'), {
id: 'note-taker',
env: { SCOPE: 'repo' }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
assert.equal(loaded.sources.get('note-taker'), 'cwd:agents');
const spec = loaded.byId.get('note-taker');
assert.equal(spec?.env?.SCOPE, 'repo');
assert.equal(spec?.env?.KEPT, 'yes');
});
});

test('user:agents displays as personal:agents, following user -> personal', () => {
assert.equal(formatPersonaSourceLabel('user:agents'), 'personal:agents');
assert.equal(formatPersonaSourceLabel('cwd:agents'), 'cwd:agents');
});

test('a missing personal agents dir is not an error', () => {
withLayers(({ cwd, homeDir }) => {
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
});
});
2 changes: 1 addition & 1 deletion packages/persona-registry/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@

Programmatic resolution for AgentWorkforce personas. It owns the same source
cascade used by the CLI: cwd personas, cwd agents, configured directories
(including the personal directory), then the built-in catalog.
(including the personal directory), personal agents, then the built-in catalog.

```ts
import { resolvePersonaReference } from '@agentworkforce/persona-registry';
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
16 changes: 14 additions & 2 deletions packages/cli/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -379,7 +379,9 @@ agentworkforce sources remove <dir|config-position>

Two fixed project sources always lead the cascade:
`<cwd>/.agentworkforce/workforce/personas/*.json`, then
`<cwd>/.agentworkforce/workforce/agents/<name>/persona.json`.
`<cwd>/.agentworkforce/workforce/agents/<name>/persona.json`. A third fixed
source, `~/.agentworkforce/workforce/agents/<name>/persona.json`, carries
personal agents and follows the personal personas dir wherever it ranks.

After that, the CLI reads an ordered list of configurable persona directories
from `~/.agentworkforce/workforce/config.json`. If no config exists, the list
Expand DownExpand Up@@ -477,13 +479,23 @@ wins):
2. `<cwd>/.agentworkforce/workforce/agents/<name>/persona.json` — **cwd:agents**
3. Configurable persona source dirs, in order. Default:
`~/.agentworkforce/workforce/personas/*.json` — **user**
4. Internal built-in system personas in `/personas/` — **library**
4. `~/.agentworkforce/workforce/agents/<name>/persona.json` — **user:agents**,
the personal mirror of `cwd:agents`. It rides directly behind the personal
personas dir, so moving that dir in the cascade moves both. The tables
printed by `list` and `sources list` show it as **personal:agents**,
following `user` → `personal`; `user:agents` is the value `--json` emits.
5. Internal built-in system personas in `/personas/` — **library**
Comment thread
cubic-dev-ai[bot] marked this conversation as resolved.

Local files are **partial overlays**: only the fields you set replace the
inherited value. Everything else cascades through from below.

### Agents that ship their own handler

The same directory layout works in a repo (`cwd:agents`) and in your personal
config (`user:agents`), so an agent you want everywhere lives in
`~/.agentworkforce/workforce/agents/<name>/` and a repo's own agents live in its
working tree. A repo agent outranks a personal one of the same id.

An agent with code of its own keeps persona, handler, tests, and README in one
directory:

Expand Down
280 changes: 279 additions & 1 deletion packages/cli/src/local-personas.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import test from 'node:test';
import assert from 'node:assert/strict';
import { mkdtempSync, mkdirSync, rmSync, writeFileSync } from 'node:fs';
import { mkdtempSync, mkdirSync, rmSync, utimesSync, writeFileSync } from 'node:fs';
import { tmpdir } from 'node:os';
import { join } from 'node:path';

Expand DownExpand Up@@ -1034,3 +1034,281 @@ test('a missing agents/ directory is not an error', () => {
assert.deepEqual(loaded.warnings, []);
});
});

// --- handler agents ---------------------------------------------------------
// An agent driven by its `onEvent` entry has no interactive launch to
// configure, so harness/model/systemPrompt are optional. Requiring them kept
// exactly these agents out of the cascade the agents/ dir was added for.

test('a handler persona loads without interactive fields', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Weekly digest handler.',
cloud: true,
onEvent: './agent.ts',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
const spec = loaded.byId.get('digest');
assert.ok(spec);
assert.equal(spec.onEvent, './agent.ts');
assert.equal(spec.cloud, true);
assert.equal(spec.harness, undefined);
assert.equal(spec.model, undefined);
assert.equal(spec.systemPrompt, undefined);
});
});

test('a standalone persona with no handler still requires harness', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'interactive');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'interactive',
intent: 'documentation',
description: 'No handler, so an operator launches it.',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.equal(loaded.byId.has('interactive'), false);
assert.match(loaded.warnings[0] ?? '', /harness is required for standalone personas/);
});
});

test('an overlay tweaking env keeps the handler entry it inherits', () => {
withAgentLayer(({ cwd, homeDir, pwdDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Weekly digest handler.',
cloud: true,
onEvent: './agent.ts',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
writeJson(join(pwdDir, 'digest.json'), { id: 'digest', env: { TONE: 'terse' } });

const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
const spec = loaded.byId.get('digest');
assert.equal(spec?.onEvent, './agent.ts');
assert.equal(spec?.cloud, true);
assert.equal(spec?.env?.TONE, 'terse');
});
});

test('onEvent may not escape the agent directory', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Escapes its directory.',
onEvent: '../../../elsewhere/agent.ts',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.equal(loaded.byId.has('digest'), false);
assert.match(loaded.warnings[0] ?? '', /onEvent must not contain "\.\." segments/);
});
});

test('a padded onEvent is normalized before it is stored', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Padded but legal handler path.',
onEvent: ' ./agent.ts',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
// Stored untrimmed this resolves against a directory named " .".
assert.equal(loaded.byId.get('digest')?.onEvent, './agent.ts');
});
});

test('onEvent must point at a handler source file', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Points at prose, not a handler.',
onEvent: 'README.md',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
// Without the extension rule this would read as a handler and skip the
// interactive fields it never declared.
assert.equal(loaded.byId.has('digest'), false);
assert.match(loaded.warnings[0] ?? '', /must point at a \.ts/);
});
});

test('a padded onEvent cannot smuggle a .. segment past the guard', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Escapes once trimmed.',
onEvent: ' ../outside/agent.ts ',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.equal(loaded.byId.has('digest'), false);
// Trimmed before validation, so the traversal guard sees the real path.
assert.match(loaded.warnings[0] ?? '', /onEvent must not contain "\.\." segments/);
});
});

test('a persona.json older than its authoring source warns but still loads', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'proposal-agent');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'proposal-agent',
extends: 'persona-maker',
env: { COMPILED: 'stale' }
});
writeFileSync(join(agentDir, 'persona.ts'), 'export default {}\n');
// Backdate the artifact rather than sleeping — same relation, no wall clock.
const past = new Date(Date.now() - 60_000);
utimesSync(join(agentDir, 'persona.json'), past, past);

const loaded = loadLocalPersonas({ cwd, homeDir });
assert.equal(loaded.warnings.length, 1);
assert.match(loaded.warnings[0] ?? '', /persona\.json is older than persona\.ts/);
assert.match(loaded.warnings[0] ?? '', /agentworkforce persona compile/);
// Still served: a forgotten compile must not read as a missing persona.
assert.equal(loaded.byId.get('proposal-agent')?.env?.COMPILED, 'stale');
});
});

test('a persona.json newer than its authoring source is silent', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'proposal-agent');
mkdirSync(agentDir, { recursive: true });
writeFileSync(join(agentDir, 'persona.ts'), 'export default {}\n');
writeJson(join(agentDir, 'persona.json'), {
id: 'proposal-agent',
extends: 'persona-maker'
});
const past = new Date(Date.now() - 60_000);
utimesSync(join(agentDir, 'persona.ts'), past, past);

const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
assert.ok(loaded.byId.has('proposal-agent'));
});
});

test('staleness is measured against the newest authoring file, not the first', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'proposal-agent');
mkdirSync(agentDir, { recursive: true });
// An abandoned persona.ts predates the artifact; the live persona.js is
// newer. Measuring against the .ts alone would call this fresh.
writeFileSync(join(agentDir, 'persona.ts'), 'export default {}\n');
writeJson(join(agentDir, 'persona.json'), { id: 'proposal-agent', extends: 'persona-maker' });
writeFileSync(join(agentDir, 'persona.js'), 'export default {}\n');

const old = new Date(Date.now() - 120_000);
utimesSync(join(agentDir, 'persona.ts'), old, old);
const mid = new Date(Date.now() - 60_000);
utimesSync(join(agentDir, 'persona.json'), mid, mid);

const loaded = loadLocalPersonas({ cwd, homeDir });
assert.equal(loaded.warnings.length, 1);
assert.match(loaded.warnings[0] ?? '', /persona\.json is older than persona\.js/);
});
});

// --- user:agents layer ------------------------------------------------------
// The personal mirror of cwd:agents — an agent-with-handler a user keeps
// across every repo, in the `agents/` sibling of their personal personas dir.

test('the personal agents dir loads as user:agents', () => {
withLayers(({ cwd, home, homeDir }) => {
const userAgents = join(home, '.agentworkforce', 'workforce', 'agents');
mkdirSync(join(userAgents, 'note-taker'), { recursive: true });
writeJson(join(userAgents, 'note-taker', 'persona.json'), {
id: 'note-taker',
extends: 'persona-maker',
env: { SCOPE: 'personal' }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
assert.equal(loaded.sources.get('note-taker'), 'user:agents');
assert.equal(loaded.byId.get('note-taker')?.env?.SCOPE, 'personal');
});
});

test('a personal agent resolves its skills against its own directory', () => {
withLayers(({ cwd, home, homeDir }) => {
const workforceHome = join(home, '.agentworkforce', 'workforce');
mkdirSync(join(workforceHome, 'skills'), { recursive: true });
writeFileSync(join(workforceHome, 'skills', 'voice.md'), '# voice\n');
const agentDir = join(workforceHome, 'agents', 'note-taker');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'note-taker',
extends: 'persona-maker',
skills: [{ id: 'local/voice', source: '../../skills/voice.md', description: 'voice' }]
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
assert.equal(
loaded.byId.get('note-taker')?.skills[0]?.source,
join(workforceHome, 'skills', 'voice.md')
);
});
});

test('a repo agent outranks a personal agent of the same id', () => {
withAgentLayer(({ cwd, home, homeDir, agentsDir }) => {
const userAgents = join(home, '.agentworkforce', 'workforce', 'agents');
mkdirSync(join(userAgents, 'note-taker'), { recursive: true });
writeJson(join(userAgents, 'note-taker', 'persona.json'), {
id: 'note-taker',
extends: 'persona-maker',
env: { SCOPE: 'personal', KEPT: 'yes' }
});
mkdirSync(join(agentsDir, 'note-taker'), { recursive: true });
writeJson(join(agentsDir, 'note-taker', 'persona.json'), {
id: 'note-taker',
env: { SCOPE: 'repo' }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
assert.equal(loaded.sources.get('note-taker'), 'cwd:agents');
const spec = loaded.byId.get('note-taker');
assert.equal(spec?.env?.SCOPE, 'repo');
assert.equal(spec?.env?.KEPT, 'yes');
});
});

test('user:agents displays as personal:agents, following user -> personal', () => {
assert.equal(formatPersonaSourceLabel('user:agents'), 'personal:agents');
assert.equal(formatPersonaSourceLabel('cwd:agents'), 'cwd:agents');
});

test('a missing personal agents dir is not an error', () => {
withLayers(({ cwd, homeDir }) => {
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
});
});
2 changes: 1 addition & 1 deletion packages/persona-registry/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@

Programmatic resolution for AgentWorkforce personas. It owns the same source
cascade used by the CLI: cwd personas, cwd agents, configured directories
(including the personal directory), then the built-in catalog.
(including the personal directory), personal agents, then the built-in catalog.

```ts
import { resolvePersonaReference } from '@agentworkforce/persona-registry';
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
16 changes: 14 additions & 2 deletions packages/cli/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -379,7 +379,9 @@ agentworkforce sources remove <dir|config-position>

Two fixed project sources always lead the cascade:
`<cwd>/.agentworkforce/workforce/personas/*.json`, then
`<cwd>/.agentworkforce/workforce/agents/<name>/persona.json`.
`<cwd>/.agentworkforce/workforce/agents/<name>/persona.json`. A third fixed
source, `~/.agentworkforce/workforce/agents/<name>/persona.json`, carries
personal agents and follows the personal personas dir wherever it ranks.

After that, the CLI reads an ordered list of configurable persona directories
from `~/.agentworkforce/workforce/config.json`. If no config exists, the list
Expand DownExpand Up@@ -477,13 +479,23 @@ wins):
2. `<cwd>/.agentworkforce/workforce/agents/<name>/persona.json` — **cwd:agents**
3. Configurable persona source dirs, in order. Default:
`~/.agentworkforce/workforce/personas/*.json` — **user**
4. Internal built-in system personas in `/personas/` — **library**
4. `~/.agentworkforce/workforce/agents/<name>/persona.json` — **user:agents**,
the personal mirror of `cwd:agents`. It rides directly behind the personal
personas dir, so moving that dir in the cascade moves both. The tables
printed by `list` and `sources list` show it as **personal:agents**,
following `user` → `personal`; `user:agents` is the value `--json` emits.
5. Internal built-in system personas in `/personas/` — **library**
Comment thread
cubic-dev-ai[bot] marked this conversation as resolved.

Local files are **partial overlays**: only the fields you set replace the
inherited value. Everything else cascades through from below.

### Agents that ship their own handler

The same directory layout works in a repo (`cwd:agents`) and in your personal
config (`user:agents`), so an agent you want everywhere lives in
`~/.agentworkforce/workforce/agents/<name>/` and a repo's own agents live in its
working tree. A repo agent outranks a personal one of the same id.

An agent with code of its own keeps persona, handler, tests, and README in one
directory:

Expand Down
280 changes: 279 additions & 1 deletion packages/cli/src/local-personas.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import test from 'node:test';
import assert from 'node:assert/strict';
import { mkdtempSync, mkdirSync, rmSync, writeFileSync } from 'node:fs';
import { mkdtempSync, mkdirSync, rmSync, utimesSync, writeFileSync } from 'node:fs';
import { tmpdir } from 'node:os';
import { join } from 'node:path';

Expand DownExpand Up@@ -1034,3 +1034,281 @@ test('a missing agents/ directory is not an error', () => {
assert.deepEqual(loaded.warnings, []);
});
});

// --- handler agents ---------------------------------------------------------
// An agent driven by its `onEvent` entry has no interactive launch to
// configure, so harness/model/systemPrompt are optional. Requiring them kept
// exactly these agents out of the cascade the agents/ dir was added for.

test('a handler persona loads without interactive fields', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Weekly digest handler.',
cloud: true,
onEvent: './agent.ts',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
const spec = loaded.byId.get('digest');
assert.ok(spec);
assert.equal(spec.onEvent, './agent.ts');
assert.equal(spec.cloud, true);
assert.equal(spec.harness, undefined);
assert.equal(spec.model, undefined);
assert.equal(spec.systemPrompt, undefined);
});
});

test('a standalone persona with no handler still requires harness', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'interactive');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'interactive',
intent: 'documentation',
description: 'No handler, so an operator launches it.',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.equal(loaded.byId.has('interactive'), false);
assert.match(loaded.warnings[0] ?? '', /harness is required for standalone personas/);
});
});

test('an overlay tweaking env keeps the handler entry it inherits', () => {
withAgentLayer(({ cwd, homeDir, pwdDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Weekly digest handler.',
cloud: true,
onEvent: './agent.ts',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
writeJson(join(pwdDir, 'digest.json'), { id: 'digest', env: { TONE: 'terse' } });

const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
const spec = loaded.byId.get('digest');
assert.equal(spec?.onEvent, './agent.ts');
assert.equal(spec?.cloud, true);
assert.equal(spec?.env?.TONE, 'terse');
});
});

test('onEvent may not escape the agent directory', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Escapes its directory.',
onEvent: '../../../elsewhere/agent.ts',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.equal(loaded.byId.has('digest'), false);
assert.match(loaded.warnings[0] ?? '', /onEvent must not contain "\.\." segments/);
});
});

test('a padded onEvent is normalized before it is stored', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Padded but legal handler path.',
onEvent: ' ./agent.ts',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
// Stored untrimmed this resolves against a directory named " .".
assert.equal(loaded.byId.get('digest')?.onEvent, './agent.ts');
});
});

test('onEvent must point at a handler source file', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Points at prose, not a handler.',
onEvent: 'README.md',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
// Without the extension rule this would read as a handler and skip the
// interactive fields it never declared.
assert.equal(loaded.byId.has('digest'), false);
assert.match(loaded.warnings[0] ?? '', /must point at a \.ts/);
});
});

test('a padded onEvent cannot smuggle a .. segment past the guard', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Escapes once trimmed.',
onEvent: ' ../outside/agent.ts ',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.equal(loaded.byId.has('digest'), false);
// Trimmed before validation, so the traversal guard sees the real path.
assert.match(loaded.warnings[0] ?? '', /onEvent must not contain "\.\." segments/);
});
});

test('a persona.json older than its authoring source warns but still loads', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'proposal-agent');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'proposal-agent',
extends: 'persona-maker',
env: { COMPILED: 'stale' }
});
writeFileSync(join(agentDir, 'persona.ts'), 'export default {}\n');
// Backdate the artifact rather than sleeping — same relation, no wall clock.
const past = new Date(Date.now() - 60_000);
utimesSync(join(agentDir, 'persona.json'), past, past);

const loaded = loadLocalPersonas({ cwd, homeDir });
assert.equal(loaded.warnings.length, 1);
assert.match(loaded.warnings[0] ?? '', /persona\.json is older than persona\.ts/);
assert.match(loaded.warnings[0] ?? '', /agentworkforce persona compile/);
// Still served: a forgotten compile must not read as a missing persona.
assert.equal(loaded.byId.get('proposal-agent')?.env?.COMPILED, 'stale');
});
});

test('a persona.json newer than its authoring source is silent', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'proposal-agent');
mkdirSync(agentDir, { recursive: true });
writeFileSync(join(agentDir, 'persona.ts'), 'export default {}\n');
writeJson(join(agentDir, 'persona.json'), {
id: 'proposal-agent',
extends: 'persona-maker'
});
const past = new Date(Date.now() - 60_000);
utimesSync(join(agentDir, 'persona.ts'), past, past);

const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
assert.ok(loaded.byId.has('proposal-agent'));
});
});

test('staleness is measured against the newest authoring file, not the first', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'proposal-agent');
mkdirSync(agentDir, { recursive: true });
// An abandoned persona.ts predates the artifact; the live persona.js is
// newer. Measuring against the .ts alone would call this fresh.
writeFileSync(join(agentDir, 'persona.ts'), 'export default {}\n');
writeJson(join(agentDir, 'persona.json'), { id: 'proposal-agent', extends: 'persona-maker' });
writeFileSync(join(agentDir, 'persona.js'), 'export default {}\n');

const old = new Date(Date.now() - 120_000);
utimesSync(join(agentDir, 'persona.ts'), old, old);
const mid = new Date(Date.now() - 60_000);
utimesSync(join(agentDir, 'persona.json'), mid, mid);

const loaded = loadLocalPersonas({ cwd, homeDir });
assert.equal(loaded.warnings.length, 1);
assert.match(loaded.warnings[0] ?? '', /persona\.json is older than persona\.js/);
});
});

// --- user:agents layer ------------------------------------------------------
// The personal mirror of cwd:agents — an agent-with-handler a user keeps
// across every repo, in the `agents/` sibling of their personal personas dir.

test('the personal agents dir loads as user:agents', () => {
withLayers(({ cwd, home, homeDir }) => {
const userAgents = join(home, '.agentworkforce', 'workforce', 'agents');
mkdirSync(join(userAgents, 'note-taker'), { recursive: true });
writeJson(join(userAgents, 'note-taker', 'persona.json'), {
id: 'note-taker',
extends: 'persona-maker',
env: { SCOPE: 'personal' }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
assert.equal(loaded.sources.get('note-taker'), 'user:agents');
assert.equal(loaded.byId.get('note-taker')?.env?.SCOPE, 'personal');
});
});

test('a personal agent resolves its skills against its own directory', () => {
withLayers(({ cwd, home, homeDir }) => {
const workforceHome = join(home, '.agentworkforce', 'workforce');
mkdirSync(join(workforceHome, 'skills'), { recursive: true });
writeFileSync(join(workforceHome, 'skills', 'voice.md'), '# voice\n');
const agentDir = join(workforceHome, 'agents', 'note-taker');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'note-taker',
extends: 'persona-maker',
skills: [{ id: 'local/voice', source: '../../skills/voice.md', description: 'voice' }]
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
assert.equal(
loaded.byId.get('note-taker')?.skills[0]?.source,
join(workforceHome, 'skills', 'voice.md')
);
});
});

test('a repo agent outranks a personal agent of the same id', () => {
withAgentLayer(({ cwd, home, homeDir, agentsDir }) => {
const userAgents = join(home, '.agentworkforce', 'workforce', 'agents');
mkdirSync(join(userAgents, 'note-taker'), { recursive: true });
writeJson(join(userAgents, 'note-taker', 'persona.json'), {
id: 'note-taker',
extends: 'persona-maker',
env: { SCOPE: 'personal', KEPT: 'yes' }
});
mkdirSync(join(agentsDir, 'note-taker'), { recursive: true });
writeJson(join(agentsDir, 'note-taker', 'persona.json'), {
id: 'note-taker',
env: { SCOPE: 'repo' }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
assert.equal(loaded.sources.get('note-taker'), 'cwd:agents');
const spec = loaded.byId.get('note-taker');
assert.equal(spec?.env?.SCOPE, 'repo');
assert.equal(spec?.env?.KEPT, 'yes');
});
});

test('user:agents displays as personal:agents, following user -> personal', () => {
assert.equal(formatPersonaSourceLabel('user:agents'), 'personal:agents');
assert.equal(formatPersonaSourceLabel('cwd:agents'), 'cwd:agents');
});

test('a missing personal agents dir is not an error', () => {
withLayers(({ cwd, homeDir }) => {
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
});
});
2 changes: 1 addition & 1 deletion packages/persona-registry/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@

Programmatic resolution for AgentWorkforce personas. It owns the same source
cascade used by the CLI: cwd personas, cwd agents, configured directories
(including the personal directory), then the built-in catalog.
(including the personal directory), personal agents, then the built-in catalog.

```ts
import { resolvePersonaReference } from '@agentworkforce/persona-registry';
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
16 changes: 14 additions & 2 deletions packages/cli/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -379,7 +379,9 @@ agentworkforce sources remove <dir|config-position>

Two fixed project sources always lead the cascade:
`<cwd>/.agentworkforce/workforce/personas/*.json`, then
`<cwd>/.agentworkforce/workforce/agents/<name>/persona.json`.
`<cwd>/.agentworkforce/workforce/agents/<name>/persona.json`. A third fixed
source, `~/.agentworkforce/workforce/agents/<name>/persona.json`, carries
personal agents and follows the personal personas dir wherever it ranks.

After that, the CLI reads an ordered list of configurable persona directories
from `~/.agentworkforce/workforce/config.json`. If no config exists, the list
Expand DownExpand Up@@ -477,13 +479,23 @@ wins):
2. `<cwd>/.agentworkforce/workforce/agents/<name>/persona.json` — **cwd:agents**
3. Configurable persona source dirs, in order. Default:
`~/.agentworkforce/workforce/personas/*.json` — **user**
4. Internal built-in system personas in `/personas/` — **library**
4. `~/.agentworkforce/workforce/agents/<name>/persona.json` — **user:agents**,
the personal mirror of `cwd:agents`. It rides directly behind the personal
personas dir, so moving that dir in the cascade moves both. The tables
printed by `list` and `sources list` show it as **personal:agents**,
following `user` → `personal`; `user:agents` is the value `--json` emits.
5. Internal built-in system personas in `/personas/` — **library**
Comment thread
cubic-dev-ai[bot] marked this conversation as resolved.

Local files are **partial overlays**: only the fields you set replace the
inherited value. Everything else cascades through from below.

### Agents that ship their own handler

The same directory layout works in a repo (`cwd:agents`) and in your personal
config (`user:agents`), so an agent you want everywhere lives in
`~/.agentworkforce/workforce/agents/<name>/` and a repo's own agents live in its
working tree. A repo agent outranks a personal one of the same id.

An agent with code of its own keeps persona, handler, tests, and README in one
directory:

Expand Down
280 changes: 279 additions & 1 deletion packages/cli/src/local-personas.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import test from 'node:test';
import assert from 'node:assert/strict';
import { mkdtempSync, mkdirSync, rmSync, writeFileSync } from 'node:fs';
import { mkdtempSync, mkdirSync, rmSync, utimesSync, writeFileSync } from 'node:fs';
import { tmpdir } from 'node:os';
import { join } from 'node:path';

Expand DownExpand Up@@ -1034,3 +1034,281 @@ test('a missing agents/ directory is not an error', () => {
assert.deepEqual(loaded.warnings, []);
});
});

// --- handler agents ---------------------------------------------------------
// An agent driven by its `onEvent` entry has no interactive launch to
// configure, so harness/model/systemPrompt are optional. Requiring them kept
// exactly these agents out of the cascade the agents/ dir was added for.

test('a handler persona loads without interactive fields', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Weekly digest handler.',
cloud: true,
onEvent: './agent.ts',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
const spec = loaded.byId.get('digest');
assert.ok(spec);
assert.equal(spec.onEvent, './agent.ts');
assert.equal(spec.cloud, true);
assert.equal(spec.harness, undefined);
assert.equal(spec.model, undefined);
assert.equal(spec.systemPrompt, undefined);
});
});

test('a standalone persona with no handler still requires harness', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'interactive');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'interactive',
intent: 'documentation',
description: 'No handler, so an operator launches it.',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.equal(loaded.byId.has('interactive'), false);
assert.match(loaded.warnings[0] ?? '', /harness is required for standalone personas/);
});
});

test('an overlay tweaking env keeps the handler entry it inherits', () => {
withAgentLayer(({ cwd, homeDir, pwdDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Weekly digest handler.',
cloud: true,
onEvent: './agent.ts',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
writeJson(join(pwdDir, 'digest.json'), { id: 'digest', env: { TONE: 'terse' } });

const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
const spec = loaded.byId.get('digest');
assert.equal(spec?.onEvent, './agent.ts');
assert.equal(spec?.cloud, true);
assert.equal(spec?.env?.TONE, 'terse');
});
});

test('onEvent may not escape the agent directory', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Escapes its directory.',
onEvent: '../../../elsewhere/agent.ts',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.equal(loaded.byId.has('digest'), false);
assert.match(loaded.warnings[0] ?? '', /onEvent must not contain "\.\." segments/);
});
});

test('a padded onEvent is normalized before it is stored', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Padded but legal handler path.',
onEvent: ' ./agent.ts',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
// Stored untrimmed this resolves against a directory named " .".
assert.equal(loaded.byId.get('digest')?.onEvent, './agent.ts');
});
});

test('onEvent must point at a handler source file', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Points at prose, not a handler.',
onEvent: 'README.md',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
// Without the extension rule this would read as a handler and skip the
// interactive fields it never declared.
assert.equal(loaded.byId.has('digest'), false);
assert.match(loaded.warnings[0] ?? '', /must point at a \.ts/);
});
});

test('a padded onEvent cannot smuggle a .. segment past the guard', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Escapes once trimmed.',
onEvent: ' ../outside/agent.ts ',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.equal(loaded.byId.has('digest'), false);
// Trimmed before validation, so the traversal guard sees the real path.
assert.match(loaded.warnings[0] ?? '', /onEvent must not contain "\.\." segments/);
});
});

test('a persona.json older than its authoring source warns but still loads', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'proposal-agent');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'proposal-agent',
extends: 'persona-maker',
env: { COMPILED: 'stale' }
});
writeFileSync(join(agentDir, 'persona.ts'), 'export default {}\n');
// Backdate the artifact rather than sleeping — same relation, no wall clock.
const past = new Date(Date.now() - 60_000);
utimesSync(join(agentDir, 'persona.json'), past, past);

const loaded = loadLocalPersonas({ cwd, homeDir });
assert.equal(loaded.warnings.length, 1);
assert.match(loaded.warnings[0] ?? '', /persona\.json is older than persona\.ts/);
assert.match(loaded.warnings[0] ?? '', /agentworkforce persona compile/);
// Still served: a forgotten compile must not read as a missing persona.
assert.equal(loaded.byId.get('proposal-agent')?.env?.COMPILED, 'stale');
});
});

test('a persona.json newer than its authoring source is silent', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'proposal-agent');
mkdirSync(agentDir, { recursive: true });
writeFileSync(join(agentDir, 'persona.ts'), 'export default {}\n');
writeJson(join(agentDir, 'persona.json'), {
id: 'proposal-agent',
extends: 'persona-maker'
});
const past = new Date(Date.now() - 60_000);
utimesSync(join(agentDir, 'persona.ts'), past, past);

const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
assert.ok(loaded.byId.has('proposal-agent'));
});
});

test('staleness is measured against the newest authoring file, not the first', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'proposal-agent');
mkdirSync(agentDir, { recursive: true });
// An abandoned persona.ts predates the artifact; the live persona.js is
// newer. Measuring against the .ts alone would call this fresh.
writeFileSync(join(agentDir, 'persona.ts'), 'export default {}\n');
writeJson(join(agentDir, 'persona.json'), { id: 'proposal-agent', extends: 'persona-maker' });
writeFileSync(join(agentDir, 'persona.js'), 'export default {}\n');

const old = new Date(Date.now() - 120_000);
utimesSync(join(agentDir, 'persona.ts'), old, old);
const mid = new Date(Date.now() - 60_000);
utimesSync(join(agentDir, 'persona.json'), mid, mid);

const loaded = loadLocalPersonas({ cwd, homeDir });
assert.equal(loaded.warnings.length, 1);
assert.match(loaded.warnings[0] ?? '', /persona\.json is older than persona\.js/);
});
});

// --- user:agents layer ------------------------------------------------------
// The personal mirror of cwd:agents — an agent-with-handler a user keeps
// across every repo, in the `agents/` sibling of their personal personas dir.

test('the personal agents dir loads as user:agents', () => {
withLayers(({ cwd, home, homeDir }) => {
const userAgents = join(home, '.agentworkforce', 'workforce', 'agents');
mkdirSync(join(userAgents, 'note-taker'), { recursive: true });
writeJson(join(userAgents, 'note-taker', 'persona.json'), {
id: 'note-taker',
extends: 'persona-maker',
env: { SCOPE: 'personal' }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
assert.equal(loaded.sources.get('note-taker'), 'user:agents');
assert.equal(loaded.byId.get('note-taker')?.env?.SCOPE, 'personal');
});
});

test('a personal agent resolves its skills against its own directory', () => {
withLayers(({ cwd, home, homeDir }) => {
const workforceHome = join(home, '.agentworkforce', 'workforce');
mkdirSync(join(workforceHome, 'skills'), { recursive: true });
writeFileSync(join(workforceHome, 'skills', 'voice.md'), '# voice\n');
const agentDir = join(workforceHome, 'agents', 'note-taker');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'note-taker',
extends: 'persona-maker',
skills: [{ id: 'local/voice', source: '../../skills/voice.md', description: 'voice' }]
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
assert.equal(
loaded.byId.get('note-taker')?.skills[0]?.source,
join(workforceHome, 'skills', 'voice.md')
);
});
});

test('a repo agent outranks a personal agent of the same id', () => {
withAgentLayer(({ cwd, home, homeDir, agentsDir }) => {
const userAgents = join(home, '.agentworkforce', 'workforce', 'agents');
mkdirSync(join(userAgents, 'note-taker'), { recursive: true });
writeJson(join(userAgents, 'note-taker', 'persona.json'), {
id: 'note-taker',
extends: 'persona-maker',
env: { SCOPE: 'personal', KEPT: 'yes' }
});
mkdirSync(join(agentsDir, 'note-taker'), { recursive: true });
writeJson(join(agentsDir, 'note-taker', 'persona.json'), {
id: 'note-taker',
env: { SCOPE: 'repo' }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
assert.equal(loaded.sources.get('note-taker'), 'cwd:agents');
const spec = loaded.byId.get('note-taker');
assert.equal(spec?.env?.SCOPE, 'repo');
assert.equal(spec?.env?.KEPT, 'yes');
});
});

test('user:agents displays as personal:agents, following user -> personal', () => {
assert.equal(formatPersonaSourceLabel('user:agents'), 'personal:agents');
assert.equal(formatPersonaSourceLabel('cwd:agents'), 'cwd:agents');
});

test('a missing personal agents dir is not an error', () => {
withLayers(({ cwd, homeDir }) => {
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
});
});
2 changes: 1 addition & 1 deletion packages/persona-registry/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@

Programmatic resolution for AgentWorkforce personas. It owns the same source
cascade used by the CLI: cwd personas, cwd agents, configured directories
(including the personal directory), then the built-in catalog.
(including the personal directory), personal agents, then the built-in catalog.

```ts
import { resolvePersonaReference } from '@agentworkforce/persona-registry';
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
16 changes: 14 additions & 2 deletions packages/cli/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -379,7 +379,9 @@ agentworkforce sources remove <dir|config-position>

Two fixed project sources always lead the cascade:
`<cwd>/.agentworkforce/workforce/personas/*.json`, then
`<cwd>/.agentworkforce/workforce/agents/<name>/persona.json`.
`<cwd>/.agentworkforce/workforce/agents/<name>/persona.json`. A third fixed
source, `~/.agentworkforce/workforce/agents/<name>/persona.json`, carries
personal agents and follows the personal personas dir wherever it ranks.

After that, the CLI reads an ordered list of configurable persona directories
from `~/.agentworkforce/workforce/config.json`. If no config exists, the list
Expand DownExpand Up@@ -477,13 +479,23 @@ wins):
2. `<cwd>/.agentworkforce/workforce/agents/<name>/persona.json` — **cwd:agents**
3. Configurable persona source dirs, in order. Default:
`~/.agentworkforce/workforce/personas/*.json` — **user**
4. Internal built-in system personas in `/personas/` — **library**
4. `~/.agentworkforce/workforce/agents/<name>/persona.json` — **user:agents**,
the personal mirror of `cwd:agents`. It rides directly behind the personal
personas dir, so moving that dir in the cascade moves both. The tables
printed by `list` and `sources list` show it as **personal:agents**,
following `user` → `personal`; `user:agents` is the value `--json` emits.
5. Internal built-in system personas in `/personas/` — **library**
Comment thread
cubic-dev-ai[bot] marked this conversation as resolved.

Local files are **partial overlays**: only the fields you set replace the
inherited value. Everything else cascades through from below.

### Agents that ship their own handler

The same directory layout works in a repo (`cwd:agents`) and in your personal
config (`user:agents`), so an agent you want everywhere lives in
`~/.agentworkforce/workforce/agents/<name>/` and a repo's own agents live in its
working tree. A repo agent outranks a personal one of the same id.

An agent with code of its own keeps persona, handler, tests, and README in one
directory:

Expand Down
280 changes: 279 additions & 1 deletion packages/cli/src/local-personas.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import test from 'node:test';
import assert from 'node:assert/strict';
import { mkdtempSync, mkdirSync, rmSync, writeFileSync } from 'node:fs';
import { mkdtempSync, mkdirSync, rmSync, utimesSync, writeFileSync } from 'node:fs';
import { tmpdir } from 'node:os';
import { join } from 'node:path';

Expand DownExpand Up@@ -1034,3 +1034,281 @@ test('a missing agents/ directory is not an error', () => {
assert.deepEqual(loaded.warnings, []);
});
});

// --- handler agents ---------------------------------------------------------
// An agent driven by its `onEvent` entry has no interactive launch to
// configure, so harness/model/systemPrompt are optional. Requiring them kept
// exactly these agents out of the cascade the agents/ dir was added for.

test('a handler persona loads without interactive fields', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Weekly digest handler.',
cloud: true,
onEvent: './agent.ts',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
const spec = loaded.byId.get('digest');
assert.ok(spec);
assert.equal(spec.onEvent, './agent.ts');
assert.equal(spec.cloud, true);
assert.equal(spec.harness, undefined);
assert.equal(spec.model, undefined);
assert.equal(spec.systemPrompt, undefined);
});
});

test('a standalone persona with no handler still requires harness', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'interactive');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'interactive',
intent: 'documentation',
description: 'No handler, so an operator launches it.',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.equal(loaded.byId.has('interactive'), false);
assert.match(loaded.warnings[0] ?? '', /harness is required for standalone personas/);
});
});

test('an overlay tweaking env keeps the handler entry it inherits', () => {
withAgentLayer(({ cwd, homeDir, pwdDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Weekly digest handler.',
cloud: true,
onEvent: './agent.ts',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
writeJson(join(pwdDir, 'digest.json'), { id: 'digest', env: { TONE: 'terse' } });

const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
const spec = loaded.byId.get('digest');
assert.equal(spec?.onEvent, './agent.ts');
assert.equal(spec?.cloud, true);
assert.equal(spec?.env?.TONE, 'terse');
});
});

test('onEvent may not escape the agent directory', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Escapes its directory.',
onEvent: '../../../elsewhere/agent.ts',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.equal(loaded.byId.has('digest'), false);
assert.match(loaded.warnings[0] ?? '', /onEvent must not contain "\.\." segments/);
});
});

test('a padded onEvent is normalized before it is stored', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Padded but legal handler path.',
onEvent: ' ./agent.ts',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
// Stored untrimmed this resolves against a directory named " .".
assert.equal(loaded.byId.get('digest')?.onEvent, './agent.ts');
});
});

test('onEvent must point at a handler source file', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Points at prose, not a handler.',
onEvent: 'README.md',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
// Without the extension rule this would read as a handler and skip the
// interactive fields it never declared.
assert.equal(loaded.byId.has('digest'), false);
assert.match(loaded.warnings[0] ?? '', /must point at a \.ts/);
});
});

test('a padded onEvent cannot smuggle a .. segment past the guard', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Escapes once trimmed.',
onEvent: ' ../outside/agent.ts ',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.equal(loaded.byId.has('digest'), false);
// Trimmed before validation, so the traversal guard sees the real path.
assert.match(loaded.warnings[0] ?? '', /onEvent must not contain "\.\." segments/);
});
});

test('a persona.json older than its authoring source warns but still loads', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'proposal-agent');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'proposal-agent',
extends: 'persona-maker',
env: { COMPILED: 'stale' }
});
writeFileSync(join(agentDir, 'persona.ts'), 'export default {}\n');
// Backdate the artifact rather than sleeping — same relation, no wall clock.
const past = new Date(Date.now() - 60_000);
utimesSync(join(agentDir, 'persona.json'), past, past);

const loaded = loadLocalPersonas({ cwd, homeDir });
assert.equal(loaded.warnings.length, 1);
assert.match(loaded.warnings[0] ?? '', /persona\.json is older than persona\.ts/);
assert.match(loaded.warnings[0] ?? '', /agentworkforce persona compile/);
// Still served: a forgotten compile must not read as a missing persona.
assert.equal(loaded.byId.get('proposal-agent')?.env?.COMPILED, 'stale');
});
});

test('a persona.json newer than its authoring source is silent', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'proposal-agent');
mkdirSync(agentDir, { recursive: true });
writeFileSync(join(agentDir, 'persona.ts'), 'export default {}\n');
writeJson(join(agentDir, 'persona.json'), {
id: 'proposal-agent',
extends: 'persona-maker'
});
const past = new Date(Date.now() - 60_000);
utimesSync(join(agentDir, 'persona.ts'), past, past);

const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
assert.ok(loaded.byId.has('proposal-agent'));
});
});

test('staleness is measured against the newest authoring file, not the first', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'proposal-agent');
mkdirSync(agentDir, { recursive: true });
// An abandoned persona.ts predates the artifact; the live persona.js is
// newer. Measuring against the .ts alone would call this fresh.
writeFileSync(join(agentDir, 'persona.ts'), 'export default {}\n');
writeJson(join(agentDir, 'persona.json'), { id: 'proposal-agent', extends: 'persona-maker' });
writeFileSync(join(agentDir, 'persona.js'), 'export default {}\n');

const old = new Date(Date.now() - 120_000);
utimesSync(join(agentDir, 'persona.ts'), old, old);
const mid = new Date(Date.now() - 60_000);
utimesSync(join(agentDir, 'persona.json'), mid, mid);

const loaded = loadLocalPersonas({ cwd, homeDir });
assert.equal(loaded.warnings.length, 1);
assert.match(loaded.warnings[0] ?? '', /persona\.json is older than persona\.js/);
});
});

// --- user:agents layer ------------------------------------------------------
// The personal mirror of cwd:agents — an agent-with-handler a user keeps
// across every repo, in the `agents/` sibling of their personal personas dir.

test('the personal agents dir loads as user:agents', () => {
withLayers(({ cwd, home, homeDir }) => {
const userAgents = join(home, '.agentworkforce', 'workforce', 'agents');
mkdirSync(join(userAgents, 'note-taker'), { recursive: true });
writeJson(join(userAgents, 'note-taker', 'persona.json'), {
id: 'note-taker',
extends: 'persona-maker',
env: { SCOPE: 'personal' }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
assert.equal(loaded.sources.get('note-taker'), 'user:agents');
assert.equal(loaded.byId.get('note-taker')?.env?.SCOPE, 'personal');
});
});

test('a personal agent resolves its skills against its own directory', () => {
withLayers(({ cwd, home, homeDir }) => {
const workforceHome = join(home, '.agentworkforce', 'workforce');
mkdirSync(join(workforceHome, 'skills'), { recursive: true });
writeFileSync(join(workforceHome, 'skills', 'voice.md'), '# voice\n');
const agentDir = join(workforceHome, 'agents', 'note-taker');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'note-taker',
extends: 'persona-maker',
skills: [{ id: 'local/voice', source: '../../skills/voice.md', description: 'voice' }]
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
assert.equal(
loaded.byId.get('note-taker')?.skills[0]?.source,
join(workforceHome, 'skills', 'voice.md')
);
});
});

test('a repo agent outranks a personal agent of the same id', () => {
withAgentLayer(({ cwd, home, homeDir, agentsDir }) => {
const userAgents = join(home, '.agentworkforce', 'workforce', 'agents');
mkdirSync(join(userAgents, 'note-taker'), { recursive: true });
writeJson(join(userAgents, 'note-taker', 'persona.json'), {
id: 'note-taker',
extends: 'persona-maker',
env: { SCOPE: 'personal', KEPT: 'yes' }
});
mkdirSync(join(agentsDir, 'note-taker'), { recursive: true });
writeJson(join(agentsDir, 'note-taker', 'persona.json'), {
id: 'note-taker',
env: { SCOPE: 'repo' }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
assert.equal(loaded.sources.get('note-taker'), 'cwd:agents');
const spec = loaded.byId.get('note-taker');
assert.equal(spec?.env?.SCOPE, 'repo');
assert.equal(spec?.env?.KEPT, 'yes');
});
});

test('user:agents displays as personal:agents, following user -> personal', () => {
assert.equal(formatPersonaSourceLabel('user:agents'), 'personal:agents');
assert.equal(formatPersonaSourceLabel('cwd:agents'), 'cwd:agents');
});

test('a missing personal agents dir is not an error', () => {
withLayers(({ cwd, homeDir }) => {
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
});
});
2 changes: 1 addition & 1 deletion packages/persona-registry/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@

Programmatic resolution for AgentWorkforce personas. It owns the same source
cascade used by the CLI: cwd personas, cwd agents, configured directories
(including the personal directory), then the built-in catalog.
(including the personal directory), personal agents, then the built-in catalog.

```ts
import { resolvePersonaReference } from '@agentworkforce/persona-registry';
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
16 changes: 14 additions & 2 deletions packages/cli/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -379,7 +379,9 @@ agentworkforce sources remove <dir|config-position>

Two fixed project sources always lead the cascade:
`<cwd>/.agentworkforce/workforce/personas/*.json`, then
`<cwd>/.agentworkforce/workforce/agents/<name>/persona.json`.
`<cwd>/.agentworkforce/workforce/agents/<name>/persona.json`. A third fixed
source, `~/.agentworkforce/workforce/agents/<name>/persona.json`, carries
personal agents and follows the personal personas dir wherever it ranks.

After that, the CLI reads an ordered list of configurable persona directories
from `~/.agentworkforce/workforce/config.json`. If no config exists, the list
Expand DownExpand Up@@ -477,13 +479,23 @@ wins):
2. `<cwd>/.agentworkforce/workforce/agents/<name>/persona.json` — **cwd:agents**
3. Configurable persona source dirs, in order. Default:
`~/.agentworkforce/workforce/personas/*.json` — **user**
4. Internal built-in system personas in `/personas/` — **library**
4. `~/.agentworkforce/workforce/agents/<name>/persona.json` — **user:agents**,
the personal mirror of `cwd:agents`. It rides directly behind the personal
personas dir, so moving that dir in the cascade moves both. The tables
printed by `list` and `sources list` show it as **personal:agents**,
following `user` → `personal`; `user:agents` is the value `--json` emits.
5. Internal built-in system personas in `/personas/` — **library**
Comment thread
cubic-dev-ai[bot] marked this conversation as resolved.

Local files are **partial overlays**: only the fields you set replace the
inherited value. Everything else cascades through from below.

### Agents that ship their own handler

The same directory layout works in a repo (`cwd:agents`) and in your personal
config (`user:agents`), so an agent you want everywhere lives in
`~/.agentworkforce/workforce/agents/<name>/` and a repo's own agents live in its
working tree. A repo agent outranks a personal one of the same id.

An agent with code of its own keeps persona, handler, tests, and README in one
directory:

Expand Down
280 changes: 279 additions & 1 deletion packages/cli/src/local-personas.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import test from 'node:test';
import assert from 'node:assert/strict';
import { mkdtempSync, mkdirSync, rmSync, writeFileSync } from 'node:fs';
import { mkdtempSync, mkdirSync, rmSync, utimesSync, writeFileSync } from 'node:fs';
import { tmpdir } from 'node:os';
import { join } from 'node:path';

Expand DownExpand Up@@ -1034,3 +1034,281 @@ test('a missing agents/ directory is not an error', () => {
assert.deepEqual(loaded.warnings, []);
});
});

// --- handler agents ---------------------------------------------------------
// An agent driven by its `onEvent` entry has no interactive launch to
// configure, so harness/model/systemPrompt are optional. Requiring them kept
// exactly these agents out of the cascade the agents/ dir was added for.

test('a handler persona loads without interactive fields', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Weekly digest handler.',
cloud: true,
onEvent: './agent.ts',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
const spec = loaded.byId.get('digest');
assert.ok(spec);
assert.equal(spec.onEvent, './agent.ts');
assert.equal(spec.cloud, true);
assert.equal(spec.harness, undefined);
assert.equal(spec.model, undefined);
assert.equal(spec.systemPrompt, undefined);
});
});

test('a standalone persona with no handler still requires harness', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'interactive');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'interactive',
intent: 'documentation',
description: 'No handler, so an operator launches it.',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.equal(loaded.byId.has('interactive'), false);
assert.match(loaded.warnings[0] ?? '', /harness is required for standalone personas/);
});
});

test('an overlay tweaking env keeps the handler entry it inherits', () => {
withAgentLayer(({ cwd, homeDir, pwdDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Weekly digest handler.',
cloud: true,
onEvent: './agent.ts',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
writeJson(join(pwdDir, 'digest.json'), { id: 'digest', env: { TONE: 'terse' } });

const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
const spec = loaded.byId.get('digest');
assert.equal(spec?.onEvent, './agent.ts');
assert.equal(spec?.cloud, true);
assert.equal(spec?.env?.TONE, 'terse');
});
});

test('onEvent may not escape the agent directory', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Escapes its directory.',
onEvent: '../../../elsewhere/agent.ts',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.equal(loaded.byId.has('digest'), false);
assert.match(loaded.warnings[0] ?? '', /onEvent must not contain "\.\." segments/);
});
});

test('a padded onEvent is normalized before it is stored', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Padded but legal handler path.',
onEvent: ' ./agent.ts',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
// Stored untrimmed this resolves against a directory named " .".
assert.equal(loaded.byId.get('digest')?.onEvent, './agent.ts');
});
});

test('onEvent must point at a handler source file', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Points at prose, not a handler.',
onEvent: 'README.md',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
// Without the extension rule this would read as a handler and skip the
// interactive fields it never declared.
assert.equal(loaded.byId.has('digest'), false);
assert.match(loaded.warnings[0] ?? '', /must point at a \.ts/);
});
});

test('a padded onEvent cannot smuggle a .. segment past the guard', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Escapes once trimmed.',
onEvent: ' ../outside/agent.ts ',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.equal(loaded.byId.has('digest'), false);
// Trimmed before validation, so the traversal guard sees the real path.
assert.match(loaded.warnings[0] ?? '', /onEvent must not contain "\.\." segments/);
});
});

test('a persona.json older than its authoring source warns but still loads', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'proposal-agent');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'proposal-agent',
extends: 'persona-maker',
env: { COMPILED: 'stale' }
});
writeFileSync(join(agentDir, 'persona.ts'), 'export default {}\n');
// Backdate the artifact rather than sleeping — same relation, no wall clock.
const past = new Date(Date.now() - 60_000);
utimesSync(join(agentDir, 'persona.json'), past, past);

const loaded = loadLocalPersonas({ cwd, homeDir });
assert.equal(loaded.warnings.length, 1);
assert.match(loaded.warnings[0] ?? '', /persona\.json is older than persona\.ts/);
assert.match(loaded.warnings[0] ?? '', /agentworkforce persona compile/);
// Still served: a forgotten compile must not read as a missing persona.
assert.equal(loaded.byId.get('proposal-agent')?.env?.COMPILED, 'stale');
});
});

test('a persona.json newer than its authoring source is silent', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'proposal-agent');
mkdirSync(agentDir, { recursive: true });
writeFileSync(join(agentDir, 'persona.ts'), 'export default {}\n');
writeJson(join(agentDir, 'persona.json'), {
id: 'proposal-agent',
extends: 'persona-maker'
});
const past = new Date(Date.now() - 60_000);
utimesSync(join(agentDir, 'persona.ts'), past, past);

const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
assert.ok(loaded.byId.has('proposal-agent'));
});
});

test('staleness is measured against the newest authoring file, not the first', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'proposal-agent');
mkdirSync(agentDir, { recursive: true });
// An abandoned persona.ts predates the artifact; the live persona.js is
// newer. Measuring against the .ts alone would call this fresh.
writeFileSync(join(agentDir, 'persona.ts'), 'export default {}\n');
writeJson(join(agentDir, 'persona.json'), { id: 'proposal-agent', extends: 'persona-maker' });
writeFileSync(join(agentDir, 'persona.js'), 'export default {}\n');

const old = new Date(Date.now() - 120_000);
utimesSync(join(agentDir, 'persona.ts'), old, old);
const mid = new Date(Date.now() - 60_000);
utimesSync(join(agentDir, 'persona.json'), mid, mid);

const loaded = loadLocalPersonas({ cwd, homeDir });
assert.equal(loaded.warnings.length, 1);
assert.match(loaded.warnings[0] ?? '', /persona\.json is older than persona\.js/);
});
});

// --- user:agents layer ------------------------------------------------------
// The personal mirror of cwd:agents — an agent-with-handler a user keeps
// across every repo, in the `agents/` sibling of their personal personas dir.

test('the personal agents dir loads as user:agents', () => {
withLayers(({ cwd, home, homeDir }) => {
const userAgents = join(home, '.agentworkforce', 'workforce', 'agents');
mkdirSync(join(userAgents, 'note-taker'), { recursive: true });
writeJson(join(userAgents, 'note-taker', 'persona.json'), {
id: 'note-taker',
extends: 'persona-maker',
env: { SCOPE: 'personal' }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
assert.equal(loaded.sources.get('note-taker'), 'user:agents');
assert.equal(loaded.byId.get('note-taker')?.env?.SCOPE, 'personal');
});
});

test('a personal agent resolves its skills against its own directory', () => {
withLayers(({ cwd, home, homeDir }) => {
const workforceHome = join(home, '.agentworkforce', 'workforce');
mkdirSync(join(workforceHome, 'skills'), { recursive: true });
writeFileSync(join(workforceHome, 'skills', 'voice.md'), '# voice\n');
const agentDir = join(workforceHome, 'agents', 'note-taker');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'note-taker',
extends: 'persona-maker',
skills: [{ id: 'local/voice', source: '../../skills/voice.md', description: 'voice' }]
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
assert.equal(
loaded.byId.get('note-taker')?.skills[0]?.source,
join(workforceHome, 'skills', 'voice.md')
);
});
});

test('a repo agent outranks a personal agent of the same id', () => {
withAgentLayer(({ cwd, home, homeDir, agentsDir }) => {
const userAgents = join(home, '.agentworkforce', 'workforce', 'agents');
mkdirSync(join(userAgents, 'note-taker'), { recursive: true });
writeJson(join(userAgents, 'note-taker', 'persona.json'), {
id: 'note-taker',
extends: 'persona-maker',
env: { SCOPE: 'personal', KEPT: 'yes' }
});
mkdirSync(join(agentsDir, 'note-taker'), { recursive: true });
writeJson(join(agentsDir, 'note-taker', 'persona.json'), {
id: 'note-taker',
env: { SCOPE: 'repo' }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
assert.equal(loaded.sources.get('note-taker'), 'cwd:agents');
const spec = loaded.byId.get('note-taker');
assert.equal(spec?.env?.SCOPE, 'repo');
assert.equal(spec?.env?.KEPT, 'yes');
});
});

test('user:agents displays as personal:agents, following user -> personal', () => {
assert.equal(formatPersonaSourceLabel('user:agents'), 'personal:agents');
assert.equal(formatPersonaSourceLabel('cwd:agents'), 'cwd:agents');
});

test('a missing personal agents dir is not an error', () => {
withLayers(({ cwd, homeDir }) => {
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
});
});
2 changes: 1 addition & 1 deletion packages/persona-registry/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@

Programmatic resolution for AgentWorkforce personas. It owns the same source
cascade used by the CLI: cwd personas, cwd agents, configured directories
(including the personal directory), then the built-in catalog.
(including the personal directory), personal agents, then the built-in catalog.

```ts
import { resolvePersonaReference } from '@agentworkforce/persona-registry';
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
16 changes: 14 additions & 2 deletions packages/cli/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -379,7 +379,9 @@ agentworkforce sources remove <dir|config-position>

Two fixed project sources always lead the cascade:
`<cwd>/.agentworkforce/workforce/personas/*.json`, then
`<cwd>/.agentworkforce/workforce/agents/<name>/persona.json`.
`<cwd>/.agentworkforce/workforce/agents/<name>/persona.json`. A third fixed
source, `~/.agentworkforce/workforce/agents/<name>/persona.json`, carries
personal agents and follows the personal personas dir wherever it ranks.

After that, the CLI reads an ordered list of configurable persona directories
from `~/.agentworkforce/workforce/config.json`. If no config exists, the list
Expand DownExpand Up@@ -477,13 +479,23 @@ wins):
2. `<cwd>/.agentworkforce/workforce/agents/<name>/persona.json` — **cwd:agents**
3. Configurable persona source dirs, in order. Default:
`~/.agentworkforce/workforce/personas/*.json` — **user**
4. Internal built-in system personas in `/personas/` — **library**
4. `~/.agentworkforce/workforce/agents/<name>/persona.json` — **user:agents**,
the personal mirror of `cwd:agents`. It rides directly behind the personal
personas dir, so moving that dir in the cascade moves both. The tables
printed by `list` and `sources list` show it as **personal:agents**,
following `user` → `personal`; `user:agents` is the value `--json` emits.
5. Internal built-in system personas in `/personas/` — **library**
Comment thread
cubic-dev-ai[bot] marked this conversation as resolved.

Local files are **partial overlays**: only the fields you set replace the
inherited value. Everything else cascades through from below.

### Agents that ship their own handler

The same directory layout works in a repo (`cwd:agents`) and in your personal
config (`user:agents`), so an agent you want everywhere lives in
`~/.agentworkforce/workforce/agents/<name>/` and a repo's own agents live in its
working tree. A repo agent outranks a personal one of the same id.

An agent with code of its own keeps persona, handler, tests, and README in one
directory:

Expand Down
280 changes: 279 additions & 1 deletion packages/cli/src/local-personas.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import test from 'node:test';
import assert from 'node:assert/strict';
import { mkdtempSync, mkdirSync, rmSync, writeFileSync } from 'node:fs';
import { mkdtempSync, mkdirSync, rmSync, utimesSync, writeFileSync } from 'node:fs';
import { tmpdir } from 'node:os';
import { join } from 'node:path';

Expand DownExpand Up@@ -1034,3 +1034,281 @@ test('a missing agents/ directory is not an error', () => {
assert.deepEqual(loaded.warnings, []);
});
});

// --- handler agents ---------------------------------------------------------
// An agent driven by its `onEvent` entry has no interactive launch to
// configure, so harness/model/systemPrompt are optional. Requiring them kept
// exactly these agents out of the cascade the agents/ dir was added for.

test('a handler persona loads without interactive fields', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Weekly digest handler.',
cloud: true,
onEvent: './agent.ts',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
const spec = loaded.byId.get('digest');
assert.ok(spec);
assert.equal(spec.onEvent, './agent.ts');
assert.equal(spec.cloud, true);
assert.equal(spec.harness, undefined);
assert.equal(spec.model, undefined);
assert.equal(spec.systemPrompt, undefined);
});
});

test('a standalone persona with no handler still requires harness', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'interactive');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'interactive',
intent: 'documentation',
description: 'No handler, so an operator launches it.',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.equal(loaded.byId.has('interactive'), false);
assert.match(loaded.warnings[0] ?? '', /harness is required for standalone personas/);
});
});

test('an overlay tweaking env keeps the handler entry it inherits', () => {
withAgentLayer(({ cwd, homeDir, pwdDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Weekly digest handler.',
cloud: true,
onEvent: './agent.ts',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
writeJson(join(pwdDir, 'digest.json'), { id: 'digest', env: { TONE: 'terse' } });

const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
const spec = loaded.byId.get('digest');
assert.equal(spec?.onEvent, './agent.ts');
assert.equal(spec?.cloud, true);
assert.equal(spec?.env?.TONE, 'terse');
});
});

test('onEvent may not escape the agent directory', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Escapes its directory.',
onEvent: '../../../elsewhere/agent.ts',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.equal(loaded.byId.has('digest'), false);
assert.match(loaded.warnings[0] ?? '', /onEvent must not contain "\.\." segments/);
});
});

test('a padded onEvent is normalized before it is stored', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Padded but legal handler path.',
onEvent: ' ./agent.ts',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
// Stored untrimmed this resolves against a directory named " .".
assert.equal(loaded.byId.get('digest')?.onEvent, './agent.ts');
});
});

test('onEvent must point at a handler source file', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Points at prose, not a handler.',
onEvent: 'README.md',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
// Without the extension rule this would read as a handler and skip the
// interactive fields it never declared.
assert.equal(loaded.byId.has('digest'), false);
assert.match(loaded.warnings[0] ?? '', /must point at a \.ts/);
});
});

test('a padded onEvent cannot smuggle a .. segment past the guard', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'digest');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'digest',
intent: 'documentation',
description: 'Escapes once trimmed.',
onEvent: ' ../outside/agent.ts ',
harnessSettings: { reasoning: 'medium', timeoutSeconds: 600 }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.equal(loaded.byId.has('digest'), false);
// Trimmed before validation, so the traversal guard sees the real path.
assert.match(loaded.warnings[0] ?? '', /onEvent must not contain "\.\." segments/);
});
});

test('a persona.json older than its authoring source warns but still loads', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'proposal-agent');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'proposal-agent',
extends: 'persona-maker',
env: { COMPILED: 'stale' }
});
writeFileSync(join(agentDir, 'persona.ts'), 'export default {}\n');
// Backdate the artifact rather than sleeping — same relation, no wall clock.
const past = new Date(Date.now() - 60_000);
utimesSync(join(agentDir, 'persona.json'), past, past);

const loaded = loadLocalPersonas({ cwd, homeDir });
assert.equal(loaded.warnings.length, 1);
assert.match(loaded.warnings[0] ?? '', /persona\.json is older than persona\.ts/);
assert.match(loaded.warnings[0] ?? '', /agentworkforce persona compile/);
// Still served: a forgotten compile must not read as a missing persona.
assert.equal(loaded.byId.get('proposal-agent')?.env?.COMPILED, 'stale');
});
});

test('a persona.json newer than its authoring source is silent', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'proposal-agent');
mkdirSync(agentDir, { recursive: true });
writeFileSync(join(agentDir, 'persona.ts'), 'export default {}\n');
writeJson(join(agentDir, 'persona.json'), {
id: 'proposal-agent',
extends: 'persona-maker'
});
const past = new Date(Date.now() - 60_000);
utimesSync(join(agentDir, 'persona.ts'), past, past);

const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
assert.ok(loaded.byId.has('proposal-agent'));
});
});

test('staleness is measured against the newest authoring file, not the first', () => {
withAgentLayer(({ cwd, homeDir, agentsDir }) => {
const agentDir = join(agentsDir, 'proposal-agent');
mkdirSync(agentDir, { recursive: true });
// An abandoned persona.ts predates the artifact; the live persona.js is
// newer. Measuring against the .ts alone would call this fresh.
writeFileSync(join(agentDir, 'persona.ts'), 'export default {}\n');
writeJson(join(agentDir, 'persona.json'), { id: 'proposal-agent', extends: 'persona-maker' });
writeFileSync(join(agentDir, 'persona.js'), 'export default {}\n');

const old = new Date(Date.now() - 120_000);
utimesSync(join(agentDir, 'persona.ts'), old, old);
const mid = new Date(Date.now() - 60_000);
utimesSync(join(agentDir, 'persona.json'), mid, mid);

const loaded = loadLocalPersonas({ cwd, homeDir });
assert.equal(loaded.warnings.length, 1);
assert.match(loaded.warnings[0] ?? '', /persona\.json is older than persona\.js/);
});
});

// --- user:agents layer ------------------------------------------------------
// The personal mirror of cwd:agents — an agent-with-handler a user keeps
// across every repo, in the `agents/` sibling of their personal personas dir.

test('the personal agents dir loads as user:agents', () => {
withLayers(({ cwd, home, homeDir }) => {
const userAgents = join(home, '.agentworkforce', 'workforce', 'agents');
mkdirSync(join(userAgents, 'note-taker'), { recursive: true });
writeJson(join(userAgents, 'note-taker', 'persona.json'), {
id: 'note-taker',
extends: 'persona-maker',
env: { SCOPE: 'personal' }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
assert.equal(loaded.sources.get('note-taker'), 'user:agents');
assert.equal(loaded.byId.get('note-taker')?.env?.SCOPE, 'personal');
});
});

test('a personal agent resolves its skills against its own directory', () => {
withLayers(({ cwd, home, homeDir }) => {
const workforceHome = join(home, '.agentworkforce', 'workforce');
mkdirSync(join(workforceHome, 'skills'), { recursive: true });
writeFileSync(join(workforceHome, 'skills', 'voice.md'), '# voice\n');
const agentDir = join(workforceHome, 'agents', 'note-taker');
mkdirSync(agentDir, { recursive: true });
writeJson(join(agentDir, 'persona.json'), {
id: 'note-taker',
extends: 'persona-maker',
skills: [{ id: 'local/voice', source: '../../skills/voice.md', description: 'voice' }]
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
assert.equal(
loaded.byId.get('note-taker')?.skills[0]?.source,
join(workforceHome, 'skills', 'voice.md')
);
});
});

test('a repo agent outranks a personal agent of the same id', () => {
withAgentLayer(({ cwd, home, homeDir, agentsDir }) => {
const userAgents = join(home, '.agentworkforce', 'workforce', 'agents');
mkdirSync(join(userAgents, 'note-taker'), { recursive: true });
writeJson(join(userAgents, 'note-taker', 'persona.json'), {
id: 'note-taker',
extends: 'persona-maker',
env: { SCOPE: 'personal', KEPT: 'yes' }
});
mkdirSync(join(agentsDir, 'note-taker'), { recursive: true });
writeJson(join(agentsDir, 'note-taker', 'persona.json'), {
id: 'note-taker',
env: { SCOPE: 'repo' }
});
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
assert.equal(loaded.sources.get('note-taker'), 'cwd:agents');
const spec = loaded.byId.get('note-taker');
assert.equal(spec?.env?.SCOPE, 'repo');
assert.equal(spec?.env?.KEPT, 'yes');
});
});

test('user:agents displays as personal:agents, following user -> personal', () => {
assert.equal(formatPersonaSourceLabel('user:agents'), 'personal:agents');
assert.equal(formatPersonaSourceLabel('cwd:agents'), 'cwd:agents');
});

test('a missing personal agents dir is not an error', () => {
withLayers(({ cwd, homeDir }) => {
const loaded = loadLocalPersonas({ cwd, homeDir });
assert.deepEqual(loaded.warnings, []);
});
});
2 changes: 1 addition & 1 deletion packages/persona-registry/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@

Programmatic resolution for AgentWorkforce personas. It owns the same source
cascade used by the CLI: cwd personas, cwd agents, configured directories
(including the personal directory), then the built-in catalog.
(including the personal directory), personal agents, then the built-in catalog.

```ts
import { resolvePersonaReference } from '@agentworkforce/persona-registry';
Expand Down
Loading
Loading