Uh oh!
There was an error while loading. Please reload this page.
persona-kit 6/8: delete @agentworkforce/harness-kit from monorepo - #80
Merged
Conversation
harness-kit has been a pure re-export shim over @agentworkforce/persona-kit since #65; the CLI no longer imports it (#67) and workload-router does not depend on it (#68). Remove the package directory and clean up residual references in workflows, READMEs, and inline comments. The npm package stays installable for pinned consumers; deprecation should be set out of band via `npm deprecate` per the issue. Closes#69
Contributor
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR removes the ChangesHarness-kit Package Removal
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related issues
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/publish.yml (1)
692-697: ⚡ Quick winMake
persona-kitexplicit in release-note sort order.
packageOrderomitspersona-kit, so it sorts viaindexOf() === -1side effects. Adding it explicitly makes ordering deterministic and easier to maintain.Proposed change
- const packageOrder = ['workload-router', 'cli', 'agentworkforce'];+ const packageOrder = ['persona-kit', 'workload-router', 'cli', 'agentworkforce'];🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/publish.yml around lines 692 - 697, The release-note sorting uses packageOrder to determine order but omits "persona-kit", causing packageOrder.indexOf(...) to return -1 and produce nondeterministic sort order; update the packageOrder array (the constant named packageOrder used where entries is sorted) to include "persona-kit" in the desired position so the sort callback (packageOrder.indexOf(a.pkg) - packageOrder.indexOf(b.pkg)) yields deterministic ordering for persona-kit.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/workflows/publish.yml:
- Around line 692-697: The release-note sorting uses packageOrder to determine
order but omits "persona-kit", causing packageOrder.indexOf(...) to return -1
and produce nondeterministic sort order; update the packageOrder array (the
constant named packageOrder used where entries is sorted) to include
"persona-kit" in the desired position so the sort callback
(packageOrder.indexOf(a.pkg) - packageOrder.indexOf(b.pkg)) yields deterministic
ordering for persona-kit.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 12873ce1-3b32-432b-9a98-332cc1608725
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (13)
.github/workflows/publish.yml.github/workflows/verify-publish.ymlREADME.mdpackages/cli/src/cli.tspackages/harness-kit/CHANGELOG.mdpackages/harness-kit/README.mdpackages/harness-kit/package.jsonpackages/harness-kit/src/index.tspackages/harness-kit/src/runner.test.tspackages/harness-kit/src/runner.tspackages/harness-kit/tsconfig.jsonpackages/persona-kit/src/interactive-spec.tspackages/workload-router/README.md
💤 Files with no reviewable changes (8)
- .github/workflows/verify-publish.yml
- packages/harness-kit/tsconfig.json
- packages/harness-kit/README.md
- packages/harness-kit/package.json
- packages/harness-kit/src/runner.ts
- packages/harness-kit/src/index.ts
- packages/harness-kit/CHANGELOG.md
- packages/harness-kit/src/runner.test.ts
The array drove release-note sorting via packageOrder.indexOf(); leaving persona-kit out relied on the -1 fallback to sort it first. Spell it out so the order is explicit and stable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#69.
Summary
@agentworkforce/harness-kithas been a pure re-export shim over@agentworkforce/persona-kitsince #65, the CLI no longer imports it (#67), andworkload-routerdoes not depend on it (#68). This PR deletes the package from the monorepo and cleans up residual references.Changes
packages/harness-kit/(entire directory: source, README, CHANGELOG, package.json, tsconfig).pnpm-workspace.yamluses thepackages/*glob so no explicit deregistration is needed; the lockfile has been refreshed viapnpm install..github/workflows/publish.yml: droppedharness-kitfrom the publish order (persona-kit → workload-router → cli → agentworkforce) and from the release-notes ordering array..github/workflows/verify-publish.yml: dropped@agentworkforce/harness-kitfrom the package choices.README.mdnow points atpackages/persona-kitinstead ofharness-kitin the package list, dev-loop instructions, and per-package dev guidance.packages/workload-router/README.mdreferences persona-kit where it previously referenced harness-kit.packages/cli/src/cli.tsandpackages/persona-kit/src/interactive-spec.tsso the bare directory name no longer survives in code comments.The npm package stays installable for pinned consumers;
npm deprecate @agentworkforce/harness-kit ...should be run out of band (it requires publish credentials and is intentionally not part of this PR).Verification
pnpm installrefreshes the lockfile (no remainingharness-kitentry).pnpm -r build✓pnpm -r test✓ (persona-kit, workload-router, cli, agentworkforce all green).grep '@agentworkforce/harness-kit'across the repo (excluding lockfile + node_modules + trajectories) → 0 hits.grep 'harness-kit'outsidenode_modules,pnpm-lock.yaml, and historical CHANGELOGs → 0 hits.Test plan
npm deprecate @agentworkforce/harness-kit "Replaced by @agentworkforce/persona-kit. See https://github.com/AgentWorkforce/workforce/issues/64"from a machine with publish rights (do notnpm unpublish).Generated by Claude Code