Conversation
|
Hi @ubaids12, thanks for opening a pull request. 🙏 This PR was automatically closed because it does not yet meet our contribution requirements:
We ask for this so every change is documented and demonstrably tested before review. How to get it reopened See the Contributing guide and Creating your first PR. If you think this was closed in error, leave a comment and a maintainer will take a look. |
|
ubaids12 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (5)
Disabled knowledge base sources:
📝 SummarySummary by CodeRabbit
WalkthroughThe change adds explicit session pin removal and applies it when sessions are archived or deleted. The session action hook also unpins sessions before these actions. Tests cover pin removal during archiving. ChangesSession pin cleanup
Estimated code review effort: 2 (Simple) | ~10 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What changed?
This change fixes a bug where a session could remain marked as pinned even after it was archived or deleted.
The root cause was that the pinned-session state was stored separately from the archived state and was never explicitly cleared during archive/delete flows. As a result, the UI continued to treat the archived session as pinned.
This fix clears the pin state when a session is archived or deleted so archived sessions no longer appear as pinned and no longer behave as pinned items in the session list.
Why was this change needed?
Users expected archived sessions to be removed from the active pinned state. Previously, archived sessions could still show up as pinned, which was confusing and inconsistent with the expected behavior.
What problem does it solve?
It ensures the pin flag is reset when a session is archived or removed, keeping the pinned state aligned with the actual session lifecycle .
Testing
Verified locally
Not run locally for this change. The repository work was limited to code edits only, without dependency installation or local runtime validation, per the request.
Added or updated tests
Updated the session regression coverage to include the pinned archive/delete flow so this edge case is captured in future test runs.
QA follow-up
Validate that archiving a pinned session removes the pin immediately in the UI.
Validate that deleting a pinned session also clears its pinned state.
Validate pinned sessions still remain pinned when active and not archived.
Validate archive/unarchive behavior in the sidebar and session list views.
Confirm there are no regressions in other session actions such as rename, open, and share link.
Demo
N/A for this change. No local app demo was captured because this branch was updated without running the app locally.
Checklist
Demo shows the real app running this branch (not a mock-up or recreated UI), or is marked N/A
Relevant tests pass locally
Relevant linting and formatting pass locally
I have signed the CLA, or I will sign it when the bot prompts me