feat(frontend): the Files pane on a phone; drop the pdfjs thumbnail - #6938
Merged
ashrafchowdury merged 3 commits intoSep 17, 2026
Merged
Conversation
PDF tiles show the type icon like any other binary; the embedded PDF viewer on open stays. Removes pdfjs-dist, the copy-pdf-worker script and the public/ worker copies + gitignore rules.
…ig pane does Below md the pane was unreachable: the toggle was hidden and every opener latched an open flag nothing rendered. Now sessionPanes gives Files the screen (over chat and config; closing lands back where you were), the tab bar's folder toggle shows at every width, and the header leads with a « close on phones. Tiles go three across with smaller glyphs under md; the tree toggle uses the app's Sidebar glyph.
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (101)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
📘 Docs preview
This comment updates in place on every push. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two follow-ups to the Files pane redesign (#6876):
The Files pane is reachable on a phone. Below
mdthe pane could not be opened: the tab bar's folder toggle wasmax-md:hidden, the files split never mounted, and every opener (a config Files row, a chat file chip, a tool link) still latched the pane's open flag, so tapping a file did nothing visible and left the flag stuck. The pane now takes the screen the way the config pane does — sameresolveSessionPanesrule, extended withfilesOpen/showFiles: Files outranks config and chat on a phone, and closing lands back on whatever was under it (the chat stays mounted, so its scroll and draft survive). The header leads with a«close on phones (closeVariant="back"), tiles go three across with smaller glyphs undermd, and the tree toggle uses the app'sSidebarglyph.The pdfjs thumbnail is gone. PDF tiles show the type icon like any other binary; the embedded viewer on open is unchanged. Removes
pdfjs-dist, thecopy-pdf-workerscript, thedev/buildprefixes in oss/ee/mobile, the trackedmobile/public/pdf.worker.min.mjs(which was failing the prettier CI check) and the gitignore rules.Testing
Verified locally
On
/mat 375×812 in the app: open from the tab bar's folder toggle, from a config Files row, and from a file tile; edit a markdown file full-width; close from the header's«and land back on the chat / the config pane at the same scroll. At desktop width the docked pane is unchanged. PDF opens in the embedded viewer; its tile shows the PDF icon.@agenta/entitiesand@agenta/entity-uibuild; mobiletscclean.Added or updated tests
web/mobile/tests/unit/sessionPanes.test.ts— phone cases for the Files pane (takes the screen, outranks config, config returns on close) and the two-pane case (Files beside config). 9/9 pass.QA follow-up
Phone: markdown editor with the keyboard up; long-press item actions on touch (the context menu is right-click only today).
Demo
Phone (375px): grid, three across,
«leading the headerChecklist