Add conditional app variant check - #814
Merged
aakrem merged 8 commits intoOct 29, 2023
Merged
Conversation
aakrem
suggested changes
Oct 27, 2023
aakrem
left a comment
Contributor
There was a problem hiding this comment.
I think this is again not what we want to test.
A user won't do any request. Let's only test the workflow a user will do.
Or what do you need this for ?
Contributor
Author
|
When the app card is present, follow these steps: When the app card is absent, follow these steps: |
aakrem
suggested changes
Oct 29, 2023
Contributor
|
I see @bekossy thanks for the explanation |
aakrem
approved these changes
Oct 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a simple enhancement to the
createVariantsAndTestsetsCypress command. It includes conditional logic to check for app variants. If they are present, the test clicks thecreate-new-app-button. If not, the test is skipped. This change enhances the test script's adaptability in various scenarios.