Uh oh!
There was an error while loading. Please reload this page.
Add MessageContext message discarding - #15662
Open
autumn-mck wants to merge 1 commit into
Open
Conversation
Allow exception teardown paths to discard pending output messages without asserting that they were sent.
ktf
reviewed
Aug 6, 2026
| voidMessageContext::discard() | ||
| { | ||
| mDidDispatch = false; |
Member
There was a problem hiding this comment.
this will result in noisy comments about which tables were not created. I guess that's the indended behavior?
ktf
commented
Aug 6, 2026
Member
@vkucera I have the impression some checkers are not picking up changes. Could you verify? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.