Skip to content

Add MessageContext message discarding#15662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
autumn-mck wants to merge 1 commit into
base:dev
Choose a base branch
from
+12 −0
Open

Add MessageContext message discarding #15662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Framework/Core/include/Framework/MessageContext.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -466,6 +466,11 @@ class MessageContext
/// discarded.
voidclear();

/// Discard pending output messages without asserting that they were sent. This
/// is intended for exception teardown paths where normal post-processing will
/// not run.
voiddiscard();

FairMQDeviceProxy& proxy()
{
returnmProxy;
Expand Down
7 changes: 7 additions & 0 deletions Framework/Core/src/MessageContext.cxx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -107,6 +107,13 @@ void MessageContext::clear()
mMessages.clear();
}

void MessageContext::discard()
{
mDidDispatch = false;

@ktfktfAug 6, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will result in noisy comments about which tables were not created. I guess that's the indended behavior?

mScheduledMessages.clear();
mMessages.clear();
}

int64_t MessageContext::addToCache(std::unique_ptr<fair::mq::Message>& toCache)
{
auto&& cached = toCache->GetTransport()->CreateMessage();
Expand Down