Uh oh!
There was an error while loading. Please reload this page.
Revert "Create DCAFitter under ./Common" - #10647
Conversation
This reverts commit 52a3ebc.
shahor02
commented
Jan 28, 2023
@ddobrigk actually, since all the tests with your PR were green, probably having it merged does not harm. Will keep this revert PR open, ping me if you want it merged. |
ddobrigk
commented
Jan 28, 2023
Hi @shahor02 , I think you are right. Let's merge this, it is harmless and then I can already start with the modifications to O2Physics. The part where we will need to be more careful is only when we go back to O2 to remove the 'original' DCAFitter. Many thanks! |
shahor02
commented
Jan 28, 2023
@ddobrigk sorry, did not understand: do you want me to merge this (which will revert your merged PR and suppress the Common/DCAFitter) ? |
ddobrigk
commented
Jan 28, 2023
Ah sorry - no, don't merge this, let's leave it as is with the other PR merged and keep the Common/DCAFitter. (Replied on smartphone, I apologize for the imprecision). Thanks! |
Reverts #10644
@ddobrigk Sorry, noticed the request to not merge too late, reverting and merging