Uh oh!
There was an error while loading. Please reload this page.
[WIP] TPC QC: adds Cluster occupancy histograms - #12643
Closed
sbhawani wants to merge 2 commits into
Closed
Conversation
sbhawani
requested review from
davidrohr, shahor02 and wiechula
as code ownersFebruary 1, 2024 16:38
wiechula
requested changes
Feb 5, 2024
| void fillADCValue(int cru, int rowInSector, int padInRow, int timeBin, float adcValue); | ||
| void normalize(); | ||
| void normalize(const float nHBFPerTF = 128); |
Collaborator
There was a problem hiding this comment.
There is a data member for the number of HBFs. So it is not needed twice
Suggested change
| voidnormalize(constfloatnHBFPerTF=128); | |
| voidnormalize(); |
| void normalize(const float nHBFPerTF = 128); | ||
| inline void analyse() { Clusters::normalize(); } | ||
| inline void analyse() { Clusters::normalize(); } // deprecated |
Collaborator
There was a problem hiding this comment.
Might be used in macros, so I would not call it deprecated.
Suggested change
| inlinevoidanalyse() { Clusters::normalize(); }// deprecated | |
| inlinevoidanalyse() { Clusters::normalize(); } |
| CalPad mOccupancy{"Occupancy"}; | ||
| size_t mProcessedTFs{0}; | ||
| bool mIsNormalized{false}; | ||
| float mNHBFperTF{128}; |
Collaborator
There was a problem hiding this comment.
The default now it 32
Suggested change
| floatmNHBFperTF{128}; | |
| floatmNHBFperTF{32}; |
| //______________________________________________________________________________ | ||
| void Clusters::normalize() | ||
| void Clusters::normalize(const float nHBFPerTF) |
Collaborator
There was a problem hiding this comment.
Suggested change
| voidClusters::normalize(constfloat nHBFPerTF) | |
| voidClusters::normalize() |
| mTimeBin /= mNClusters; | ||
| mOccupancy = mNClusters; | ||
| mOccupancy /= float(mProcessedTFs * (o2::constants::lhc::LHCMaxBunches * nHBFPerTF) / float(o2::tpc::ParameterElectronics::TIMEBININBC)); |
Collaborator
There was a problem hiding this comment.
Suggested change
| mOccupancy /= float(mProcessedTFs * (o2::constants::lhc::LHCMaxBunches * nHBFPerTF) / float(o2::tpc::ParameterElectronics::TIMEBININBC)); | |
| mOccupancy /= float(mProcessedTFs * (o2::constants::lhc::LHCMaxBunches * mNHBFPerTF) / float(o2::tpc::ParameterElectronics::TIMEBININBC)); |
| if (isThisNormalized) { | ||
| normalize(); | ||
| normalize(mNHBFperTF); |
Collaborator
There was a problem hiding this comment.
Not needed, use internal member.
Suggested change
| normalize(mNHBFperTF); | |
| normalize(); |
| } | ||
| if (isOtherNormalized) { | ||
| clusters.normalize(); | ||
| clusters.normalize(mNHBFperTF); |
Collaborator
There was a problem hiding this comment.
Suggested change
| clusters.normalize(mNHBFperTF); | |
| clusters.normalize(); |
Contributor
This PR did not have any update in the last 30 days. Is it still needed? Unless further action in will be closed in 5 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.