Skip to content

First version of the hit based CA tracker for ALICE3 IT/OT - #15066

Merged
njacazio merged 2 commits into
AliceO2Group:devfrom
mpuccio:mp-branch-1
Feb 16, 2026
Merged

First version of the hit based CA tracker for ALICE3 IT/OT#15066
njacazio merged 2 commits into
AliceO2Group:devfrom
mpuccio:mp-branch-1

Conversation

@mpuccio

@mpucciompuccio commented Feb 12, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@mpuccio
ITSTracking: change visibility of methods
2d0b9e3
Change TimeFrame prepareClusters method visibility to protected
Add computeTracksMClabels method to Tracker class
@github-actions

github-actionsBot commented Feb 12, 2026

Copy link
Copy Markdown
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@alibuildalibuild mentioned this pull request Feb 12, 2026
Merged
@alibuildalibuild mentioned this pull request Feb 12, 2026
Closed
@mpuccio

mpuccio commented Feb 12, 2026

Copy link
Copy Markdown
ContributorAuthor

Please when/if you merge do not squash

@alibuild

alibuild commented Feb 12, 2026•
edited
Loading

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for 92ededd at 2026-02-13 08:43:

## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:82:41: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:84:42: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:86:39: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:88:41: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:90:52: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:92:48: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:94:48: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:96:49: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:98:48: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:102:43: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:104:39: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:106:47: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:108:58: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:110:57: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:112:54: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:114:58: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:116:44: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:118:57: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:120:59: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:124:44: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:126:58: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:128:48: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:130:51: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:132:49: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:134:60: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:136:52: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:138:48: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:140:53: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:142:50: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:144:53: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:146:53: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:148:53: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:150:54: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:152:45: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:154:51: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/15066-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/TrackerSpec.cxx:188:43: error: statement should be inside braces [readability-braces-around-statements]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

@mpuccio

mpuccio commented Feb 16, 2026

Copy link
Copy Markdown
ContributorAuthor

@fprino : the ITS part is minimal and discussed already with Felix, please have a look
@njacazio : can you have a look and merge if it is fine with you?

njacazio
njacazio reviewed Feb 16, 2026
View reviewed changes

@njacazionjacazio left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks @mpuccio tagging also @fcolamar and @altsybee

@njacazio
njacazio merged commit 3e68768 into AliceO2Group:devFeb 16, 2026
13 of 14 checks passed
@njacazio

njacazio commented Feb 16, 2026

Copy link
Copy Markdown
Collaborator

Indeed I squashed by mistake when merging. @mpuccio shall we revert and reopen?

@mpuccio

mpuccio commented Feb 16, 2026•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@f3sch , can we live with this squashed? The changes in ITS are really minimal

@f3sch

f3sch commented Feb 16, 2026

Copy link
Copy Markdown
Collaborator

@njacazio reverting would create a much bigger mess, so no let's leave it like this. But in the future, we have to be careful if a PR touches production code.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@njacazionjacazionjacazio approved these changes
@fprinofprinofprino approved these changes
@mconcasmconcasAwaiting requested review from mconcasmconcas is a code owner
@mcoquet642mcoquet642Awaiting requested review from mcoquet642mcoquet642 is a code owner
@shahor02shahor02Awaiting requested review from shahor02shahor02 is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mpuccio@alibuild@njacazio@f3sch@fprino