Skip to content

ITS: add back the code for track following - #15456

Merged
shahor02 merged 7 commits into
AliceO2Group:devfrom
mpuccio:track_following
Jun 8, 2026
Merged

ITS: add back the code for track following#15456
shahor02 merged 7 commits into
AliceO2Group:devfrom
mpuccio:track_following

Conversation

@mpuccio

@mpucciompuccio commented May 31, 2026

Copy link
Copy Markdown
Contributor

By default, this is disabled for ITS, but it is required for ALICE3.
This changes the findRoads to avoid the double pass (first count then fill) on CPU, leading to marginal gain on speed while keeping the memory footprint equal (checked on a critical PbPb CTF that Felix gave me)

@alibuildalibuild mentioned this pull request May 31, 2026
Closed
f3sch
f3sch requested changes Jun 1, 2026
View reviewed changes

@f3schf3sch left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, still have to go through the actual meat of the code but maybe this can be a starting point. Most comments are only of cosmetic nature

Comment threadDetectors/ITSMFT/ITS/tracking/include/ITStracking/ROFLookupTables.h Outdated
Comment threadDetectors/ITSMFT/ITS/tracking/include/ITStracking/ROFLookupTables.h Outdated
Comment threadDetectors/ITSMFT/ITS/tracking/include/ITStracking/TrackExtensionCandidate.h Outdated
Comment threadDetectors/ITSMFT/ITS/tracking/include/ITStracking/TrackExtensionCandidate.h Outdated
Comment threadDetectors/ITSMFT/ITS/tracking/include/ITStracking/TrackExtensionCandidate.h Outdated
Comment threadDetectors/ITSMFT/ITS/tracking/include/ITStracking/TrackExtensionCandidate.h Outdated
Comment threadDetectors/ITSMFT/ITS/tracking/include/ITStracking/TrackExtensionCandidate.h Outdated
Comment threadDetectors/ITSMFT/ITS/tracking/include/ITStracking/TrackFollower.h Outdated
Comment threadDetectors/ITSMFT/ITS/tracking/include/ITStracking/TrackFollower.h Outdated
Comment threadDetectors/ITSMFT/ITS/tracking/include/ITStracking/TrackerTraits.h Outdated
f3sch
f3sch requested changes Jun 2, 2026
View reviewed changes

@f3schf3sch left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still have to actually run it but I think this already in very good shape. I attached more (less than last time) nitpicks. Thanks for addressing.

Comment threadDetectors/ITSMFT/ITS/tracking/include/ITStracking/TrackExtensionHypothesis.h Outdated
Comment threadDetectors/ITSMFT/ITS/tracking/include/ITStracking/TrackHelpers.h Outdated
Comment threadDetectors/ITSMFT/ITS/tracking/src/Tracker.cxx Outdated
Comment threadDetectors/ITSMFT/ITS/tracking/GPU/cuda/TrackerTraitsGPU.cxx Outdated
Comment threadDetectors/ITSMFT/ITS/tracking/GPU/cuda/TrackingKernels.cu Outdated
f3sch
f3sch approved these changes Jun 4, 2026
View reviewed changes

@f3schf3sch left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shahor02@fprino to me this looks good now and I am happy that this will be merged.
I tested locally that there are no performance regressions for CPU/GPU (also still deterministic) and indeed it is now ~5% faster. The memory profile looks to be the same as before
image

@mpuccio

mpuccio commented Jun 8, 2026

Copy link
Copy Markdown
ContributorAuthor

Hi @shahor02 , a gentle ping on this

shahor02
shahor02 reviewed Jun 8, 2026
View reviewed changes
Comment threadDataFormats/Detectors/ITSMFT/ITS/include/DataFormatsITS/TrackITS.h
@shahor02
shahor02 merged commit 94d9198 into AliceO2Group:devJun 8, 2026
15 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahor02shahor02shahor02 approved these changes
@f3schf3schf3sch approved these changes
@fprinofprinoAwaiting requested review from fprinofprino is a code owner
@mcoquet642mcoquet642Awaiting requested review from mcoquet642mcoquet642 is a code owner
@mconcasmconcasAwaiting requested review from mconcasmconcas is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mpuccio@shahor02@f3sch