Uh oh!
There was an error while loading. Please reload this page.
Clean and adapt config files for EventaTrack AnalysisQC - #1331
Merged
benedikt-voelkel merged 1 commit intoNov 20, 2023
Conversation
- clean all obsolete Configurables - remove most of Configurables set to default values - switch-on the overwriteAxisRangeForPbPb flag, to rearrange multiplicity axes for Pb-Pb !!! O2Physics PR AliceO2Group/O2Physics#3883 (review) mandatory!!! - enable the processing only for PV contributor tracks
mfaggin
requested review from
benedikt-voelkel, chiarazampolli, gconesab and sawenzel
as code ownersNovember 16, 2023 18:00
mfaggin
commented
Nov 16, 2023
ContributorAuthor
hi @benedikt-voelkel@chiarazampolli , together with @rolavick we changed some configurables in the O2Physics code for the event and track QC on AO2Ds. As mentioned in the PR comment above, the O2Physics PR AliceO2Group/O2Physics#3883 (review) is mandatory before merging this one. In the meanwhile: @rolavick can you please check that the configurations that I have prepared are fine and that I did not overlooked anything? Thank you |
rolavick
commented
Nov 17, 2023
Looking good to me. Thanks! |
mfaggin
commented
Nov 18, 2023
ContributorAuthor
Thank you Roman. @benedikt-voelkel@chiarazampolli it can go ahead then. |
chiarazampolli
commented
Nov 20, 2023
Collaborator
Hello @benedikt-voelkel , |
benedikt-voelkel
approved these changes
Nov 20, 2023
benedikt-voelkel
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, merging!
benedikt-voelkel pushed a commit
to benedikt-voelkel/O2DPG
that referenced
this pull request
Nov 28, 2023
…#1331) - clean all obsolete Configurables - remove most of Configurables set to default values - switch-on the overwriteAxisRangeForPbPb flag, to rearrange multiplicity axes for Pb-Pb !!! O2Physics PR AliceO2Group/O2Physics#3883 (review) mandatory!!! - enable the processing only for PV contributor tracks Co-authored-by: Mattia Faggin <mfaggin@cern.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
!!! O2Physics PR Rework of the multiplicity and PVcontribs axis ranges settings O2Physics#3883 (review) mandatory!!!