Skip to content

TPC-time-series: dynamic track-types#2141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sawenzel wants to merge 1 commit into
base:master
Choose a base branch
from
Draft

TPC-time-series: dynamic track-types #2141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions MC/bin/o2dpg_sim_workflow.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1948,11 +1948,13 @@ def remove_json_prefix(path):
# TODO: this needs to be made configurable (as a function of which detectors are actually present)
tpctsneeds = [ TPCRECOtask['name'],
ITSTPCMATCHtask['name'],
TOFTPCMATCHERtask['name'],
TOFTPCMATCHERtask['name'] if isActive("TOF") else None,
PVFINDERtask['name']
]
timeseries_tracktypes=cleanDetectorInputList("ITS,TPC,ITS-TPC,ITS-TPC-TOF,ITS-TPC-TRD-TOF")
timeseries_clustertypes=cleanDetectorInputList("FT0,TOF,TPC")
TPCTStask = createTask(name='tpctimeseries_'+str(tf), needs=tpctsneeds, tf=tf, cwd=timeframeworkdir, lab=["RECO"], mem='2000', cpu='1')
TPCTStask['cmd'] = 'o2-global-track-cluster-reader --disable-mc --cluster-types "FT0,TOF,TPC" --track-types "ITS,TPC,ITS-TPC,ITS-TPC-TOF,ITS-TPC-TRD-TOF"'
TPCTStask['cmd'] = f'o2-global-track-cluster-reader --disable-mc --cluster-types {timeseries_clustertypes} --track-types {timeseries_tracktypes}'

@shahor02shahor02Oct 4, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It initialises unconditionally the readers for TOF clusters and tracks, in the absence of TOF this should lead to a crash. The timeseries_tracktypes and timeseries_clustertypes should not have contributions from detectors which are absent. Also the o2-tpc-time-series-workflow currently implicitly expects all track types it can digest, the same --track-types {timeseries_tracktypes} should be passed to it.
But why are the inputs of this workflow not simply copied from the anchor production workflow?

@matthias-kleiner, in the long run it would be better to modify the o2-global-track-cluster-reader to do what all other global workflows do: configure its input readers internally according to requested options, unless --disable-root-input is requested, e.g. https://github.com/AliceO2Group/AliceO2/blob/166180af16ecac7fa234714cdd7ae0394ea5a192/Detectors/GlobalTrackingWorkflow/src/SecondaryVertexingSpec.cxx#L246-L273

@matthias-kleinermatthias-kleinerOct 6, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @shahor02 ,
many thanks for the detailed comment. I will take a look into it.

TPCTStask['cmd'] += ' --primary-vertices '
TPCTStask['cmd'] += ' | o2-tpc-time-series-workflow --enable-unbinned-root-output --sample-unbinned-tsallis --sampling-factor 0.01 '
TPCTStask['cmd'] += putConfigValues() + ' ' + getDPL_global_options(bigshm=True)
Expand Down