Skip to content

[PWGCF] Add PID in MC process functions - #10749

Merged
victor-gonzalez merged 17 commits into
AliceO2Group:masterfrom
cnkoster:master
Apr 4, 2025
Merged

[PWGCF] Add PID in MC process functions#10749
victor-gonzalez merged 17 commits into
AliceO2Group:masterfrom
cnkoster:master

Conversation

@cnkoster

@cnkostercnkoster commented Apr 3, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@github-actionsgithub-actionsBot changed the title Add PID in MC process functions[PWGCF] Add PID in MC process functionsApr 3, 2025
@alibuildalibuild mentioned this pull request Apr 3, 2025
Merged
cnkosterand others added 2 commits April 3, 2025 16:34
@alibuildalibuild mentioned this pull request Apr 3, 2025
Merged
@alibuildalibuild mentioned this pull request Apr 3, 2025
Merged
@alibuildalibuild mentioned this pull request Apr 3, 2025
Merged
@cnkoster
cnkoster marked this pull request as ready for review April 3, 2025 18:26
victor-gonzalez
victor-gonzalez previously approved these changes Apr 3, 2025
View reviewed changes
@victor-gonzalez

victor-gonzalez commented Apr 3, 2025

Copy link
Copy Markdown
Collaborator

Does the code compile locally?

@alibuild

alibuild commented Apr 3, 2025

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 39cedd9 at 2025-04-03 20:43:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/10749-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:1314:2: error: expected '}' at end of input
/sw/SOURCES/O2Physics/10749-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:259:9: error: 'doprocessData' was not declared in this scope
/sw/SOURCES/O2Physics/10749-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:259:26: error: 'doprocessMCReco' was not declared in this scope
/sw/SOURCES/O2Physics/10749-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:259:45: error: 'doprocessMCGen' was not declared in this scope
/sw/SOURCES/O2Physics/10749-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:420:9: error: 'doprocessMCGen' was not declared in this scope
/sw/SOURCES/O2Physics/10749-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:607:9: error: expected '}' before 'else'
/sw/SOURCES/O2Physics/10749-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:1314:2: error: expected unqualified-id at end of input
ninja: build stopped: subcommand failed.

Full log here.

@alibuildalibuild mentioned this pull request Apr 4, 2025
Merged
@cnkoster
Merge pull request#47from alibuild/alibot-cleanup-10749
a1b0fe6
[PWGCF] Please consider the following formatting changes to AliceO2Group#10749
@cnkoster

cnkoster commented Apr 4, 2025

Copy link
Copy Markdown
ContributorAuthor

I fixed the problem (there was a "{" somewhere where it shouldn't) and now it builds locally.
However, the build on macOS still seems to fail

@victor-gonzalez
victor-gonzalez merged commit e946fff into AliceO2Group:masterApr 4, 2025
louisemillot pushed a commit to louisemillot/O2Physics that referenced this pull request Apr 8, 2025
@cnkoster@alibuild@louisemillot
[PWGCF] Add PID in MC process functions (AliceO2Group#10749)
d48a630
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
njacazio pushed a commit that referenced this pull request Apr 11, 2025
@cnkoster@alibuild@njacazio
[PWGCF] Add PID in MC process functions (#10749)
85d84df
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ariedel-cern pushed a commit to ariedel-cern/O2Physics that referenced this pull request May 23, 2025
@cnkoster@alibuild@ariedel-cern
[PWGCF] Add PID in MC process functions (AliceO2Group#10749)
1319f6a
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Jun 17, 2025
@cnkoster@alibuild@smaff92
[PWGCF] Add PID in MC process functions (AliceO2Group#10749)
36e834b
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
alibuild added a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
@cnkoster@alibuild@CesarOmarRA
[PWGCF] Add PID in MC process functions (AliceO2Group#10749)
0f75664
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@victor-gonzalezvictor-gonzalezvictor-gonzalez approved these changes
@alibuildalibuildAwaiting requested review from alibuildalibuild is a code owner
@saganattsaganattAwaiting requested review from saganatt
@zchochulzchochulAwaiting requested review from zchochul
@lgraczykCernlgraczykCernAwaiting requested review from lgraczykCern
@prchakraprchakraAwaiting requested review from prchakra
@lauraserlauraserAwaiting requested review from lauraserlauraser is a code owner
@ariedel-cernariedel-cernAwaiting requested review from ariedel-cern
@otonvdotonvdAwaiting requested review from otonvd
@shouqiyeshouqiyeAwaiting requested review from shouqiye
@glromaneglromaneAwaiting requested review from glromane

Assignees

No one assigned

Labels

pwgcf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cnkoster@victor-gonzalez@alibuild