Skip to content

[PWGHF] Added centrality to D+ tree tables - #10895

Closed
Marcellocosti wants to merge 8 commits into
AliceO2Group:masterfrom
Marcellocosti:master
Closed

[PWGHF] Added centrality to D+ tree tables#10895
Marcellocosti wants to merge 8 commits into
AliceO2Group:masterfrom
Marcellocosti:master

Conversation

@Marcellocosti

@MarcellocostiMarcellocosti commented Apr 17, 2025

Copy link
Copy Markdown
Contributor

Updating PR #10876 with correct process function activation.

@github-actionsgithub-actionsBot added the pwghf PWG-HF label Apr 17, 2025
@alibuildalibuild mentioned this pull request Apr 17, 2025
Merged
@Marcellocosti
Merge pull request#11from alibuild/alibot-cleanup-10895
424a99e
[PWGHF] Please consider the following formatting changes to AliceO2Group#10895
@vkucera

vkucera commented Apr 17, 2025

Copy link
Copy Markdown
Collaborator

Why don't you update #10876 ?

@vkucera
vkucera marked this pull request as draft April 17, 2025 13:48
@Marcellocosti

Marcellocosti commented Apr 17, 2025

Copy link
Copy Markdown
ContributorAuthor

Hi @vkucera, the issue is that I introduced a further modification in #10876 after merging the PR related to the formatting changes. Then I force-pushed the modification, and but the PR couldn't be updated.

@vkucera

vkucera commented Apr 17, 2025

Copy link
Copy Markdown
Collaborator

Hi @vkucera, the issue is that I introduced a further modification in #10876 after merging the PR related to the formatting changes. Then I force-pushed the modification, and but the PR couldn't be updated.

As far as I can see, you did not force-push the modification. Even if you did, I don't see why opening a new PR would solve any conflicts. A PR can always be updated unless merged or closed. Please do not create duplicate PRs to solve Git issues. Also consider using pre-commit for automatic formatting at the time of making your commits.

@vkuceravkucera closed this Apr 17, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuildalibuildAwaiting requested review from alibuildalibuild is a code owner
@vkuceravkuceraAwaiting requested review from vkuceravkucera is a code owner
@fcolamarfcolamarAwaiting requested review from fcolamarfcolamar is a code owner
@fgrosafgrosaAwaiting requested review from fgrosafgrosa is a code owner
@fcatalan92fcatalan92Awaiting requested review from fcatalan92fcatalan92 is a code owner
@mfagginmfagginAwaiting requested review from mfagginmfaggin is a code owner
@mmazzillimmazzilliAwaiting requested review from mmazzillimmazzilli is a code owner
@deepathomsdeepathomsAwaiting requested review from deepathomsdeepathoms is a code owner
@NicoleBastidNicoleBastidAwaiting requested review from NicoleBastidNicoleBastid is a code owner
@hahassan7hahassan7Awaiting requested review from hahassan7hahassan7 is a code owner
@jpxrkjpxrkAwaiting requested review from jpxrkjpxrk is a code owner
@apalascianoapalascianoAwaiting requested review from apalascianoapalasciano is a code owner
@zhangbiao-phyzhangbiao-phyAwaiting requested review from zhangbiao-phyzhangbiao-phy is a code owner
@gluparelgluparelAwaiting requested review from gluparelgluparel will be requested when the pull request is marked ready for reviewgluparel is a code owner
@stefanopolitanostefanopolitanoAwaiting requested review from stefanopolitanostefanopolitano will be requested when the pull request is marked ready for reviewstefanopolitano is a code owner
@xinyepengxinyepengAwaiting requested review from xinyepengxinyepeng will be requested when the pull request is marked ready for reviewxinyepeng is a code owner
@singhra1994singhra1994Awaiting requested review from singhra1994singhra1994 will be requested when the pull request is marked ready for reviewsinghra1994 is a code owner

Assignees

No one assigned

Labels

pwghfPWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Marcellocosti@vkucera@alibuild