Skip to content

[PWGCF] added some QA histos and cleaned up configurables - #11114

Closed
cnkoster wants to merge 19 commits into
AliceO2Group:masterfrom
cnkoster:master
Closed

[PWGCF] added some QA histos and cleaned up configurables#11114
cnkoster wants to merge 19 commits into
AliceO2Group:masterfrom
cnkoster:master

Conversation

@cnkoster

@cnkostercnkoster commented May 7, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@github-actionsgithub-actionsBot changed the title added some QA histos and cleaned up configurables[PWGCF] added some QA histos and cleaned up configurablesMay 7, 2025
@github-actions

github-actionsBot commented May 7, 2025•
edited
Loading

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@alibuildalibuild mentioned this pull request May 7, 2025
Merged
@cnkoster
Merge pull request#52from alibuild/alibot-cleanup-11114
be25124
[PWGCF] Please consider the following formatting changes to AliceO2Group#11114
@cnkoster
cnkoster marked this pull request as ready for review May 8, 2025 12:04
@alibuild

alibuild commented May 8, 2025

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for be25124 at 2025-05-08 14:20:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11114-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:653:77: error: unused parameter 'centrality' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/11114-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:653:77: error: unused parameter 'centrality' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@alibuildalibuild mentioned this pull request May 8, 2025
Merged
@cnkoster
Merge pull request#53from alibuild/alibot-cleanup-11114
18eb4ec
[PWGCF] Please consider the following formatting changes to AliceO2Group#11114
@alibuild

alibuild commented May 8, 2025

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 18eb4ec at 2025-05-08 14:45:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11114-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:1008:43: error: no matching function for call to 'get_str()'
/sw/SOURCES/O2Physics/11114-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:1008:43: error: no matching function for call to 'get_size()'
/sw/SOURCES/O2Physics/11114-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:1010:43: error: no matching function for call to 'get_str()'
/sw/SOURCES/O2Physics/11114-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:1010:43: error: no matching function for call to 'get_size()'
/sw/SOURCES/O2Physics/11114-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:655:77: error: unused parameter 'centrality' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/11114-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:655:77: error: unused parameter 'centrality' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented May 8, 2025

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for eef36ac at 2025-05-08 15:31:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11114-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:655:77: error: unused parameter 'centrality' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/11114-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:655:77: error: unused parameter 'centrality' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@alibuildalibuild mentioned this pull request May 8, 2025
Merged
@alibuildalibuild mentioned this pull request May 8, 2025
Merged
@cnkoster
Merge pull request#55from alibuild/alibot-cleanup-11114
03cf97e
[PWGCF] Please consider the following formatting changes to AliceO2Group#11114
@alibuild

alibuild commented May 8, 2025

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 16fa968 at 2025-05-08 15:55:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11114-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:1357:4: error: expected ';' after struct definition
/sw/SOURCES/O2Physics/11114-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:260:45: error: 'doprocessMCGen' was not declared in this scope; did you mean 'processMCGen'?
/sw/SOURCES/O2Physics/11114-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:426:9: error: 'doprocessMCGen' was not declared in this scope; did you mean 'processMCGen'?
/sw/SOURCES/O2Physics/11114-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:1297:9: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
/sw/SOURCES/O2Physics/11114-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:1308:29: error: 'col' was not declared in this scope; did you mean 'cosl'?
/sw/SOURCES/O2Physics/11114-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:1308:34: error: 'trackSlice' was not declared in this scope
/sw/SOURCES/O2Physics/11114-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:1359:1: error: expected declaration before '}' token
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented May 8, 2025

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 03cf97e at 2025-05-08 16:08:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11114-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:1357:4: error: expected ';' after struct definition
/sw/SOURCES/O2Physics/11114-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:260:45: error: 'doprocessMCGen' was not declared in this scope; did you mean 'processMCGen'?
/sw/SOURCES/O2Physics/11114-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:426:9: error: 'doprocessMCGen' was not declared in this scope; did you mean 'processMCGen'?
/sw/SOURCES/O2Physics/11114-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:1308:29: error: 'col' was not declared in this scope; did you mean 'cosl'?
/sw/SOURCES/O2Physics/11114-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:1308:34: error: 'trackSlice' was not declared in this scope
/sw/SOURCES/O2Physics/11114-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:1359:1: error: expected declaration before '}' token
ninja: build stopped: subcommand failed.

Full log here.

@alibuildalibuild mentioned this pull request May 12, 2025
Merged
@alibuildalibuild mentioned this pull request May 12, 2025
Merged
@cnkoster
Merge pull request#57from alibuild/alibot-cleanup-11114
d8fb025
[PWGCF] Please consider the following formatting changes to AliceO2Group#11114
@cnkostercnkoster reopened this May 12, 2025
@alibuild

alibuild commented May 12, 2025

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for d8fb025 at 2025-05-12 19:57:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11114-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:956:94: error: expected primary-expression before ',' token
/sw/SOURCES/O2Physics/11114-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:957:96: error: expected primary-expression before ',' token
/sw/SOURCES/O2Physics/11114-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:958:96: error: expected primary-expression before ',' token
/sw/SOURCES/O2Physics/11114-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:959:120: error: expected primary-expression before ',' token
/sw/SOURCES/O2Physics/11114-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:960:115: error: expected primary-expression before ',' token
/sw/SOURCES/O2Physics/11114-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:961:113: error: expected primary-expression before ',' token
/sw/SOURCES/O2Physics/11114-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:962:139: error: expected primary-expression before ',' token
/sw/SOURCES/O2Physics/11114-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:963:128: error: expected primary-expression before ',' token
/sw/SOURCES/O2Physics/11114-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:964:161: error: expected primary-expression before ',' token
ninja: build stopped: subcommand failed.

Full log here.

@victor-gonzalez

victor-gonzalez commented May 12, 2025

Copy link
Copy Markdown
Collaborator

Please, be sure the code compiles locally and executes as expected before creating a pull request

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuildalibuildAwaiting requested review from alibuildalibuild is a code owner
@saganattsaganattAwaiting requested review from saganatt
@victor-gonzalezvictor-gonzalezAwaiting requested review from victor-gonzalezvictor-gonzalez is a code owner
@zchochulzchochulAwaiting requested review from zchochul
@lgraczykCernlgraczykCernAwaiting requested review from lgraczykCern
@prchakraprchakraAwaiting requested review from prchakra
@lauraserlauraserAwaiting requested review from lauraserlauraser is a code owner
@ariedel-cernariedel-cernAwaiting requested review from ariedel-cern
@otonvdotonvdAwaiting requested review from otonvd
@shouqiyeshouqiyeAwaiting requested review from shouqiye
@glromaneglromaneAwaiting requested review from glromane

Assignees

No one assigned

Labels

pwgcf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cnkoster@alibuild@victor-gonzalez