Uh oh!
There was an error while loading. Please reload this page.
Fix for D2H macros - #1121
Merged
Merged
Conversation
fcatalan92
requested review from
alibuild, cterrevo, fcolamar, ginnocen, lvermunt, vkucera and xinyepeng
as code ownersAugust 10, 2022 14:17
fgrosa
commented
Aug 10, 2022
Collaborator
Hi @fcatalan92 the changes look good to me, thanks! @xinyepeng@lvermunt can you check if this is good also for you and possibly approve? Thanks! |
lvermunt
approved these changes
Aug 10, 2022
lvermunt
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, I approve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@fgrosa After a long delay, I had a look at #920. I made some minor fixes and refactored the code of
style_formatter.py.