Skip to content

[PWGHF] Add ML selection for Xic0ToXiPiKf - #11388

Merged
fgrosa merged 31 commits into
AliceO2Group:masterfrom
Tao-Fang:20250528_1
Jun 3, 2025
Merged

[PWGHF] Add ML selection for Xic0ToXiPiKf#11388
fgrosa merged 31 commits into
AliceO2Group:masterfrom
Tao-Fang:20250528_1

Conversation

@Tao-Fang

@Tao-FangTao-Fang commented May 28, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actionsBot commented May 28, 2025•
edited
Loading

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actionsgithub-actionsBot changed the title Add MlSelection at candidateSelectorXic0ToXiPiKf.cxx and uplode HfMlResponseXicToXiPikf.h[PWGHF] Add MlSelection at candidateSelectorXic0ToXiPiKf.cxx and uplode HfMlResponseXicToXiPikf.hMay 28, 2025
@alibuildalibuild mentioned this pull request May 28, 2025
Merged
@Tao-Fang
Tao-Fang marked this pull request as ready for review May 28, 2025 08:53
vkucera
vkucera requested changes May 28, 2025
View reviewed changes
Comment threadPWGHF/Core/HfMlResponseXicToXiPikf.h Outdated
vkucera
vkucera requested changes May 28, 2025
View reviewed changes
Comment threadPWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx Outdated
vkucera
vkucera requested changes May 30, 2025
View reviewed changes
Comment threadPWGHF/Core/HfMlResponseXic0ToXiPikf.h Outdated
@vkucera
vkucera marked this pull request as draft May 30, 2025 16:20
@Tao-Fang
Tao-Fang marked this pull request as ready for review May 31, 2025 07:13
@alibuild

alibuild commented May 31, 2025

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 0bcbba3 at 2025-05-31 09:36:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:128:78: error: 'hf_cuts_ml' was not declared in this scope
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:128:78: error: no matching function for call to 'std::vector<double>::vector(<brace-enclosed initializer list>)'
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:128:77: error: expected primary-expression before '{' token
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:128:77: error: expected '}' before '{' token
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:128:77: error: could not convert '{"binsPtMl", <expression error>}' from '<brace-enclosed initializer list>' to 'o2::framework::Configurable<std::vector<double> >'
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:128:77: error: expected ';' before '{' token
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:129:72: error: 'hf_cuts_ml' was not declared in this scope
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:129:72: error: no matching function for call to 'std::vector<int>::vector(<brace-enclosed initializer list>)'
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:129:71: error: expected primary-expression before '{' token
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:129:71: error: expected '}' before '{' token
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:129:71: error: could not convert '{"cutDirMl", <expression error>}' from '<brace-enclosed initializer list>' to 'o2::framework::Configurable<std::vector<int> >'
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:129:71: error: expected ';' before '{' token
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:130:56: error: 'hf_cuts_ml' has not been declared
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:130:77: error: 'hf_cuts_ml' has not been declared
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:130:98: error: 'hf_cuts_ml' has not been declared
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:130:122: error: 'hf_cuts_ml' has not been declared
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:130:144: error: 'hf_cuts_ml' has not been declared
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:130:199: error: could not convert '{"cutsMl", {<expression error>, <expression error>, <expression error>, <expression error>, <expression error>}, "ML selections per pT bin"}' from '<brace-enclosed initializer list>' to 'o2::framework::Configurable<o2::framework::LabeledArray<double> >'
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:131:63: error: 'hf_cuts_ml' has not been declared
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:131:119: error: could not convert '{"nClassesMl", <expression error>, "Number of classes in ML model"}' from '<brace-enclosed initializer list>' to 'o2::framework::Configurable<int>'
/sw/slc9_x86-64/O2/daily-20250531-0000-local1/include/Framework/StructToTuple.h:141:38: error: static assertion failed: You need to make sure that you have implicit constructors or that you call the explicit constructor correctly.
/sw/slc9_x86-64/GCC-Toolchain/v14.2.0-alice2-1/include/c++/14.2.0/bits/stl_construct.h:115:28: error: no matching function for call to 'construct_at(HfCandidateSelectorXic0ToXiPiKf*&)'
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented May 31, 2025

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for b0c4a5f at 2025-05-31 12:42:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:128:78: error: 'hf_cuts_ml' was not declared in this scope
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:128:78: error: no matching function for call to 'std::vector<double>::vector(<brace-enclosed initializer list>)'
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:128:77: error: expected primary-expression before '{' token
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:128:77: error: expected '}' before '{' token
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:128:77: error: could not convert '{"binsPtMl", <expression error>}' from '<brace-enclosed initializer list>' to 'o2::framework::Configurable<std::vector<double> >'
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:128:77: error: expected ';' before '{' token
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:129:72: error: 'hf_cuts_ml' was not declared in this scope
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:129:72: error: no matching function for call to 'std::vector<int>::vector(<brace-enclosed initializer list>)'
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:129:71: error: expected primary-expression before '{' token
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:129:71: error: expected '}' before '{' token
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:129:71: error: could not convert '{"cutDirMl", <expression error>}' from '<brace-enclosed initializer list>' to 'o2::framework::Configurable<std::vector<int> >'
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:129:71: error: expected ';' before '{' token
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:130:56: error: 'hf_cuts_ml' has not been declared
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:130:77: error: 'hf_cuts_ml' has not been declared
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:130:98: error: 'hf_cuts_ml' has not been declared
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:130:122: error: 'hf_cuts_ml' has not been declared
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:130:144: error: 'hf_cuts_ml' has not been declared
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:130:199: error: could not convert '{"cutsMl", {<expression error>, <expression error>, <expression error>, <expression error>, <expression error>}, "ML selections per pT bin"}' from '<brace-enclosed initializer list>' to 'o2::framework::Configurable<o2::framework::LabeledArray<double> >'
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:131:63: error: 'hf_cuts_ml' has not been declared
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:131:119: error: could not convert '{"nClassesMl", <expression error>, "Number of classes in ML model"}' from '<brace-enclosed initializer list>' to 'o2::framework::Configurable<int>'
/sw/slc9_x86-64/O2/daily-20250531-0000-local1/include/Framework/StructToTuple.h:141:38: error: static assertion failed: You need to make sure that you have implicit constructors or that you call the explicit constructor correctly.
/sw/slc9_x86-64/GCC-Toolchain/v14.2.0-alice2-1/include/c++/14.2.0/bits/stl_construct.h:115:28: error: no matching function for call to 'construct_at(HfCandidateSelectorXic0ToXiPiKf*&)'
ninja: build stopped: subcommand failed.

Full log here.

@vkucera
vkucera marked this pull request as draft May 31, 2025 12:01
@Tao-Fang
Tao-Fang marked this pull request as ready for review June 2, 2025 11:14
@alibuild

alibuild commented Jun 2, 2025

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 3dbd992 at 2025-06-02 15:30:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:128:78: error: 'hf_cuts_ml' was not declared in this scope
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:128:78: error: no matching function for call to 'std::vector<double>::vector(<brace-enclosed initializer list>)'
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:128:77: error: expected primary-expression before '{' token
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:128:77: error: expected '}' before '{' token
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:128:77: error: could not convert '{"binsPtMl", <expression error>}' from '<brace-enclosed initializer list>' to 'o2::framework::Configurable<std::vector<double> >'
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:128:77: error: expected ';' before '{' token
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:129:72: error: 'hf_cuts_ml' was not declared in this scope
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:129:72: error: no matching function for call to 'std::vector<int>::vector(<brace-enclosed initializer list>)'
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:129:71: error: expected primary-expression before '{' token
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:129:71: error: expected '}' before '{' token
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:129:71: error: could not convert '{"cutDirMl", <expression error>}' from '<brace-enclosed initializer list>' to 'o2::framework::Configurable<std::vector<int> >'
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:129:71: error: expected ';' before '{' token
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:130:56: error: 'hf_cuts_ml' has not been declared
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:130:77: error: 'hf_cuts_ml' has not been declared
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:130:98: error: 'hf_cuts_ml' has not been declared
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:130:122: error: 'hf_cuts_ml' has not been declared
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:130:144: error: 'hf_cuts_ml' has not been declared
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:130:199: error: could not convert '{"cutsMl", {<expression error>, <expression error>, <expression error>, <expression error>, <expression error>}, "ML selections per pT bin"}' from '<brace-enclosed initializer list>' to 'o2::framework::Configurable<o2::framework::LabeledArray<double> >'
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:131:63: error: 'hf_cuts_ml' has not been declared
/sw/SOURCES/O2Physics/11388-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorXic0ToXiPiKf.cxx:131:119: error: could not convert '{"nClassesMl", <expression error>, "Number of classes in ML model"}' from '<brace-enclosed initializer list>' to 'o2::framework::Configurable<int>'
/sw/slc9_x86-64/O2/daily-20250602-0000-local2/include/Framework/StructToTuple.h:141:38: error: static assertion failed: You need to make sure that you have implicit constructors or that you call the explicit constructor correctly.
/sw/slc9_x86-64/GCC-Toolchain/v14.2.0-alice2-1/include/c++/14.2.0/bits/stl_construct.h:115:28: error: no matching function for call to 'construct_at(HfCandidateSelectorXic0ToXiPiKf*&)'
ninja: build stopped: subcommand failed.

Full log here.

@Tao-Fang
Tao-Fang requested a review from vkuceraJune 3, 2025 07:01
vkucera
vkucera approved these changes Jun 3, 2025
View reviewed changes

@vkuceravkucera left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Tao-Fang for addressing my comments.

@fgrosa
fgrosa enabled auto-merge (squash) June 3, 2025 12:18
@fgrosa
fgrosa merged commit 754dcbf into AliceO2Group:masterJun 3, 2025
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Jun 11, 2025
@Tao-Fang@alibuild
@vkucera@jinhyunni
[PWGHF] Add ML selection for Xic0ToXiPiKf (AliceO2Group#11388)
6072536
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
hernasab pushed a commit to hernasab/O2Physics that referenced this pull request Jun 11, 2025
@Tao-Fang@alibuild
@vkuceraSabrina Hernandez
[PWGHF] Add ML selection for Xic0ToXiPiKf (AliceO2Group#11388)
f67e433
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
EmilGorm pushed a commit to EmilGorm/O2Physics that referenced this pull request Jun 12, 2025
@Tao-Fang@alibuild
@vkucera@EmilGorm
[PWGHF] Add ML selection for Xic0ToXiPiKf (AliceO2Group#11388)
9f9db9e
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jun 12, 2025
@Tao-Fang@alibuild
@vkuceraProttay Das
[PWGHF] Add ML selection for Xic0ToXiPiKf (AliceO2Group#11388)
068effd
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jun 14, 2025
@Tao-Fang@alibuild
@vkuceraDavid Dobrigkeit Chinellato
[PWGHF] Add ML selection for Xic0ToXiPiKf (AliceO2Group#11388)
ed911d3
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Jun 17, 2025
@Tao-Fang@alibuild
@vkucera@smaff92
[PWGHF] Add ML selection for Xic0ToXiPiKf (AliceO2Group#11388)
5d12ca0
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jul 16, 2025
@Tao-Fang@alibuild
@vkucera@romainschotter
[PWGHF] Add ML selection for Xic0ToXiPiKf (AliceO2Group#11388)
9ed72d1
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
alibuild added a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
@Tao-Fang@alibuild
@vkucera@CesarOmarRA
[PWGHF] Add ML selection for Xic0ToXiPiKf (AliceO2Group#11388)
d110d91
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@Tao-Fang@alibuild
@vkucera@jloemker
[PWGHF] Add ML selection for Xic0ToXiPiKf (AliceO2Group#11388)
c5485b1
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkuceravkuceravkucera approved these changes
@alibuildalibuildAwaiting requested review from alibuildalibuild is a code owner
@fcolamarfcolamarAwaiting requested review from fcolamarfcolamar is a code owner
@fgrosafgrosaAwaiting requested review from fgrosafgrosa is a code owner
@fcatalan92fcatalan92Awaiting requested review from fcatalan92fcatalan92 is a code owner
@mfagginmfagginAwaiting requested review from mfagginmfaggin is a code owner
@mmazzillimmazzilliAwaiting requested review from mmazzillimmazzilli is a code owner
@deepathomsdeepathomsAwaiting requested review from deepathomsdeepathoms is a code owner
@NicoleBastidNicoleBastidAwaiting requested review from NicoleBastidNicoleBastid is a code owner
@hahassan7hahassan7Awaiting requested review from hahassan7hahassan7 is a code owner
@jpxrkjpxrkAwaiting requested review from jpxrkjpxrk is a code owner
@apalascianoapalascianoAwaiting requested review from apalascianoapalasciano is a code owner
@zhangbiao-phyzhangbiao-phyAwaiting requested review from zhangbiao-phyzhangbiao-phy is a code owner

Assignees

No one assigned

Labels

datamodelpwghfPWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Tao-Fang@alibuild@vkucera@fgrosa