Skip to content

[PWGHF] Refactor of charm resonances derived data creator - #11447

Merged
fgrosa merged 15 commits into
AliceO2Group:masterfrom
Luca610:data_creator_refactor
Jun 3, 2025
Merged

[PWGHF] Refactor of charm resonances derived data creator#11447
fgrosa merged 15 commits into
AliceO2Group:masterfrom
Luca610:data_creator_refactor

Conversation

@Luca610

@Luca610Luca610 commented Jun 2, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

This PR refactors the dataCreatorCharmResoReduced workflow adding the following features:

  • posisbility to create resonances that decay into a D0 + track or V0
  • possibility to create simultaneously resonances with a V0 or a track in their final state to produce derived data to be stored on grid
  • minor: added generated invariant mass to MC reco table for resolution determination

A refactor of MC matching functions will follow soon after the merge of PRs #11382 and #11418

@github-actions

github-actionsBot commented Jun 2, 2025•
edited
Loading

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 33 disabled

@github-actionsgithub-actionsBot changed the title Refactor of charm resonances derived data creator[PWGHF] Refactor of charm resonances derived data creatorJun 2, 2025
@alibuildalibuild mentioned this pull request Jun 2, 2025
Merged
@alibuildalibuild mentioned this pull request Jun 2, 2025
Merged
@alibuildalibuild mentioned this pull request Jun 3, 2025
Merged
@alibuildalibuild mentioned this pull request Jun 3, 2025
Merged
@Luca610
Merge pull request#49from alibuild/alibot-cleanup-11447
2b5c744
Please consider the following formatting changes to AliceO2Group#11447
fgrosa
fgrosa requested changes Jun 3, 2025
View reviewed changes

@fgrosafgrosa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Luca610 many thanks for the developments! I agree to implement in a second PR the matching to the MC based on the central improvements for standard channels, in the meantime I have a few (mostly minor) comments. Once implemented, you can mark the PR as ready for review for me

Comment threadPWGHF/D2H/TableProducer/dataCreatorCharmResoReduced.cxx Outdated
Comment threadPWGHF/D2H/TableProducer/dataCreatorCharmResoReduced.cxx Outdated
Comment threadPWGHF/D2H/TableProducer/dataCreatorCharmResoReduced.cxx Outdated
Comment threadPWGHF/D2H/TableProducer/dataCreatorCharmResoReduced.cxx Outdated
Comment threadPWGHF/D2H/TableProducer/dataCreatorCharmResoReduced.cxx
Comment threadPWGHF/D2H/TableProducer/dataCreatorCharmResoReduced.cxx Outdated
Comment threadPWGHF/D2H/TableProducer/dataCreatorCharmResoReduced.cxx Outdated
Comment threadPWGHF/D2H/TableProducer/dataCreatorCharmResoReduced.cxx Outdated
Comment threadPWGHF/D2H/TableProducer/dataCreatorCharmResoReduced.cxx
@alibuildalibuild mentioned this pull request Jun 3, 2025
Merged
@Luca610

Luca610 commented Jun 3, 2025

Copy link
Copy Markdown
ContributorAuthor

Hi @fgrosa,
Thank you very much for your comments! I implemented them in the latest commit

@Luca610
Merge pull request#50from alibuild/alibot-cleanup-11447
49b0c4d
Please consider the following formatting changes to AliceO2Group#11447
@Luca610
Luca610 marked this pull request as ready for review June 3, 2025 16:20
@fgrosa
fgrosa enabled auto-merge (squash) June 3, 2025 16:32
@fgrosa
fgrosa merged commit 1b27145 into AliceO2Group:masterJun 3, 2025
@Luca610
Luca610 deleted the data_creator_refactor branch June 4, 2025 09:34
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Jun 11, 2025
@Luca610@alibuild@jinhyunni
[PWGHF] Refactor of charm resonances derived data creator (AliceO2Gro…
111b0e7
…up#11447)
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
hernasab pushed a commit to hernasab/O2Physics that referenced this pull request Jun 11, 2025
@Luca610@alibuildSabrina Hernandez
[PWGHF] Refactor of charm resonances derived data creator (AliceO2Gro…
ae51c26
…up#11447)
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
EmilGorm pushed a commit to EmilGorm/O2Physics that referenced this pull request Jun 12, 2025
@Luca610@alibuild@EmilGorm
[PWGHF] Refactor of charm resonances derived data creator (AliceO2Gro…
f82737f
…up#11447)
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jun 12, 2025
@Luca610@alibuildProttay Das
[PWGHF] Refactor of charm resonances derived data creator (AliceO2Gro…
ed3f5b5
…up#11447)
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jun 14, 2025
@Luca610@alibuildDavid Dobrigkeit Chinellato
[PWGHF] Refactor of charm resonances derived data creator (AliceO2Gro…
5fa648e
…up#11447)
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Jun 17, 2025
@Luca610@alibuild@smaff92
[PWGHF] Refactor of charm resonances derived data creator (AliceO2Gro…
e382f4f
…up#11447)
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
vkucera
vkucera reviewed Jul 14, 2025
View reviewed changes
Comment threadPWGHF/D2H/TableProducer/dataCreatorCharmResoReduced.cxx
Comment on lines -395 to 458
for (int i = 0; i < 3; ++i) {
for (int i = 0; i < 3; ++i) { // o2-linter: disable=magic-number (loop on xyz)
candidateV0.mom[i] = candidateV0.momPos[i] + candidateV0.momNeg[i];

@vkuceravkuceraJul 14, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix this by using RecoDecay::pVec.

ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jul 16, 2025
@Luca610@alibuild@romainschotter
[PWGHF] Refactor of charm resonances derived data creator (AliceO2Gro…
664f2df
…up#11447)
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
alibuild added a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
@Luca610@alibuild@CesarOmarRA
[PWGHF] Refactor of charm resonances derived data creator (AliceO2Gro…
671d96b
…up#11447)
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@Luca610@alibuild@jloemker
[PWGHF] Refactor of charm resonances derived data creator (AliceO2Gro…
eea2cde
…up#11447)
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkuceravkuceravkucera left review comments
@fgrosafgrosafgrosa approved these changes
@alibuildalibuildAwaiting requested review from alibuildalibuild is a code owner
@fcolamarfcolamarAwaiting requested review from fcolamarfcolamar is a code owner
@fcatalan92fcatalan92Awaiting requested review from fcatalan92fcatalan92 is a code owner
@mfagginmfagginAwaiting requested review from mfagginmfaggin is a code owner
@mmazzillimmazzilliAwaiting requested review from mmazzillimmazzilli is a code owner
@deepathomsdeepathomsAwaiting requested review from deepathomsdeepathoms is a code owner
@NicoleBastidNicoleBastidAwaiting requested review from NicoleBastidNicoleBastid is a code owner
@hahassan7hahassan7Awaiting requested review from hahassan7hahassan7 is a code owner
@jpxrkjpxrkAwaiting requested review from jpxrkjpxrk is a code owner
@apalascianoapalascianoAwaiting requested review from apalascianoapalasciano is a code owner
@zhangbiao-phyzhangbiao-phyAwaiting requested review from zhangbiao-phyzhangbiao-phy is a code owner
@gluparelgluparelAwaiting requested review from gluparelgluparel is a code owner

Assignees

No one assigned

Labels

datamodelpwghfPWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Luca610@fgrosa@vkucera@alibuild