Skip to content

[PWGHF] Dstar spin alignment in PbPb - #11767

Merged
vkucera merged 35 commits into
AliceO2Group:masterfrom
Mingze129:DstarInPbPb
Jul 2, 2025
Merged

[PWGHF] Dstar spin alignment in PbPb#11767
vkucera merged 35 commits into
AliceO2Group:masterfrom
Mingze129:DstarInPbPb

Conversation

@Mingze129

@Mingze129Mingze129 commented Jun 25, 2025

Copy link
Copy Markdown
Contributor

Adding new process for Dstar spin alignment analysis in PbPb to CharmPolarisation task.

@github-actionsgithub-actionsBot added the pwghf PWG-HF label Jun 25, 2025
@github-actions

github-actionsBot commented Jun 25, 2025•
edited
Loading

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 5 disabled

@github-actionsgithub-actionsBot changed the title Dstar spin alignment in PbPb[PWGHF] Dstar spin alignment in PbPbJun 25, 2025
@alibuildalibuild mentioned this pull request Jun 25, 2025
Merged
Mingze129 added a commit to Mingze129/O2Physics that referenced this pull request Jun 25, 2025
@Mingze129
Merge pull request#7from alibuild/alibot-cleanup-11767
63b929e
Please consider the following formatting changes to AliceO2Group#11767
fgrosa
fgrosa requested changes Jun 25, 2025
View reviewed changes

@fgrosafgrosa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Mingze129 thanks a lot for the development! The general implementation is good, but there are a couple of things to fix, see my comments below

Comment threadPWGHF/D2H/Tasks/taskCharmPolarisation.cxx Outdated
Comment threadPWGHF/D2H/Tasks/taskCharmPolarisation.cxx Outdated
Comment threadPWGHF/D2H/Tasks/taskCharmPolarisation.cxx Outdated
Comment threadPWGHF/D2H/Tasks/taskCharmPolarisation.cxx Outdated
Comment threadPWGHF/D2H/Tasks/taskCharmPolarisation.cxx Outdated
Comment threadPWGHF/D2H/Tasks/taskCharmPolarisation.cxx
Comment threadPWGHF/D2H/Tasks/taskCharmPolarisation.cxx Outdated
Comment threadPWGHF/D2H/Tasks/taskCharmPolarisation.cxx Outdated
@vkucera
vkucera marked this pull request as draft June 26, 2025 09:21
@alibuildalibuild mentioned this pull request Jun 27, 2025
Merged
@vkucera
vkucera marked this pull request as draft July 1, 2025 13:44
@vkucera

vkucera commented Jul 1, 2025

Copy link
Copy Markdown
Collaborator

Thanks for the fixes but you only made local changes. This will not compile. You have to propagate the changes to the rest of the code.
Please do not mark the PR as ready for review until we converge to a final version.

vkucera
vkucera requested changes Jul 1, 2025
View reviewed changes
Comment threadPWGHF/D2H/Tasks/taskCharmPolarisation.cxx Outdated
Comment threadPWGHF/D2H/Tasks/taskCharmPolarisation.cxx Outdated
@Mingze129

Mingze129 commented Jul 1, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Thanks for the fixes but you only made local changes. This will not compile. You have to propagate the changes to the rest of the code. Please do not mark the PR as ready for review until we converge to a final version.

I am really sorry I missed this. It should be fixed now.
I will let you decide whether the PR are ready for review.

@Mingze129
Mingze129 requested a review from vkuceraJuly 1, 2025 14:13
@alibuildalibuild mentioned this pull request Jul 1, 2025
Merged
@alibuildalibuild mentioned this pull request Jul 2, 2025
Merged
@vkucera
vkucera marked this pull request as ready for review July 2, 2025 12:28
@vkucera
vkucera enabled auto-merge (squash) July 2, 2025 12:29
@vkucera
vkucera merged commit e02f651 into AliceO2Group:masterJul 2, 2025
13 checks passed
jpxrk pushed a commit to jpxrk/O2Physics that referenced this pull request Jul 16, 2025
@Mingze129@jpxrk
[PWGHF] Dstar spin alignment in PbPb (AliceO2Group#11767)
6a4ba7b
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jul 18, 2025
@Mingze129Prottay Das
[PWGHF] Dstar spin alignment in PbPb (AliceO2Group#11767)
223f323
JimunLee pushed a commit to JimunLee/O2Physics that referenced this pull request Jul 22, 2025
@Mingze129jimun_lee
[PWGHF] Dstar spin alignment in PbPb (AliceO2Group#11767)
5969613
vojmach pushed a commit to vojmach/O2Physics that referenced this pull request Jul 23, 2025
@Mingze129@vojmach
[PWGHF] Dstar spin alignment in PbPb (AliceO2Group#11767)
439b3c6
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@Mingze129@jloemker
[PWGHF] Dstar spin alignment in PbPb (AliceO2Group#11767)
6570311
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Dec 5, 2025
@Mingze129MATTEI
[PWGHF] Dstar spin alignment in PbPb (AliceO2Group#11767)
a3fab03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkuceravkuceravkucera approved these changes
@fgrosafgrosafgrosa left review comments
@alibuildalibuildAwaiting requested review from alibuildalibuild is a code owner
@fcolamarfcolamarAwaiting requested review from fcolamarfcolamar is a code owner
@fcatalan92fcatalan92Awaiting requested review from fcatalan92fcatalan92 is a code owner
@mfagginmfagginAwaiting requested review from mfagginmfaggin is a code owner
@mmazzillimmazzilliAwaiting requested review from mmazzillimmazzilli is a code owner
@deepathomsdeepathomsAwaiting requested review from deepathomsdeepathoms is a code owner
@NicoleBastidNicoleBastidAwaiting requested review from NicoleBastidNicoleBastid is a code owner
@hahassan7hahassan7Awaiting requested review from hahassan7hahassan7 is a code owner
@jpxrkjpxrkAwaiting requested review from jpxrkjpxrk is a code owner
@apalascianoapalascianoAwaiting requested review from apalascianoapalasciano is a code owner
@zhangbiao-phyzhangbiao-phyAwaiting requested review from zhangbiao-phyzhangbiao-phy is a code owner
@gluparelgluparelAwaiting requested review from gluparelgluparel is a code owner

Assignees

No one assigned

Labels

pwghfPWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Mingze129@vkucera@fgrosa@alibuild