Uh oh!
There was an error while loading. Please reload this page.
[PWGHF] Fix Xic0 reconstruction online bug, add KF selection, new Xic0 task, and candidateCreator cleanup - #11860
Conversation
…d new Xic0 task file
O2 linter results: ❌ 1 errors, |
alibuild
commented
Jul 7, 2025
Error while checking build/O2Physics/o2 for f0e17df at 2025-07-07 19:38: Full log here. |
Rrantu
commented
Jul 8, 2025
Hi @fgrosa, I’ve updated the code. Could you please take a look and approve it? |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
vkucera
commented
Jul 8, 2025
Please extend the PR description with an explanation of the bug that you fixed. |
Rrantu
commented
Jul 9, 2025
Thanks for the reminder! I’ve now extended the PR description with details about the bug I fixed earlier. |
fgrosa
commented
Jul 9, 2025
Hi @Rrantu please still fix the usage of the proper tracks (i.e. not propagated to the PV for the cascade daughters, and propagated to the PV for the bachelor) in the |
Rrantu
commented
Jul 10, 2025
Hi @fgrosa, I’ve fixed the usage of the proper tracks — cascade daughters now use TracksIU, and the charm bachelor uses Tracks, as expected. Let me know if anything still looks off. |
| auto trackCascDauCharged = casc.bachelor_as<MyKfTracksIU>(); // pion <- xi track | ||
| auto trackV0Dau0 = casc.posTrack_as<MyKfTracksIU>(); // V0 positive daughter track | ||
| auto trackV0Dau1 = casc.negTrack_as<MyKfTracksIU>(); // V0 negative daughter track |
There was a problem hiding this comment.
Casting with _as<> will raise a runtime error, since the Tracks and TracksIU tables have the same index. You need to access the track tables "by hand" with rawIteratorAt, as done in the process functions for the DCAFitter, see e.g.
O2Physics/PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx
Lines 476 to 478 in 2d0c61b
There was a problem hiding this comment.
Thank you! I’ve updated the code to use rawIteratorAt() instead of _as<>.
Uh oh!
There was an error while loading. Please reload this page.
…0 task, and candidateCreator cleanup (AliceO2Group#11860)
…0 task, and candidateCreator cleanup (AliceO2Group#11860)
…0 task, and candidateCreator cleanup (AliceO2Group#11860)
…0 task, and candidateCreator cleanup (AliceO2Group#11860)
…0 task, and candidateCreator cleanup (AliceO2Group#11860)
…0 task, and candidateCreator cleanup (AliceO2Group#11860)
In this PR, I fix an online application bug, add KF variable selection in candidateSelector, introduce a new Xic0 task file (taskXic0ToXiPiKf.cxx), and remove an unused variable and fix an existing bug in the KFParticle part ofcandidateCreator — including an incorrect ctau calculation, incorrect variable names and PDG codes in the cosThetaStar calculation, and a missing testBit check at the beginning.