[PWGJE] Add Jet-hadron correlations task into the JE framework by yhou-git · Pull Request #13847 · AliceO2Group/O2Physics

yhou-git · 2025-11-15T21:20:08Z

No description provided.

github-actions · 2025-11-15T21:20:22Z

O2 linter results: ❌ 1 errors, ⚠️ 0 warnings, 🔕 0 disabled

Please consider the following formatting changes to AliceO2Group#13847

nzardosh · 2025-11-17T18:44:43Z

Hi. Please squash your commits so we can perform a review
thanks,
Nima

yhou-git · 2025-11-18T08:21:51Z

Hi. Please squash your commits so we can perform a review thanks, Nima

Hello Nima, I'm not quite ready yet, but I will be ready for review once it's sorted. Thanks, Yongzhen

vkucera · 2025-11-18T12:12:40Z

@yhou-git Please use a meaningful PR title.

yhou-git · 2025-11-18T12:38:53Z

@yhou-git Please use a meaningful PR title.

Hi Vit, thanks for your reminder, have updated it, thanks a lots. Yongzhen

vkucera · 2025-11-18T13:13:01Z

@yhou-git Please use a meaningful PR title.
Hi Vit, thanks for your reminder, have updated it, thanks a lots. Yongzhen

Thanks to you!

nzardosh · 2025-11-20T09:32:08Z

Hi @yhou-git thanks for letting me know. In general if you are developing your own task its best not to open the PR until you have it ready. In case you are working on a core part of the framework and need intermediate reviews you can open the PR in draft mode

yhou-git · 2025-11-20T10:04:08Z

Hi @yhou-git thanks for letting me know. In general if you are developing your own task its best not to open the PR until you have it ready. In case you are working on a core part of the framework and need intermediate reviews you can open the PR in draft mode

Hi @nzardosh, thanks! My task is now ready for review. There are no further changes planned at the moment. please let me know if anything needs adjustment. Thanks again, yongzhen

nzardosh

Dear @yhou-git Thanks for the PR. In general I think the code is quite a bit more complicated than it needs to be in places. I have tried to highlight examples so you can go through the code and fix each time the example appears. Thanks!

nzardosh · 2025-11-26T08:05:36Z

+ template <typename TCollision>
+ float getCentrality(const TCollision& coll) const
+ {
+ if (cfgCentEstimator.value == 0)


why do you need the .value here instead of calling the variable directly?

I need this centrality value to work for different systems. Pb-Pb uses FT0C for centrality, but pp uses FT0M.
Using .value makes the code flexible for both, or other systems.

nzardosh · 2025-11-26T08:07:08Z

+ // ==========================================================
+ template <typename TCollision>
+ bool isGoodCollision(const TCollision& coll,
+ const std::vector<int>& eventSelectionBits, bool skipMBGapEvents,


all the variables other than coll are defined globally in your struct and do not need to be passed to the function

I see your point and will test it. My idea was to simplify the selections inside each process.

nzardosh · 2025-11-26T08:07:57Z

+ return false;
+ }
+ float cent = getCentrality(coll);
+ if (cent < centralityMin || cent > centralityMax) {


isnt this already taken care of by the eventCuts filter?

Yes, it is already included.
I only added the extra lines as an additional safety check.

nzardosh · 2025-11-26T08:08:10Z

+ if (cent < centralityMin || cent > centralityMax) {
+ return false;
+ }
+ if (std::abs(coll.posZ()) > vertexZCut) {


this can go in the eventCuts filter too

You are right, let me consider whether to retain them or remove them. I shall first test whether removing them changes my results.

nzardosh · 2025-11-26T08:09:23Z

+ double constituentPtMin = -98.0;
+ double constituentPtMax = 9998.0;
+ if (jetAreaFractionMin > jetAreaLimit) {
+ if (jet.area() < jetAreaFractionMin * o2::constants::math::PI * (jet.r() / 100.0) * (jet.r() / 100.0)) {


this cut is typically done in the jetFinder already, but you can do it here too if you want to be safe

Thanks very much for pointing it out. I will check if it influences.

nzardosh · 2025-11-26T08:22:44Z

+ auto tracksTuple = std::make_tuple(jets, tracks);
+ Pair<TCollisions, TJets, TTracks, BinningType> pairData{corrBinning, numberEventsMixed, -1, collisions, tracksTuple, &cache};
+
+ for (const auto& [c1, jets1, c2, tracks2] : pairData) {


how does this work? what is it iterating over?

This part follows the event mixing tutorial.
It builds the mixing pools and iterates over the mixed event pairs.
https://github.com/AliceO2Group/O2Physics/blob/master/Tutorials/src/eventMixing.cxx#L220C25-L220C28.

nzardosh · 2025-11-26T08:23:50Z

+ if (!jetderiveddatautilities::selectCollision(collision, eventSelectionBits, skipMBGapEvents)) {
+ continue;
+ }
+ if (collision.trackOccupancyInTimeRange() < trackOccupancyInTimeRangeMin || trackOccupancyInTimeRangeMax < collision.trackOccupancyInTimeRange()) {


these can all be in filters

Ok, I see and will try to improve it, thanks

nzardosh · 2025-11-26T08:25:38Z

+
+ if (acceptSplitCollisions == SplitOkCheckFirstAssocCollOnly || acceptSplitCollisions == NonSplitOnly) {
+ centrality = getCentrality(collisions.begin());
+ multiplicity = getMultiplicity(collisions.begin());


does the SmallGroups essentially slice the collision table?

I think so, smallgroups gives only the collisions associated to the current mccollision.

nzardosh · 2025-11-26T08:26:45Z

+ }
+ }
+ }
+ if (!hasSel8Coll || !centralityIsGood || !occupancyIsGood) {


instead of doing this you can put a return in each if statement. For example
if (!jetderiveddatautilities::selectCollision(collision, eventSelectionBits, skipMBGapEvents)) {
return;
}

thanks, I wiil do

nzardosh · 2025-11-26T08:27:49Z

+ }
+ float jetweight = jet.eventWeight();
+ double pTHat = 10. / (std::pow(jetweight, 1.0 / pTHatExponent));
+ for (int N = 1; N < ptHadbins; N++) {


what is this pTHadbins doing?

Sorry, the purpose was to perform the JJ samples. But I have not updated this section recently. I would like to first review my data points, mainly focusing on the Data and MCD levels. I will update this process accordingly. This pTHadbins value and the related loop will also be removed.

yhou-git · 2025-11-26T12:20:54Z

Dear @yhou-git Thanks for the PR. In general I think the code is quite a bit more complicated than it needs to be in places. I have tried to highlight examples so you can go through the code and fix each time the example appears. Thanks!

Dear Nima @nzardosh, thank you very for the review and suggestions. I will go through this task, simplify it as recommended, and update the PR. I will let you know once the optimizations are completed. Thanks again.

…O2Group#13847)

yhou-git requested review from alibuild, fjonasALICE, maoyx, mfasDa, mhemmer-cern and nzardosh as code owners November 15, 2025 21:20

github-actionsBot added the pwgje label Nov 15, 2025

yhou-git marked this pull request as draft November 15, 2025 21:20

github-actionsBot changed the title ~~Jethadron branch~~[PWGJE] Jethadron branchNov 15, 2025

alibuild mentioned this pull request Nov 15, 2025
Please consider the following formatting changes to #13847 yhou-git/O2Physics#1
Merged

yhou-git added a commit to yhou-git/O2Physics that referenced this pull request Nov 15, 2025
Merge pull request#1from alibuild/alibot-cleanup-13847
d564b35
Please consider the following formatting changes to AliceO2Group#13847

alibuild mentioned this pull request Nov 17, 2025
Please consider the following formatting changes to #13847 yhou-git/O2Physics#2
Closed

Add PWGJE chargedJetHadron task
80fcbc9

yhou-git force-pushed the jethadronBranch branch from 7ea1e7c to 80fcbc9Compare November 18, 2025 09:45

Merge branch 'AliceO2Group:master' into jethadronBranch
a6917a9

yhou-git changed the title ~~[PWGJE] Jethadron branch~~[PWGJE] Add Jet-hadron correlations task into the JE frameworkNov 18, 2025

Merge branch 'AliceO2Group:master' into jethadronBranch
a77c36a

yhou-git marked this pull request as ready for review November 18, 2025 16:17

nzardosh marked this pull request as draft November 20, 2025 09:32

vkucera reviewed Nov 21, 2025
View reviewed changes

Comment threadPWGJE/Tasks/chargedJetHadron.cxx Outdated

Removed unused headers in chargedJetHadron task
8331d11

yhou-git force-pushed the jethadronBranch branch from 9812168 to 8331d11Compare November 21, 2025 17:12

Merge branch 'AliceO2Group:master' into jethadronBranch
0b7a081

nzardosh marked this pull request as ready for review November 26, 2025 08:03

nzardosh reviewed Nov 26, 2025
View reviewed changes

Updated with all requested changes applied
d7a9deb

yhou-git force-pushed the jethadronBranch branch from 0e8106f to d7a9debCompare December 3, 2025 18:53

nzardosh self-requested a review December 10, 2025 12:45

nzardosh approved these changes Dec 10, 2025
View reviewed changes

nzardosh enabled auto-merge (squash) December 10, 2025 12:45

nzardosh merged commit 2d3e00b into AliceO2Group:masterDec 10, 2025
11 of 13 checks passed

sigurdnese pushed a commit to sigurdnese/O2Physics that referenced this pull request Jan 9, 2026
[PWGJE] Add Jet-hadron correlations task into the JE framework (Alice…
a51483e
…O2Group#13847)

mapalhares pushed a commit to mapalhares/O2Physics that referenced this pull request Jan 20, 2026
[PWGJE] Add Jet-hadron correlations task into the JE framework (Alice…
0a28308
…O2Group#13847)

fcolamar pushed a commit to fcolamar/O2Physics that referenced this pull request Feb 4, 2026
[PWGJE] Add Jet-hadron correlations task into the JE framework (Alice…
99b0fac
…O2Group#13847)

karlazertova pushed a commit to karlazertova/O2Physics that referenced this pull request Feb 5, 2026
[PWGJE] Add Jet-hadron correlations task into the JE framework (Alice…
0e63d8a
…O2Group#13847)

Uh oh!

Conversation

yhou-git commented Nov 15, 2025

Uh oh!

github-actionsBot commented Nov 15, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nzardosh commented Nov 17, 2025

Uh oh!

yhou-git commented Nov 18, 2025

Uh oh!

vkucera commented Nov 18, 2025

Uh oh!

yhou-git commented Nov 18, 2025

Uh oh!

vkucera commented Nov 18, 2025

Uh oh!

nzardosh commented Nov 20, 2025

Uh oh!

yhou-git commented Nov 20, 2025

Uh oh!

Uh oh!

nzardosh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yhou-git commented Nov 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

github-actionsBot commented Nov 15, 2025•
edited
Loading