Skip to content

PWGHF: Task to separate single muons from c and b decays - #1503

Merged
vkucera merged 36 commits into
AliceO2Group:masterfrom
shreyasiacharya:master
Nov 29, 2022
Merged

PWGHF: Task to separate single muons from c and b decays #1503
vkucera merged 36 commits into
AliceO2Group:masterfrom
shreyasiacharya:master

Conversation

@shreyasiacharya

@shreyasiacharyashreyasiacharya commented Nov 21, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@shreyasiacharyashreyasiacharya changed the title Task to separate single muons from c and b decays PWGHF : Task to separate single muons from c and b decays Nov 22, 2022
@vkuceravkucera changed the title PWGHF : Task to separate single muons from c and b decays PWGHF: Task to separate single muons from c and b decays Nov 22, 2022
vkucera
vkucera requested changes Nov 22, 2022
View reviewed changes

@vkuceravkucera left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your names of file, executable, and task should match. You are now using taskHFmuCharmBeautySep, mu-charm-beauty-separation, IterateFwdTracksMuons which are completely different from each other.

Comment threadPWGHF/HFL/Tasks/taskHFmuCharmBeautySep.cxx Outdated
Comment threadPWGHF/HFL/Tasks/taskHFmuCharmBeautySep.cxx Outdated
Comment threadPWGHF/HFL/Tasks/taskHFmuCharmBeautySep.cxx Outdated
Comment threadPWGHF/HFL/Tasks/taskHFmuCharmBeautySep.cxx
Comment threadPWGHF/HFL/Tasks/taskHFmuCharmBeautySep.cxx Outdated
Comment threadPWGHF/HFL/Tasks/taskHFmuCharmBeautySep.cxx Outdated
Comment threadPWGHF/HFL/Tasks/taskHFmuCharmBeautySep.cxx Outdated
Comment threadPWGHF/HFL/Tasks/taskHFmuCharmBeautySep.cxx Outdated
vkucera
vkucera requested changes Nov 23, 2022
View reviewed changes
Comment threadPWGHF/HFL/Tasks/taskHFmuCharmBeautySep.cxx Outdated
Comment threadPWGHF/HFL/Tasks/CMakeLists.txt Outdated
Comment threadPWGHF/HFL/Tasks/taskHFmuCharmBeautySep.cxx Outdated
Comment threadPWGHF/HFL/Tasks/taskHFmuCharmBeautySep.cxx Outdated
Comment threadPWGHF/HFL/Tasks/taskHFmuCharmBeautySep.cxx Outdated
Comment threadPWGHF/HFL/Tasks/taskHFmuCharmBeautySep.cxx Outdated
vkucera
vkucera requested changes Nov 25, 2022
View reviewed changes
Comment threadPWGHF/HFL/Tasks/CMakeLists.txt Outdated
Comment threadPWGHF/HFL/Tasks/taskHFmuCharmBeautySep.cxx Outdated
Comment threadPWGHF/HFL/Tasks/taskHFmuCharmBeautySep.cxx Outdated
vkucera
vkucera requested changes Nov 28, 2022
View reviewed changes
Comment threadPWGHF/HFL/Tasks/taskMuonCharmBeautySeparation.cxx Outdated
Comment threadPWGHF/HFL/Tasks/taskMuonCharmBeautySeparation.cxx Outdated
vkucera
vkucera approved these changes Nov 29, 2022
View reviewed changes

@vkuceravkucera left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, please make a related PR in the validation framework.

@vkucera
vkucera merged commit a1c6947 into AliceO2Group:masterNov 29, 2022
ercolessi pushed a commit to ercolessi/O2Physics that referenced this pull request Jan 9, 2023
@shreyasiacharya@ercolessi
PWGHF: Add task to separate single muons from c and b decays (AliceO2…
ea9c752
…Group#1503)
GijsvWeelden pushed a commit to GijsvWeelden/O2Physics that referenced this pull request Jan 13, 2023
@shreyasiacharya@GijsvWeelden
PWGHF: Add task to separate single muons from c and b decays (AliceO2…
7c8ffe4
…Group#1503)
cimordas pushed a commit to cimordas/O2Physics that referenced this pull request Jan 20, 2023
@shreyasiacharya@cimordas
PWGHF: Add task to separate single muons from c and b decays (AliceO2…
2b7ffe8
…Group#1503)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkuceravkuceravkucera approved these changes
@alibuildalibuildAwaiting requested review from alibuildalibuild is a code owner
@ginnocenginnocenAwaiting requested review from ginnocen
@fcolamarfcolamarAwaiting requested review from fcolamarfcolamar is a code owner
@cterrevocterrevoAwaiting requested review from cterrevo
@NicoleBastidNicoleBastidAwaiting requested review from NicoleBastidNicoleBastid is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shreyasiacharya@vkucera@alibuild