Skip to content

[PWGCF] V02 analysis initial commit - #15426

Merged
jaelpark merged 7 commits into
AliceO2Group:masterfrom
MaximVirta:V02
Mar 18, 2026
Merged

[PWGCF] V02 analysis initial commit#15426
jaelpark merged 7 commits into
AliceO2Group:masterfrom
MaximVirta:V02

Conversation

@MaximVirta

@MaximVirtaMaximVirta commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

Initial commit of V02 analysis with PID

@alibuildalibuild mentioned this pull request Mar 17, 2026
Merged
@alibuild

alibuild commented Mar 17, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for fb07d71 at 2026-03-17 14:20:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/15426-slc9_x86-64/0/PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:657:104: error: unused parameter 'run' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/15426-slc9_x86-64/0/PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:493:49: error: unused parameter 'pidInd' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/15426-slc9_x86-64/0/PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:530:83: error: unused parameter 'run' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/15426-slc9_x86-64/0/PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:484:52: error: unused parameter 'vtxz' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/15426-slc9_x86-64/0/PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:484:69: error: unused parameter 'pidInd' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

vkucera
vkucera reviewed Mar 17, 2026
View reviewed changes
Comment threadPWGCF/GenericFramework/Tasks/flowGfwV02.cxx Outdated
Comment threadPWGCF/GenericFramework/Tasks/flowGfwV02.cxx
Comment on lines +195 to +198
kCharged = 0,
kPions,
kKaons,
kProtons

@vkuceravkuceraMar 17, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the meaning of the k prefix?

@MaximVirtaMaximVirtaMar 17, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the same convention as in PWGCF/TwoParticleCorrelations/Tasks/pidDiHadron.cxx

@vkuceravkuceraMar 17, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't answer the question.
Compile-time constants, including enumerations, are supposed to follow the UpperCamelCase naming convention.

@MaximVirtaMaximVirtaMar 18, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I will change this in the next iteration as this got merged.

Comment threadPWGCF/GenericFramework/Tasks/flowGfwV02.cxx Outdated
Comment threadPWGCF/GenericFramework/Tasks/flowGfwV02.cxx
Comment on lines +201 to +206
iPionUp = 0,
iKaonUp,
iProtonUp,
iPionLow,
iKaonLow,
iProtonLow

@vkuceravkuceraMar 17, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow naming conventions.

@MaximVirtaMaximVirtaMar 17, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also from PWGCF/TwoParticleCorrelations/Tasks/pidDiHadron.cxx, but "i" is used instead as an index in the arrays.

@vkuceravkuceraMar 18, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't change the fact that it violates the naming conventions.

@MaximVirtaMaximVirtaMar 18, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this one in UpperCamelCase as well?

@vkuceravkuceraMar 18, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they are enumerations like any other.

Comment threadPWGCF/GenericFramework/Tasks/flowGfwV02.cxx
@alibuildalibuild mentioned this pull request Mar 17, 2026
Merged
@MaximVirta
Merge pull request#21from alibuild/alibot-cleanup-15426
5533a3b
Please consider the following formatting changes to AliceO2Group#15426
@jaelpark
jaelpark enabled auto-merge (squash) March 18, 2026 08:45
@jaelpark
jaelpark merged commit 5b1b816 into AliceO2Group:masterMar 18, 2026
12 checks passed
@MaximVirtaMaximVirta mentioned this pull request Mar 19, 2026
Merged
scannito pushed a commit to scannito/O2Physics that referenced this pull request Mar 20, 2026
@MaximVirtaMaximVirta
@alibuild@scannito
[PWGCF] V02 analysis initial commit (AliceO2Group#15426)
7761640
Co-authored-by: MaximVirta <maxim.m.o.virta@jyu.fi>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
hyungjun-lee pushed a commit to hyungjun-lee/O2Physics that referenced this pull request Apr 15, 2026
@MaximVirtaMaximVirta
@alibuild@hyungjun-lee
[PWGCF] V02 analysis initial commit (AliceO2Group#15426)
7fa6055
Co-authored-by: MaximVirta <maxim.m.o.virta@jyu.fi>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Apr 27, 2026
@MaximVirtaMaximVirta
@alibuild@smaff92
[PWGCF] V02 analysis initial commit (AliceO2Group#15426)
7b50b52
Co-authored-by: MaximVirta <maxim.m.o.virta@jyu.fi>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
mtorresc15 pushed a commit to mtorresc15/O2Physics that referenced this pull request May 5, 2026
@MaximVirtaMaximVirta
@alibuild@mtorresc15
[PWGCF] V02 analysis initial commit (AliceO2Group#15426)
f19a9ee
Co-authored-by: MaximVirta <maxim.m.o.virta@jyu.fi>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkuceravkuceravkucera left review comments
@jaelparkjaelparkjaelpark approved these changes
@alibuildalibuildAwaiting requested review from alibuildalibuild is a code owner
@wenyaCernwenyaCernAwaiting requested review from wenyaCernwenyaCern is a code owner
@victor-gonzalezvictor-gonzalezAwaiting requested review from victor-gonzalezvictor-gonzalez is a code owner
@otonvdotonvdAwaiting requested review from otonvd
@shouqiyeshouqiyeAwaiting requested review from shouqiye

Assignees

No one assigned

Labels

pwgcf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MaximVirta@alibuild@jaelpark@vkucera