Skip to content

[PWGLF] Table producer for photonDe correlation study - #15509

Merged
maciacco merged 12 commits into
AliceO2Group:masterfrom
arvindkhuntia:master
Apr 27, 2026
Merged

[PWGLF] Table producer for photonDe correlation study#15509
maciacco merged 12 commits into
AliceO2Group:masterfrom
arvindkhuntia:master

Conversation

@arvindkhuntia

@arvindkhuntiaarvindkhuntia commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@maciacco
maciacco marked this pull request as draft March 24, 2026 18:22
@alibuild

alibuild commented Mar 24, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 9dd013d at 2026-03-24 20:10:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/15509-slc9_x86-64/0/PWGLF/TableProducer/Nuspex/photonDeuteron.cxx:20:10: fatal error: Common/DataModel/PIDResponse.h: No such file or directory
ninja: build stopped: subcommand failed.

Full log here.

@vkucera

vkucera commented Mar 24, 2026

Copy link
Copy Markdown
Collaborator

@arvindkhuntia How did you test your changes? They don't compile.

vkucera
vkucera reviewed Mar 24, 2026
View reviewed changes
Comment threadPWGLF/TableProducer/Nuspex/photonDeuteron.cxx Outdated
Comment threadPWGLF/TableProducer/Nuspex/photonDeuteron.cxx Outdated
Comment threadPWGLF/TableProducer/Nuspex/photonDeuteron.cxx Outdated
Comment threadPWGLF/TableProducer/Nuspex/CMakeLists.txt Outdated
Comment threadPWGLF/TableProducer/Nuspex/photonDeuteron.cxx Outdated
Comment threadPWGLF/TableProducer/Nuspex/photonDeuteron.cxx Outdated
Comment threadPWGLF/TableProducer/Nuspex/photonDeuteron.cxx Outdated
@github-actions

github-actionsBot commented Apr 7, 2026•
edited
Loading

Copy link
Copy Markdown

O2 linter results: ❌ 1 errors, ⚠️ 6 warnings, 🔕 0 disabled

vkucera
vkucera reviewed Apr 10, 2026
View reviewed changes
Comment threadPWGLF/DataModel/LFPhotonDeuteronTables.h Outdated
vkucera
vkucera reviewed Apr 10, 2026
View reviewed changes
Comment threadPWGLF/TableProducer/Nuspex/photonDeuteron.cxx Outdated
vkucera
vkucera reviewed Apr 10, 2026
View reviewed changes
Comment threadPWGLF/TableProducer/Nuspex/photonDeuteron.cxx Outdated
vkucera
vkucera reviewed Apr 10, 2026
View reviewed changes
Comment threadPWGLF/TableProducer/Nuspex/photonDeuteron.cxx
@vkucera
vkucera marked this pull request as ready for review April 27, 2026 15:34
@alibuild

alibuild commented Apr 27, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 97c53b5 at 2026-04-27 17:41:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Nuspex/photonDeuteron.cxx:197:38: error: unused parameter 'collision' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Nuspex/photonDeuteron.cxx:107:51: error: unused parameter 'tracks' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@maciacco
maciacco merged commit 9ca168b into AliceO2Group:masterApr 27, 2026
11 of 13 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkuceravkuceravkucera left review comments
@maciaccomaciaccomaciacco approved these changes
@alibuildalibuildAwaiting requested review from alibuildalibuild is a code owner
@omvazqueomvazqueAwaiting requested review from omvazqueomvazque is a code owner
@skundu692skundu692Awaiting requested review from skundu692skundu692 is a code owner
@mpucciompuccioAwaiting requested review from mpucciompuccio is a code owner
@fmazzascfmazzascAwaiting requested review from fmazzasc
@HorstMaHorstMaAwaiting requested review from HorstMaHorstMa is a code owner
@gbencedigbencediAwaiting requested review from gbencedigbencedi is a code owner
@abmodakabmodakAwaiting requested review from abmodakabmodak is a code owner
@dmallick2dmallick2Awaiting requested review from dmallick2dmallick2 is a code owner
@smaff92smaff92Awaiting requested review from smaff92smaff92 is a code owner
@ercolessiercolessiAwaiting requested review from ercolessiercolessi is a code owner
@romainschotterromainschotterAwaiting requested review from romainschotterromainschotter is a code owner
@prottayCMTprottayCMTAwaiting requested review from prottayCMTprottayCMT is a code owner
@lhusovalhusovaAwaiting requested review from lhusovalhusova is a code owner
+1 more reviewer
@arvindiiti1992arvindiiti1992arvindiiti1992 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

datamodelpwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@arvindkhuntia@alibuild@vkucera@maciacco@arvindiiti1992@Arvindiiti