Skip to content

[PWGEM] New Dielectron analysis type: Bootstrapping for v2. - #15576

Merged
dsekihat merged 11 commits into
AliceO2Group:masterfrom
omassen:EMDevBranch
Apr 2, 2026
Merged

[PWGEM] New Dielectron analysis type: Bootstrapping for v2.#15576
dsekihat merged 11 commits into
AliceO2Group:masterfrom
omassen:EMDevBranch

Conversation

@omassen

@omassenomassen commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

Introducing a new analysis type for performing poisson bootstrapping for the dielectron v2 analysis. This includes:

  • changes to the EventHistorgams.h to introduce new histograms per bootstrapping sample and a method of filling them
  • Small change to PairUtils.h to be able to choose the new analysis type.
  • In Dilepton.h implementing the new analysis. Existing code could for the main part remain untouched. The only change to the existing code is the introduction of a new argument for the FillPairInfo function, needed to parse the bootstrap weights.

@github-actionsgithub-actionsBot changed the title New Dielectron analysis type: Bootstrapping for v2.[PWGEM] New Dielectron analysis type: Bootstrapping for v2.Mar 30, 2026
@alibuildalibuild mentioned this pull request Mar 30, 2026
Merged
@omassen
omassen marked this pull request as ready for review March 31, 2026 13:23
@omassen
omassen marked this pull request as draft April 2, 2026 07:41
@omassen

omassen commented Apr 2, 2026

Copy link
Copy Markdown
ContributorAuthor

Working on resolving new merge conflicts due to PR #15385

@github-actions

github-actionsBot commented Apr 2, 2026•
edited
Loading

Copy link
Copy Markdown

O2 linter results: ❌ 136 errors, ⚠️ 250 warnings, 🔕 0 disabled

@alibuildalibuild mentioned this pull request Apr 2, 2026
Merged
@dsekihat

dsekihat commented Apr 2, 2026

Copy link
Copy Markdown
Collaborator

Hi Olaf, It looks good from my side.

@omassen
Merge pull request#11from alibuild/alibot-cleanup-15576
4fa3021
Please consider the following formatting changes to AliceO2Group#15576
@omassen
omassen marked this pull request as ready for review April 2, 2026 11:22
@omassen

omassen commented Apr 2, 2026

Copy link
Copy Markdown
ContributorAuthor

Merge conflicts have been resolved, should be good to go now.

@dsekihat

dsekihat commented Apr 2, 2026

Copy link
Copy Markdown
Collaborator

It is not required by the system, it would be nicer if you can solve the test build build/O2Physics/o2/macOS.

vkucera
vkucera reviewed Apr 2, 2026
View reviewed changes
Comment threadPWGEM/Dilepton/Utils/EventHistograms.h Outdated
@omassen

omassen commented Apr 2, 2026•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

I have done some checks but the issues with this test build were already there for the previous PR #15385. I have tried to take a look but to me it is not clear how to solve this. I am also not able to replicate these issues locally, as I have MacOS-arm.

@vkucera

vkucera commented Apr 2, 2026

Copy link
Copy Markdown
Collaborator

I have done some checks but the issues with this test build were already there for the previous PR #15385. I have tried to take a look but to me it is not clear how to solve this. I am also not able to replicate these issues locally, as I have MacOS-arm.

It's reported by O2 linter, Clang-Tidy, and Clangd. It doesn't matter what OS you have.

@omassen@vkucera
Update PWGEM/Dilepton/Utils/EventHistograms.h
6d41a0e
Co-authored-by: Vít Kučera <26327373+vkucera@users.noreply.github.com>
@vkucera

vkucera commented Apr 2, 2026

Copy link
Copy Markdown
Collaborator

I have done some checks but the issues with this test build were already there for the previous PR #15385. I have tried to take a look but to me it is not clear how to solve this. I am also not able to replicate these issues locally, as I have MacOS-arm.

It's reported by O2 linter, Clang-Tidy, and Clangd. It doesn't matter what OS you have.

Sorry, I misunderstood what the comment was referring to.

@dsekihat
dsekihat merged commit a390108 into AliceO2Group:masterApr 2, 2026
11 of 13 checks passed
hyungjun-lee pushed a commit to hyungjun-lee/O2Physics that referenced this pull request Apr 15, 2026
@omassen@alibuild
@vkucera@hyungjun-lee
[PWGEM] New Dielectron analysis type: Bootstrapping for v2. (AliceO2G…
9d1013b
…roup#15576)
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: Vít Kučera <26327373+vkucera@users.noreply.github.com>
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Apr 27, 2026
@omassen@alibuild
@vkucera@smaff92
[PWGEM] New Dielectron analysis type: Bootstrapping for v2. (AliceO2G…
3747df5
…roup#15576)
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: Vít Kučera <26327373+vkucera@users.noreply.github.com>
mtorresc15 pushed a commit to mtorresc15/O2Physics that referenced this pull request May 5, 2026
@omassen@alibuild
@vkucera@mtorresc15
[PWGEM] New Dielectron analysis type: Bootstrapping for v2. (AliceO2G…
0017e94
…roup#15576)
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: Vít Kučera <26327373+vkucera@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkuceravkuceravkucera left review comments
@dsekihatdsekihatdsekihat approved these changes
@alibuildalibuildAwaiting requested review from alibuildalibuild is a code owner
@mikesasmikesasAwaiting requested review from mikesasmikesas is a code owner
@rbailhacrbailhacAwaiting requested review from rbailhacrbailhac is a code owner
@ivorobyeivorobyeAwaiting requested review from ivorobye
@feisenhufeisenhuAwaiting requested review from feisenhufeisenhu is a code owner
@hscheidhscheidAwaiting requested review from hscheidhscheid is a code owner
@jokonigjokonigAwaiting requested review from jokonigjokonig is a code owner

Assignees

No one assigned

Labels

pwgem

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@omassen@dsekihat@vkucera@alibuild