Skip to content

Collision covariance matrix: converter with fix - #1579

Merged
ddobrigk merged 8 commits into
AliceO2Group:masterfrom
ddobrigk:collcovfix
Dec 9, 2022
Merged

Collision covariance matrix: converter with fix#1579
ddobrigk merged 8 commits into
AliceO2Group:masterfrom
ddobrigk:collcovfix

Conversation

@ddobrigk

Copy link
Copy Markdown
Collaborator

@ddobrigk
ddobrigk marked this pull request as draft December 4, 2022 14:01
@ddobrigk
ddobrigk marked this pull request as ready for review December 9, 2022 08:37
@ddobrigk

ddobrigk commented Dec 9, 2022

Copy link
Copy Markdown
CollaboratorAuthor

Since AliceO2Group/AliceO2#10424 is ready, I think this can be merged now - correct? I will wait until ~end of day and then try to self-approve (via auto-merge)...

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for e040e93 at 2022-12-09 09:57:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/1579-slc7_x86-64/0/Common/TableProducer/collisionConverter.cxx:20:17: error: 'Collisions_001' is not a member of 'o2::aod'; did you mean 'Collisions'?
/sw/SOURCES/O2Physics/1579-slc7_x86-64/0/Common/TableProducer/collisionConverter.cxx:20:31: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/1579-slc7_x86-64/0/Common/TableProducer/collisionConverter.cxx:22:21: error: 'o2::aod::Collisions_000' has not been declared
/sw/SOURCES/O2Physics/1579-slc7_x86-64/0/Common/TableProducer/collisionConverter.cxx:22:46: error: expected ',' or '...' before 'const'
/sw/SOURCES/O2Physics/1579-slc7_x86-64/0/Common/TableProducer/collisionConverter.cxx:26:7: error: 'collision' was not declared in this scope; did you mean 'o2::aod::collision'?
/sw/SOURCES/O2Physics/1579-slc7_x86-64/0/Common/TableProducer/collisionConverter.cxx:35:62: error: expression cannot be used as a function
/sw/slc7_x86-64/O2/nightly-20221208-local1/include/Framework/ASoA.h:183:26: error: 'decayed' {aka 'int'} is not a class, struct, or union type
/sw/slc7_x86-64/O2/nightly-20221208-local1/include/Framework/ASoA.h:184:51: error: 'decayed' {aka 'int'} is not a class, struct, or union type
/sw/slc7_x86-64/O2/nightly-20221208-local1/include/Framework/AnalysisTask.h:184:55: error: too many braces around scalar initializer for type 'int'
/sw/slc7_x86-64/O2/nightly-20221208-local1/include/Framework/AnalysisTask.h:294:28: error: static assertion failed: Single argument of process() should be a table-like or an iterator
/sw/slc7_x86-64/O2/nightly-20221208-local1/include/Framework/AnalysisTask.h:124:24: error: static assertion failed: Argument to process needs to be a reference (&).
ninja: build stopped: subcommand failed.

Full log here.

@ddobrigk

Copy link
Copy Markdown
CollaboratorAuthor

Ah, no - we need a new O2 version to build against...

@jgrosseo

Copy link
Copy Markdown
Contributor

This should have happened with the nightly automatically.
@ktf@TimoWilken was the tag not moved this morning to the nightly as usual?

Comment threadCommon/TableProducer/collisionConverter.cxx Outdated
@TimoWilken

Copy link
Copy Markdown
Contributor

@jgrosseo it did, at 10:09; the build/O2Physics/o2 check finished at 11:03 and picked up today's nightly (nightly-20221109) according to the build log.

@jgrosseo

Copy link
Copy Markdown
Contributor

Ah yes, the failure is from before and now it is green

@ddobrigk
ddobrigk merged commit 3fc9ea0 into AliceO2Group:masterDec 9, 2022
MrWhatZitToYaa pushed a commit to MrWhatZitToYaa/O2Physics that referenced this pull request Dec 20, 2022
* Create collision converter task
* Add collision-converter to CMakeLists
* Please consider the following formatting changes
* Update CMakeLists.txt
* move loop to process function
* Please consider the following formatting changes
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
@ddobrigk
ddobrigk deleted the collcovfix branch December 22, 2022 09:41
ercolessi pushed a commit to ercolessi/O2Physics that referenced this pull request Jan 9, 2023
* Create collision converter task
* Add collision-converter to CMakeLists
* Please consider the following formatting changes
* Update CMakeLists.txt
* move loop to process function
* Please consider the following formatting changes
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
GijsvWeelden pushed a commit to GijsvWeelden/O2Physics that referenced this pull request Jan 13, 2023
* Create collision converter task
* Add collision-converter to CMakeLists
* Please consider the following formatting changes
* Update CMakeLists.txt
* move loop to process function
* Please consider the following formatting changes
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
cimordas pushed a commit to cimordas/O2Physics that referenced this pull request Jan 20, 2023
* Create collision converter task
* Add collision-converter to CMakeLists
* Please consider the following formatting changes
* Update CMakeLists.txt
* move loop to process function
* Please consider the following formatting changes
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@ddobrigk@alibuild@jgrosseo@TimoWilken