Skip to content

[PWGCF] Add circle PID cut - #15810

Merged
wenyaCern merged 10 commits into
AliceO2Group:masterfrom
huinaibing:master
Apr 16, 2026
Merged

[PWGCF] Add circle PID cut#15810
wenyaCern merged 10 commits into
AliceO2Group:masterfrom
huinaibing:master

Conversation

@huinaibing

@huinaibinghuinaibing commented Apr 16, 2026

Copy link
Copy Markdown
Contributor
  • add a circle PID cut
  • fix a bug in PID graph filling

@github-actions

github-actionsBot commented Apr 16, 2026•
edited
Loading

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 7 warnings, 🔕 0 disabled

vkucera
vkucera requested changes Apr 16, 2026
View reviewed changes

@vkuceravkucera left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't revert the include fixes.

@alibuildalibuild mentioned this pull request Apr 16, 2026
Merged
@huinaibing
Merge pull request#7from alibuild/alibot-cleanup-15810
eda1d67
Please consider the following formatting changes to AliceO2Group#15810
@huinaibing

huinaibing commented Apr 16, 2026

Copy link
Copy Markdown
ContributorAuthor

Don't revert the include fixes.

Thank you for your comment, Professor. I was using pre-commit, and it modified my include path automatically, and I didn't notice it. Now I have fixed it.

@vkucera

vkucera commented Apr 16, 2026

Copy link
Copy Markdown
Collaborator

Don't revert the include fixes.

Thank you for your comment, Professor. I was using pre-commit, and it modified my include path automatically, and I didn't notice it. Now I have fixed it.

pre-commit does not change your list of includes. You just did not rebase on upstream properly.

vkucera
vkucera previously approved these changes Apr 16, 2026
View reviewed changes
@huinaibing

huinaibing commented Apr 16, 2026

Copy link
Copy Markdown
ContributorAuthor

Don't revert the include fixes.

Thank you for your comment, Professor. I was using pre-commit, and it modified my include path automatically, and I didn't notice it. Now I have fixed it.

pre-commit does not change your list of includes. You just did not rebase on upstream properly.

Thanks for the correction, Professor. I just noticed there was a header file change a few hours ago. I’ve added the header I need（If I don't add it, megalinter throws an error） while keeping the original headers intact.

vkucera
vkucera reviewed Apr 16, 2026
View reviewed changes
Comment threadPWGCF/Flow/Tasks/pidFlowPtCorr.cxx
Comment on lines +892 to +898
if (pt > ptMin && pt < ptMax) {
// Circular cut: sqrt(TPC^2 + TOF^2) < 2
isPion = (tpcNsigma * tpcNsigma + tofNsigma * tofNsigma) < circleCutOpts.cfgCircleCutSigmaSquarePi.value;
} else {
// Fallback: TPC only cut
isPion = std::fabs(tpcNsigma) < circleCutOpts.cfgCircleCutTPCPi.value;
}

@vkuceravkuceraApr 16, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this not just be a function or lambda? You repeat the same thing for each species.

vkucera
vkucera reviewed Apr 16, 2026
View reviewed changes
Comment threadPWGCF/Flow/Tasks/pidFlowPtCorr.cxx
vkucera
vkucera reviewed Apr 16, 2026
View reviewed changes
Comment threadPWGCF/Flow/Tasks/pidFlowPtCorr.cxx Outdated
vkucera
vkucera reviewed Apr 16, 2026
View reviewed changes
Comment threadPWGCF/Flow/Tasks/pidFlowPtCorr.cxx Outdated
vkucera
vkucera reviewed Apr 16, 2026
View reviewed changes
Comment threadPWGCF/Flow/Tasks/pidFlowPtCorr.cxx Outdated
vkucera
vkucera reviewed Apr 16, 2026
View reviewed changes
Comment threadPWGCF/Flow/Tasks/pidFlowPtCorr.cxx Outdated
@alibuildalibuild mentioned this pull request Apr 16, 2026
Merged
@huinaibing
Merge pull request#8from alibuild/alibot-cleanup-15810
dc1daa8
Please consider the following formatting changes to AliceO2Group#15810
@wenyaCern
wenyaCern merged commit 7bd42ee into AliceO2Group:masterApr 16, 2026
13 of 14 checks passed
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Apr 27, 2026
@huinaibing@alibuild@smaff92
[PWGCF] Add circle PID cut (AliceO2Group#15810)
fb76563
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkuceravkuceravkucera left review comments
@wenyaCernwenyaCernwenyaCern approved these changes
@alibuildalibuildAwaiting requested review from alibuildalibuild is a code owner
@jaelparkjaelparkAwaiting requested review from jaelparkjaelpark is a code owner
@victor-gonzalezvictor-gonzalezAwaiting requested review from victor-gonzalezvictor-gonzalez is a code owner
@otonvdotonvdAwaiting requested review from otonvd
@shouqiyeshouqiyeAwaiting requested review from shouqiye

Assignees

No one assigned

Labels

pwgcf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@huinaibing@vkucera@wenyaCern@alibuild