Uh oh!
There was an error while loading. Please reload this page.
[PWGLF] Add event selection flag to the he3hadmult table - #17319
[PWGLF] Add event selection flag to the he3hadmult table#17319GiorgioAlbertoLucia wants to merge 3 commits into
Conversation
O2 linter results: ❌ 22 errors, |
alibuild
commented
Aug 5, 2026
Error while checking build/O2Physics/code-check for 036f374 at 2026-08-08 03:01: Full log here. |
alibuild
commented
Aug 5, 2026
There was a problem hiding this comment.
@GiorgioAlbertoLucia Please fix the PR title.
It's is wrong and very confusing. It's a statement and it's not clear whether it's the reason of the PR or its outcome. Plus "now'" is meaningless in this context. It doesn't convey any information about the scope of the changes either. Please read the references in the contribution guidelines and learn to formulate a proper commit message.
GiorgioAlbertoLucia
commented
Aug 5, 2026
@vkucera the PR title has been fixed. I removed the "now" and it is now not a statement, but the content is the same. The only goal of the pr is to store event selection flags in the output table, specifically, in the multiplicity table. If you are still not convinced, please feel free to leave a suggestion |
vkucera
commented
Aug 5, 2026
Thanks @GiorgioAlbertoLucia , but the title is still wrong and still does not follow the guidelines. The multiplicity table is produced by |
GiorgioAlbertoLucia
commented
Aug 5, 2026
@vkucera I understand the confusion. The title referred to the multiplicity table pertinent to the analysis task. The initial comment was unclear about what the issue was. Hopefully, now the title is clearer. |
vkucera
commented
Aug 5, 2026
Thanks. Please use the imperative mood in your future PRs (as instructed in the guidelines). |
No description provided.