Uh oh!
There was an error while loading. Please reload this page.
Fix cascade issues in analysis - #180
Merged
Merged
Conversation
ddobrigk
requested review from
a team, iarsene, jgrosseo and ktf
as code ownersOctober 12, 2021 19:01
aalkin
reviewed
Oct 13, 2021
Uh oh!
There was an error while loading. Please reload this page.
iarsene
commented
Oct 13, 2021
Collaborator
The PR is fine with me, but the o2 test crashed and it seems genuine. |
aalkin
reviewed
Oct 13, 2021
| //Configurables | ||
| Configurable<double> d_bz{"d_bz", -5.0, "bz field"}; | ||
| Configurable<bool> d_UseAbsDCA{"d_UseAbsDCA", kTRUE, "Use Abs DCAs"}; |
aalkin
commented
Oct 13, 2021
Member
The warning (that would actually be an error when compiling with clang) is unrelated and is fixed by #182. |
iarsene
commented
Oct 13, 2021
Collaborator
The test fails due to an error, not a warning, and its at the line where you two were discussing. I think the kTRUE might be the problem. I also think one should use "true". |
| @@ -91,104 +90,99 @@ struct cascadeprefilterpairs { | |||
| Configurable<bool> tpcrefit{"tpcrefit", 1, "demand TPC refit"}; | |||
ddobrigk
commented
Oct 13, 2021
CollaboratorAuthor
Okay, I think everything has been taken care of - right? Please let me know if there's any other action required! Thanks! |
jgrosseo
requested changes
Oct 13, 2021
jgrosseo
left a comment
Contributor
There was a problem hiding this comment.
Everything fine but waiting for refiltering of data.
jgrosseo
approved these changes
Oct 18, 2021
ddobrigk added a commit
that referenced
this pull request
Oct 27, 2023
* Add example derived data skeletons * derived data example fixes * Please consider the following formatting changes (#180) --------- Co-authored-by: David Dobrigkeit Chinellato <david.dobrigkeit.chinellato.cern.ch> Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
christianreckziegel pushed a commit
to christianreckziegel/O2Physics
that referenced
this pull request
Nov 9, 2023
* Add example derived data skeletons * derived data example fixes * Please consider the following formatting changes (AliceO2Group#180) --------- Co-authored-by: David Dobrigkeit Chinellato <david.dobrigkeit.chinellato.cern.ch> Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
chengtt0406 pushed a commit
to chengtt0406/O2Physics
that referenced
this pull request
Dec 6, 2023
* Add example derived data skeletons * derived data example fixes * Please consider the following formatting changes (AliceO2Group#180) --------- Co-authored-by: David Dobrigkeit Chinellato <david.dobrigkeit.chinellato.cern.ch> Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see https://alice.its.cern.ch/jira/browse/O2-2635