Skip to content

PWGHF: adapt toXiPi tasks for ambig tracks and PV refit, use TrackParCov and minor changes - #2310

Merged
vkucera merged 24 commits into
AliceO2Group:masterfrom
ZFederica:working
Apr 4, 2023
Merged

PWGHF: adapt toXiPi tasks for ambig tracks and PV refit, use TrackParCov and minor changes#2310
vkucera merged 24 commits into
AliceO2Group:masterfrom
ZFederica:working

Conversation

@ZFederica

@ZFedericaZFederica commented Apr 1, 2023

Copy link
Copy Markdown
Contributor
  • implement changes for ambiguous tracks
  • implement changes for PV refit
  • switch to TrackParCov to create tracks
  • add dcaZ info
  • fix event counter

@alibuild

alibuild commented Apr 1, 2023

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 9a4809f at 2023-04-01 19:23:

No log files found

Full log here.

vkucera
vkucera requested changes Apr 3, 2023
View reviewed changes
Comment threadPWGHF/DataModel/CandidateReconstructionTables.h Outdated
Comment threadPWGHF/TableProducer/candidateCreatorToXiPi.cxx Outdated
Comment threadPWGHF/TableProducer/candidateCreatorToXiPi.cxx Outdated
@vkucera

vkucera commented Apr 4, 2023

Copy link
Copy Markdown
Collaborator

Thanks @ZFederica for the fixes. Please make the PR title more descriptive. Now one cannot tell from the title what changes the PR includes.

@ZFedericaZFederica changed the title PWGHF: update toXiPi tasksPWGHF: adapt toXiPi tasks for ambig tracks and PV refit, use TrackParCov and minor changesApr 4, 2023
@ZFederica

ZFederica commented Apr 4, 2023

Copy link
Copy Markdown
ContributorAuthor

@vkucera title changed

vkucera
vkucera requested changes Apr 4, 2023
View reviewed changes

@vkuceravkucera left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some leftovers

Comment threadPWGHF/DataModel/CandidateReconstructionTables.h Outdated
@ZFederica@vkucera
Update PWGHF/DataModel/CandidateReconstructionTables.h
98d4f3a
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
@vkucera
vkucera enabled auto-merge (squash) April 4, 2023 16:11
@vkucera
vkucera merged commit b76c71d into AliceO2Group:masterApr 4, 2023
AlexBigO pushed a commit to AlexBigO/O2Physics that referenced this pull request Apr 21, 2023
@ZFedericaAlexandre Bigot
PWGHF: Adapt toXiPi tasks for ambig tracks and PV refit, use TrackPar…
ff04e28
…Cov and minor changes (AliceO2Group#2310)
@ZFederica
ZFederica deleted the working branch April 25, 2023 08:57
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkuceravkuceravkucera approved these changes
@alibuildalibuildAwaiting requested review from alibuildalibuild is a code owner
@ginnocenginnocenAwaiting requested review from ginnocen
@fcolamarfcolamarAwaiting requested review from fcolamarfcolamar is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ZFederica@alibuild@vkucera