Skip to content

Add DCAz histograms - #248

Merged
jgrosseo merged 8 commits into
AliceO2Group:masterfrom
mfaggin:mfaggin_PRtoUpstream_ImpParTask
Nov 9, 2021
Merged

Add DCAz histograms#248
jgrosseo merged 8 commits into
AliceO2Group:masterfrom
mfaggin:mfaggin_PRtoUpstream_ImpParTask

Conversation

@mfaggin

@mfagginmfaggin commented Nov 4, 2021

Copy link
Copy Markdown
Collaborator
  • doMC flag set to false by default, to be able to run on data (no PROCESS_SWITCH implemented yet)
  • DCAz distributions added
  • for MC version of the task, propagation toward the MC vertex added (dirty solution)

@mfaggin
mfaggin requested review from a team, alibuild, iarsene, jgrosseo and ktf as code ownersNovember 4, 2021 11:04
@mfagginmfaggin closed this Nov 4, 2021
@mfagginmfaggin reopened this Nov 4, 2021
@mfagginmfaggin closed this Nov 4, 2021
@mfagginmfaggin reopened this Nov 4, 2021
@mfaggin
mfaggin marked this pull request as draft November 4, 2021 11:09
@mfaggin

mfaggin commented Nov 4, 2021

Copy link
Copy Markdown
CollaboratorAuthor

@jgrosseo I inserted the possibility to evaluate also the DCAz component. In addition, I added some other feature for the MC, even if still as "dirty solutions". Nevertheless, we would ask to approve this code to be ready to process the async reconstructed data for the pilot run. The plan is to clean the code and merge it with PWGPP/Tasks/qaEventTrack.cxx.cxx in collaboration with @mario-krueger .

@victor-gonzalez

victor-gonzalez commented Nov 4, 2021•
edited
Loading

Copy link
Copy Markdown
Collaborator

Be aware your code will only run locally and having the proper files in the cwd
I would suggest to implement what is in the latest version of #187
Otherwise I guess you will not be able to test it in hyperloop

Ok!
I saw you only run on data
So you will not have problems for running it on hyperloop
Sorry about the noise

@mfaggin

mfaggin commented Nov 4, 2021

Copy link
Copy Markdown
CollaboratorAuthor

Be aware your code will only run locally and having the proper files in the cwd I would suggest to implement what is in the latest version of #187 Otherwise I guess you will not be able to test it in hyperloop

Ok! I saw you only run on data So you will not have problems for running it on hyperloop Sorry about the noise

Indeed by default I only run on data. No problem at all, thanks for your comment!

@mfaggin

mfaggin commented Nov 8, 2021

Copy link
Copy Markdown
CollaboratorAuthor

@jgrosseo I have just implemented the possibility to configure the binning and range of the impact parameter axis at runtime, just for flexibility.

mario-krueger
mario-krueger reviewed Nov 8, 2021
View reviewed changes
Comment threadPWGPP/Tasks/qaImpPar.cxx Outdated
@mfaggin

mfaggin commented Nov 8, 2021

Copy link
Copy Markdown
CollaboratorAuthor

Thanks a lot @mario-krueger , I followed your suggestion. It is implemented in the last commit.

@mfaggin

mfaggin commented Nov 9, 2021

Copy link
Copy Markdown
CollaboratorAuthor

@jgrosseo do you think it is ok to go on?

@jgrosseo
jgrosseo marked this pull request as ready for review November 9, 2021 08:34
@jgrosseo
jgrosseo enabled auto-merge (squash) November 9, 2021 08:34
@jgrosseo
jgrosseo merged commit ffc0893 into AliceO2Group:masterNov 9, 2021
@mfaggin
mfaggin deleted the mfaggin_PRtoUpstream_ImpParTask branch November 9, 2021 13:03
AnnalenaKa pushed a commit to AnnalenaKa/O2Physics that referenced this pull request Nov 10, 2021
@mfagginMattia@AnnalenaKa
Add DCAz histograms (AliceO2Group#248)
c779ab2
* Trial of propagation to MC PV (and DCAz also)
* Add DCAz for data and switch MC execution off by default
* Pairing trackextention.cxx stuff with upstream/master
* Add configurable axis for impact parameter
* Fix Clang format
* Use ConfigurableAxis for impact parameter binning
Co-authored-by: Mattia <mfaggin@cern.ch>
ddobrigk added a commit that referenced this pull request Feb 28, 2024
@ddobrigk@alibuild
Common: run selection + cent dep tests (#4907)
36b41a1
* Common: run selection for QA of slim-der
* Please consider the following formatting changes (#248)
* Extra debug features
---------
Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mario-kruegermario-kruegermario-krueger left review comments
@jgrosseojgrosseojgrosseo approved these changes
@alibuildalibuildAwaiting requested review from alibuildalibuild is a code owner
@iarseneiarseneAwaiting requested review from iarseneiarsene is a code owner
@ktfktfAwaiting requested review from ktfktf is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mfaggin@victor-gonzalez@jgrosseo@mario-krueger