Skip to content

PWGHF: Add KFParticle to D0 creator - #3046

Merged
vkucera merged 45 commits into
AliceO2Group:masterfrom
lupengzhong:master
Oct 4, 2023
Merged

PWGHF: Add KFParticle to D0 creator#3046
vkucera merged 45 commits into
AliceO2Group:masterfrom
lupengzhong:master

Conversation

@lupengzhong

@lupengzhonglupengzhong commented Jul 12, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@vkucera
vkucera marked this pull request as draft July 12, 2023 12:32
vkucera
vkucera requested changes Aug 14, 2023
View reviewed changes
Comment threadPWGHF/D2H/Tasks/taskD0.cxx Outdated
Comment threadPWGHF/DataModel/CandidateReconstructionTables.h Outdated
Comment threadPWGHF/TableProducer/CMakeLists.txt Outdated
Comment threadPWGHF/TableProducer/candidateCreator2Prong.cxx Outdated
Comment threadPWGHF/TableProducer/candidateCreator2Prong.cxx
Comment threadPWGHF/TableProducer/treeCreatorD0ToKPi.cxx Outdated
Comment threadPWGHF/TableProducer/treeCreatorD0ToKPi.cxx Outdated
Comment threadPWGHF/D2H/Tasks/taskD0.cxx Outdated
Comment threadPWGHF/D2H/Tasks/taskD0.cxx Outdated
Comment threadPWGHF/D2H/Tasks/taskD0.cxx Outdated
@vkucera

vkucera commented Aug 16, 2023

Copy link
Copy Markdown
Collaborator

@lupengzhong , please do not mark the comments as resolved. I have to go through them and check how they have been addressed.

@lupengzhong

lupengzhong commented Aug 16, 2023

Copy link
Copy Markdown
ContributorAuthor

Hi @vkucera, thanks for your comments, I think I implemented all of them (sorry for putting them as resolved already, I wasn't aware, I put 👍 now). Please have another look when you have time, and let me know if you have more comments.

@lupengzhong

lupengzhong commented Aug 29, 2023

Copy link
Copy Markdown
ContributorAuthor

Hi @vkucera, this is just a reminder, Are there any updates or comments on this PR?

@lupengzhong

lupengzhong commented Oct 1, 2023

Copy link
Copy Markdown
ContributorAuthor

Hi @mfaggin and @vkucera,

Thanks a lot for the comments and suggestions. I updated the PR accordingly and put the thumb up.
Please have a further look.

Thanks a lot!
Pengzhong

@mfaggin

mfaggin commented Oct 2, 2023

Copy link
Copy Markdown
Collaborator

Hi @mfaggin and @vkucera,

Thanks a lot for the comments and suggestions. I updated the PR accordingly and put the thumb up. Please have a further look.

Thanks a lot! Pengzhong

thank you, all fine for me

@vkucera

vkucera commented Oct 4, 2023

Copy link
Copy Markdown
Collaborator

Thanks @lupengzhong for the update and @mfaggin for the review.
I'm opening the PR for review.

@vkucera
vkucera marked this pull request as ready for review October 4, 2023 07:35
adubla
adubla previously approved these changes Oct 4, 2023
View reviewed changes
mfaggin
mfaggin previously approved these changes Oct 4, 2023
View reviewed changes
@vkucera

vkucera commented Oct 4, 2023

Copy link
Copy Markdown
Collaborator

@lupengzhong please remove the unused variables reported in the build log.

@lupengzhong
lupengzhong dismissed stale reviews from mfaggin and adubla via 4ea01a5October 4, 2023 08:42
@lupengzhong

lupengzhong commented Oct 4, 2023

Copy link
Copy Markdown
ContributorAuthor

Thanks @vkucera, I removed the unused trackParVarPos1 and trackParVarNeg1 in the runCreator2ProngWithKFParticle

@vkuceravkucera mentioned this pull request Oct 4, 2023
Merged
@vkucera
vkucera merged commit 0e6178a into AliceO2Group:masterOct 4, 2023
hahassan7 pushed a commit to hahassan7/O2Physics that referenced this pull request Oct 6, 2023
@lupengzhong@hahassan7
PWGHF: Add KFParticle to D0 creator (AliceO2Group#3046)
694e299
hahassan7 pushed a commit to hahassan7/O2Physics that referenced this pull request Oct 7, 2023
@lupengzhong@hahassan7
PWGHF: Add KFParticle to D0 creator (AliceO2Group#3046)
09e20c5
samrangy pushed a commit to samrangy/O2Physics that referenced this pull request Oct 11, 2023
@lupengzhong@samrangy
PWGHF: Add KFParticle to D0 creator (AliceO2Group#3046)
6cdd7cc
zconesa pushed a commit to zconesa/O2Physics that referenced this pull request Oct 27, 2023
@lupengzhong@zconesa
PWGHF: Add KFParticle to D0 creator (AliceO2Group#3046)
76f72c2
chengtt0406 pushed a commit to chengtt0406/O2Physics that referenced this pull request Dec 6, 2023
@lupengzhong@chengtt0406
PWGHF: Add KFParticle to D0 creator (AliceO2Group#3046)
e79f11c
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkuceravkuceravkucera approved these changes
@mfagginmfagginmfaggin left review comments
@alibuildalibuildAwaiting requested review from alibuildalibuild is a code owner
@ginnocenginnocenAwaiting requested review from ginnocen
@fcolamarfcolamarAwaiting requested review from fcolamarfcolamar is a code owner
@fgrosafgrosaAwaiting requested review from fgrosafgrosa is a code owner
@fcatalan92fcatalan92Awaiting requested review from fcatalan92fcatalan92 is a code owner
@mmazzillimmazzilliAwaiting requested review from mmazzillimmazzilli is a code owner
@deepathomsdeepathomsAwaiting requested review from deepathomsdeepathoms is a code owner
@nzardoshnzardoshAwaiting requested review from nzardosh
@NicoleBastidNicoleBastidAwaiting requested review from NicoleBastidNicoleBastid is a code owner
@gtaillepiedgtaillepiedAwaiting requested review from gtaillepied
+1 more reviewer
@adublaadublaadubla approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lupengzhong@vkucera@mfaggin@adubla@mpuccio@chiarazampolli