Skip to content

PWG-LF: cascqaanalysis task update#3197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
njacazio merged 21 commits into from
Jul 27, 2023
Merged

PWG-LF: cascqaanalysis task update #3197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
bbd9783
HistogramsForSignalLossCorrection
nepeivodaRS Jul 11, 2023
3ec21a2
Please consider the following formatting changes
alibuild Jul 11, 2023
b9f44bc
Merge pull request #9 from alibuild/alibot-cleanup-3038
nepeivodaRS Jul 11, 2023
3026eef
swap axes
nepeivodaRS Jul 11, 2023
95e8e2d
Merge branch 'cascadeSignalLoss' of https://github.com/nepeivodaRS/O2…
nepeivodaRS Jul 11, 2023
6c7ef75
Please consider the following formatting changes
alibuild Jul 11, 2023
b35d5d9
Merge pull request #10 from alibuild/alibot-cleanup-3038
nepeivodaRS Jul 11, 2023
6c3cc3a
Comments + Names changes
nepeivodaRS Jul 12, 2023
4bac51e
Please consider the following formatting changes
alibuild Jul 12, 2023
bc9453f
Merge pull request #11 from alibuild/alibot-cleanup-3038
nepeivodaRS Jul 12, 2023
2ad175b
signal/event loss histograms
nepeivodaRS Jul 13, 2023
27fa7a6
finer FT0M binning
nepeivodaRS Jul 16, 2023
d1267e7
Merge branch 'master' into cascadeSignalLoss
nepeivodaRS Jul 16, 2023
ca8296a
Merge branch 'AliceO2Group:master' into cascadeSignalLoss
nepeivodaRS Jul 24, 2023
001e5bf
evType For Nassoc Histo
nepeivodaRS Jul 24, 2023
523bbcb
cascqaanalysis update
nepeivodaRS Jul 27, 2023
b4589d6
Merge branch 'master' into cascadeSignalLoss
nepeivodaRS Jul 27, 2023
f1cb4dc
Please consider the following formatting changes
alibuild Jul 27, 2023
440a393
Merge pull request #12 from alibuild/alibot-cleanup-3197
nepeivodaRS Jul 27, 2023
41bbb12
change number of bins
nepeivodaRS Jul 27, 2023
685c90b
CascadeSelectionSummary number of bins fix
nepeivodaRS Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions PWGLF/DataModel/cascqaanalysis.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,7 +42,6 @@ enum EvFlags : uint8_t {
EvINELgt1 = 0x4 // Event with at least 2 PV contributors from the |eta| < 1
};

DECLARE_SOA_INDEX_COLUMN(Collision, collision);
DECLARE_SOA_COLUMN(CollisionZ, zcoll, float);
DECLARE_SOA_COLUMN(MultFT0M, multFT0M, float);
DECLARE_SOA_COLUMN(MultFV0A, multFV0A, float);
Expand DownExpand Up@@ -111,7 +110,7 @@ DECLARE_SOA_DYNAMIC_COLUMN(IsINELgt1, isINELgt1, //! True if the Event belongs t
} // namespace mycascades

DECLARE_SOA_TABLE(MyCascades, "AOD", "MYCASCADES", o2::soa::Index<>,
mycascades::CollisionId, mycascades::CollisionZ, mycascades::MultFT0M, mycascades::MultFV0A, mycascades::Sign, mycascades::Pt, mycascades::RapXi, mycascades::RapOmega, mycascades::Eta, mycascades::MassXi, mycascades::MassOmega, mycascades::MassLambdaDau, mycascades::CascRadius, mycascades::V0Radius,
mycascades::CollisionZ, mycascades::MultFT0M, mycascades::MultFV0A, mycascades::Sign, mycascades::Pt, mycascades::RapXi, mycascades::RapOmega, mycascades::Eta, mycascades::MassXi, mycascades::MassOmega, mycascades::MassLambdaDau, mycascades::CascRadius, mycascades::V0Radius,
mycascades::CascCosPA, mycascades::V0CosPA, mycascades::DCAPosToPV, mycascades::DCANegToPV,
mycascades::DCABachToPV, mycascades::DCACascDaughters, mycascades::DCAV0Daughters, mycascades::DCAV0ToPV, mycascades::PosEta, mycascades::NegEta,
mycascades::BachEta, mycascades::PosITSHits, mycascades::NegITSHits, mycascades::BachITSHits,
Expand DownExpand Up@@ -139,7 +138,6 @@ enum EvFlags : uint8_t {
EvINELgt1 = 0x4 // Event with at least 2 PV contributors from the |eta| < 1
};

DECLARE_SOA_INDEX_COLUMN(McCollision, mcCollision); //! MC collision of this particle
DECLARE_SOA_COLUMN(CollisionZ, zcoll, float);
DECLARE_SOA_COLUMN(Sign, sign, float);
DECLARE_SOA_COLUMN(PdgCode, pdgCode, int);
Expand DownExpand Up@@ -169,7 +167,6 @@ DECLARE_SOA_DYNAMIC_COLUMN(IsINELgt1, isINELgt1, //! True if the Event belongs t
} // namespace myMCcascades

DECLARE_SOA_TABLE(MyMCCascades, "AOD", "MYMCCASCADES", o2::soa::Index<>,
myMCcascades::McCollisionId,
myMCcascades::CollisionZ, myMCcascades::Sign, myMCcascades::PdgCode,
myMCcascades::Y, myMCcascades::Eta, myMCcascades::Phi, myMCcascades::Pt,
myMCcascades::IsPrimary, myMCcascades::NAssocColl, myMCcascades::NChInFT0M,
Expand Down
42 changes: 30 additions & 12 deletions PWGLF/TableProducer/cascqaanalysis.cxx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -110,6 +110,7 @@ struct cascqaanalysis {
}
registry.add("hZCollisionGen", "hZCollisionGen", {HistType::kTH1F, {{200, -20.f, 20.f}}});
registry.add("hNchFT0MNAssocMCCollisions", "hNchFT0MNAssocMCCollisions", {HistType::kTH3F, {nChargedFT0MGenAxis, nAssocCollAxis, eventTypeAxis}});
registry.add("hNchFT0MNAssocMCCollisionsSameType", "hNchFT0MNAssocMCCollisionsSameType", {HistType::kTH3F, {nChargedFT0MGenAxis, nAssocCollAxis, eventTypeAxis}});
registry.add("hNContributorsCorrelation", "hNContributorsCorrelation", {HistType::kTH2F, {{250, -0.5f, 249.5f, "Secondary Contributor"}, {250, -0.5f, 249.5f, "Main Contributor"}}});
registry.add("hNchFT0MGenEvType", "hNchFT0MGenEvType", {HistType::kTH2F, {nChargedFT0MGenAxis, eventTypeAxis}});
} else {
Expand DownExpand Up@@ -342,7 +343,7 @@ struct cascqaanalysis {
registry.fill(HIST("hCandidateCounter"), 2.5); // passed topo cuts
// Fill table
if (fRand->Rndm() < lEventScale) {
mycascades(casc.globalIndex(), collision.posZ(), collision.centFT0M(), collision.centFV0A(), casc.sign(), casc.pt(), casc.yXi(), casc.yOmega(), casc.eta(),

@njacazionjacazioJul 27, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, indeed, I think this might be wrong. Should be the index of the collision in the collision table.
Are you sure that you don't need indices?

@nepeivodaRSnepeivodaRSJul 27, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Nicolò! We got errors during the merging of AO2Ds that we had Index on O2collision and O2mccollision tables but no trees were found. Anton said that this error means that "the merger cannot find the target tree of the index and thus cannot properly offset the index based on that tree size. Standalone derived data either should not have indices pointing to original AODs or should not be merged", so we decided to remove them at all, although I think in future it might be usefull to know at least whether the candidates are from the same collision or not.

@njacazionjacazioJul 27, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, indeed if you don't produce the collision it should not matter, for future mycascades(casc.globalIndex() still should be mycascades(tableColl.lastIndex() or so

@nepeivodaRSnepeivodaRSJul 27, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, like this or one can change the definition of this column to mycascades::CascadeId to match the meaning, so anyway it'll be still possible to find the info about the collision from the cascade table (if one saves it as the derived data output in addition to the collision table).

mycascades(collision.posZ(), collision.centFT0M(), collision.centFV0A(), casc.sign(), casc.pt(), casc.yXi(), casc.yOmega(), casc.eta(),
casc.mXi(), casc.mOmega(), casc.mLambda(), casc.cascradius(), casc.v0radius(),
casc.casccosPA(collision.posX(), collision.posY(), collision.posZ()), casc.v0cosPA(collision.posX(), collision.posY(), collision.posZ()),
casc.dcapostopv(), casc.dcanegtopv(), casc.dcabachtopv(), casc.dcacascdaughters(), casc.dcaV0daughters(), casc.dcav0topv(collision.posX(), collision.posY(), collision.posZ()),
Expand DownExpand Up@@ -449,7 +450,7 @@ struct cascqaanalysis {
}
// Fill table
if (fRand->Rndm() < lEventScale) {
mycascades(casc.globalIndex(), collision.posZ(), nchFT0, collision.multFV0A(), casc.sign(), casc.pt(), casc.yXi(), casc.yOmega(), casc.eta(),
mycascades(collision.posZ(), nchFT0, collision.multFV0A(), casc.sign(), casc.pt(), casc.yXi(), casc.yOmega(), casc.eta(),
casc.mXi(), casc.mOmega(), casc.mLambda(), casc.cascradius(), casc.v0radius(),
casc.casccosPA(collision.posX(), collision.posY(), collision.posZ()), casc.v0cosPA(collision.posX(), collision.posY(), collision.posZ()),
casc.dcapostopv(), casc.dcanegtopv(), casc.dcabachtopv(), casc.dcacascdaughters(), casc.dcaV0daughters(), casc.dcav0topv(collision.posX(), collision.posY(), collision.posZ()),
Expand DownExpand Up@@ -485,13 +486,13 @@ struct cascqaanalysis {
uint8_t flagsGen = 0;
flagsGen |= o2::aod::myMCcascades::EvFlags::EvINEL;
registry.fill(HIST("hNEventsMC"), 2.5);
// Generated collision is INEL>=0
// Generated collision is INEL>0
if (isINELgtNmc(mcParticles, 0)) {
flagsGen |= o2::aod::myMCcascades::EvFlags::EvINELgt0;
evType++;
registry.fill(HIST("hNEventsMC"), 3.5);
}
// Generated collision is INEL>=1
// Generated collision is INEL>1
if (isINELgtNmc(mcParticles, 1)) {
flagsGen |= o2::aod::myMCcascades::EvFlags::EvINELgt1;
evType++;
Expand DownExpand Up@@ -543,12 +544,30 @@ struct cascqaanalysis {
auto isAssocToINEL = [&mcCollision](CollisionIndexAndType i) { return (i.index == mcCollision.globalIndex()) && ((i.typeFlag & o2::aod::myMCcascades::EvFlags::EvINEL) == o2::aod::myMCcascades::EvFlags::EvINEL); };
auto isAssocToINELgt0 = [&mcCollision](CollisionIndexAndType i) { return (i.index == mcCollision.globalIndex()) && ((i.typeFlag & o2::aod::myMCcascades::EvFlags::EvINELgt0) == o2::aod::myMCcascades::EvFlags::EvINELgt0); };
auto isAssocToINELgt1 = [&mcCollision](CollisionIndexAndType i) { return (i.index == mcCollision.globalIndex()) && ((i.typeFlag & o2::aod::myMCcascades::EvFlags::EvINELgt1) == o2::aod::myMCcascades::EvFlags::EvINELgt1); };
// at least 1 selected reconstructed INEL event has the same global index as mcCollision
const auto evtReconstructedAndINEL = std::find_if(SelectedEvents.begin(), SelectedEvents.end(), isAssocToINEL) != SelectedEvents.end();
// at least 1 selected reconstructed INELgt0 event has the same global index as mcCollision
const auto evtReconstructedAndINELgt0 = std::find_if(SelectedEvents.begin(), SelectedEvents.end(), isAssocToINELgt0) != SelectedEvents.end();
// at least 1 selected reconstructed INELgt1 event has the same global index as mcCollision
const auto evtReconstructedAndINELgt1 = std::find_if(SelectedEvents.begin(), SelectedEvents.end(), isAssocToINELgt1) != SelectedEvents.end();
// number of reconstructed INEL events that have the same global index as mcCollision
const auto evtReconstructedAndINEL = std::count_if(SelectedEvents.begin(), SelectedEvents.end(), isAssocToINEL);
// number of reconstructed INEL > 0 events that have the same global index as mcCollision
const auto evtReconstructedAndINELgt0 = std::count_if(SelectedEvents.begin(), SelectedEvents.end(), isAssocToINELgt0);
// number of reconstructed INEL > 1 events that have the same global index as mcCollision
const auto evtReconstructedAndINELgt1 = std::count_if(SelectedEvents.begin(), SelectedEvents.end(), isAssocToINELgt1);

switch (evType) {
case 0: {
registry.fill(HIST("hNchFT0MNAssocMCCollisionsSameType"), nchFT0, evtReconstructedAndINEL, evType);
break;
}
case 1: {
registry.fill(HIST("hNchFT0MNAssocMCCollisionsSameType"), nchFT0, evtReconstructedAndINELgt0, evType);
break;
}
case 2: {
registry.fill(HIST("hNchFT0MNAssocMCCollisionsSameType"), nchFT0, evtReconstructedAndINELgt1, evType);
break;
}
default:
LOGF(fatal, "incorrect evType in cascqaanalysis task");
break;
}

uint8_t flagsAssoc = 0;
if (evtReconstructedAndINEL) {
Expand All@@ -571,8 +590,7 @@ struct cascqaanalysis {
} else {
continue;
}
myMCcascades(mcCollision.globalIndex(),
mcCollision.posZ(), sign, mcParticle.pdgCode(),
myMCcascades(mcCollision.posZ(), sign, mcParticle.pdgCode(),
mcParticle.y(), mcParticle.eta(), mcParticle.phi(), mcParticle.pt(),
mcParticle.isPhysicalPrimary(), nAssocColl, nchFT0,
flagsAssoc,
Expand Down
4 changes: 2 additions & 2 deletions PWGLF/Tasks/cascpostprocessing.cxx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -106,12 +106,12 @@ struct cascpostprocessing {
TString CutLabel[26] = {"All", "MassWin", "y", "EtaDau", "DCADauToPV", "CascCosPA", "V0CosPA", "DCACascDau", "DCAV0Dau", "rCasc", "rCascMax", "rV0", "rV0Max", "DCAV0ToPV", "LambdaMass", "TPCPr", "TPCPi", "TOFPr", "TOFPi", "TPCBach", "TOFBach", "ctau", "CompDecayMass", "Bach-baryon", "NTPCrows", "OOBRej"};
TString CutLabelSummary[29] = {"MassWin", "y", "EtaDau", "dcapostopv", "dcanegtopv", "dcabachtopv", "CascCosPA", "V0CosPA", "DCACascDau", "DCAV0Dau", "rCasc", "rV0", "DCAV0ToPV", "LambdaMass", "TPCPr", "TPCPi", "TOFPr", "TOFPi", "TPCBach", "TOFBach", "proplifetime", "rejcomp", "ptthrtof", "bachBaryonCosPA", "bachBaryonDCAxyToPV", "NTPCrows", "OOBRej", "rCascMax", "rV0Max"};

registry.add("hCandidate", "hCandidate", HistType::kTH1F, {{25, -0.5, 24.5}});

@njacazionjacazioJul 27, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intended?

@nepeivodaRSnepeivodaRSJul 27, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's related to another issue that we had in the postprocessing task: "Warning in TH1Merger::CheckForDuplicateLabels: Histogram hCandidate has duplicate labels in the x axis. Bin contents will be merged in a single bin"
(https://alimonitor.cern.ch/train-workdir/tests/0010/00106822/stdout.log)
I think that was happening because we had 25 bins in hCandidate histo, but there're only 24 labels, so the label for the 25th bin was taken from CutLabel[24] (line 111), which caused an undefined behavior.

@nepeivodaRSnepeivodaRSJul 27, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed that I had outdated version of postprocessing, so there should be 26 bins.

@njacazionjacazioJul 27, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bingo

registry.add("hCandidate", "hCandidate", HistType::kTH1F, {{26, -0.5, 25.5}});
for (Int_t n = 1; n <= registry.get<TH1>(HIST("hCandidate"))->GetNbinsX(); n++) {
registry.get<TH1>(HIST("hCandidate"))->GetXaxis()->SetBinLabel(n, CutLabel[n - 1]);
}

registry.add("CascadeSelectionSummary", "CascadeSelectionSummary", HistType::kTH1F, {{29, -0.5, 26.5}});
registry.add("CascadeSelectionSummary", "CascadeSelectionSummary", HistType::kTH1F, {{29, -0.5, 28.5}});
for (Int_t n = 1; n <= registry.get<TH1>(HIST("CascadeSelectionSummary"))->GetNbinsX(); n++) {
registry.get<TH1>(HIST("CascadeSelectionSummary"))->GetXaxis()->SetBinLabel(n, CutLabelSummary[n - 1]);
}
Expand Down