Uh oh!
There was an error while loading. Please reload this page.
RecoDecay: Add message about deprecating getMassPDG - #3199
Merged
Conversation
vkucera
marked this pull request as ready for review
July 28, 2023 08:40
vkucera
requested review from
a team, alibuild, ddobrigk, iarsene, jgrosseo and ktf
as code ownersJuly 28, 2023 08:40
vkucera
commented
Jul 28, 2023
CollaboratorAuthor
@ddobrigk What do you think? |
aalkin
commented
Jul 28, 2023
Member
There is a conventional method to do it (https://en.cppreference.com/w/cpp/language/attributes/deprecated), it produces warnings during compilation. |
vkucera
commented
Jul 28, 2023
CollaboratorAuthor
Hi @aalkin , thanks, I was not aware of that. I can add it. I would also keep the error though, because I suspect that most people do not read (or care about) the compilation warnings as long as it compiles and the runtime error makes this migration reminder more visible. |
aalkin
commented
Jul 28, 2023
Member
I have to agree :) |
ddobrigk
approved these changes
Jul 31, 2023
hahassan7 pushed a commit
to hahassan7/O2Physics
that referenced
this pull request
Oct 6, 2023
* RecoDecay: Add message about deprecating getMassPDG * Show error message only once per device
hahassan7 pushed a commit
to hahassan7/O2Physics
that referenced
this pull request
Oct 7, 2023
* RecoDecay: Add message about deprecating getMassPDG * Show error message only once per device
zconesa pushed a commit
to zconesa/O2Physics
that referenced
this pull request
Oct 27, 2023
* RecoDecay: Add message about deprecating getMassPDG * Show error message only once per device
chengtt0406 pushed a commit
to chengtt0406/O2Physics
that referenced
this pull request
Dec 6, 2023
* RecoDecay: Add message about deprecating getMassPDG * Show error message only once per device
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires #3105