Uh oh!
There was an error while loading. Please reload this page.
PWGHF: Minor fix in the efficiency vector size and change in default selection flag - #3586
Merged
Conversation
Please consider the following formatting changes to AliceO2Group#2561
Please consider the following formatting changes to AliceO2Group#2329
Please consider the following formatting changes to AliceO2Group#2329
Please consider the following formatting changes to AliceO2Group#2329
I fixed the recent comment to sort all the includes w.r.t. directories and also double changed to float as suggested at line 72-73.
PtBins increased by 1 to avoid vector range error. Default selection flag = 7 to make it similar to taskDplus
Simple-Shyam
requested review from
adubla, alibuild, fcolamar and vkucera
as code ownersOctober 10, 2023 13:14
Simple-Shyam
requested review from
NicoleBastid, deepathoms, fcatalan92, fgrosa, gtaillepied, mfaggin, mmazzilli and nzardosh
as code ownersOctober 10, 2023 13:14
Please consider the following formatting changes to AliceO2Group#3586
alibuild
commented
Oct 14, 2023
Collaborator
Simple-Shyam
commented
Oct 14, 2023
ContributorAuthor
fgrosa
requested changes
Oct 16, 2023
fgrosa
left a comment
Collaborator
There was a problem hiding this comment.
Hi @Simple-Shyam I just have a minor comment, once implemented we can merge your PR. Thanks!
Uh oh!
There was an error while loading. Please reload this page.
fgrosa
requested changes
Oct 16, 2023
Uh oh!
There was an error while loading. Please reload this page.
fgrosa
requested changes
Oct 16, 2023
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>
Please consider the following formatting changes to AliceO2Group#3586
fgrosa
approved these changes
Oct 16, 2023
fgrosa
enabled auto-merge (squash)
October 16, 2023 10:25
zconesa pushed a commit
to zconesa/O2Physics
that referenced
this pull request
Oct 27, 2023
…selection flag (AliceO2Group#3586) * Event Mixing added * Event Mixing added * Event Mixing Implemented * Mixed event implemented * Please consider the following formatting changes * Fixed for using and Filter guidelines * Please consider the following formatting changes * Comments implemented * Comments implemented * Fixed for comments * Please consider the following formatting changes * Fixing comment for D-meson as suggested. * Fixed comments * Please consider the following formatting changes * Fixed for error in built * Sort includes and fixed float at line 72-73 I fixed the recent comment to sort all the includes w.r.t. directories and also double changed to float as suggested at line 72-73. * Update correlatorDplusHadrons.cxx PtBins increased by 1 to avoid vector range error. Default selection flag = 7 to make it similar to taskDplus * Please consider the following formatting changes * Fixed vector for size * Fixed vector for the error also in the task * Update correlatorDplusHadrons.cxx * Update taskCorrelationDplusHadrons.cxx * Update PWGHF/HFC/TableProducer/correlatorDplusHadrons.cxx Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch> * Update taskCorrelationDplusHadrons.cxx * Please consider the following formatting changes --------- Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>
chengtt0406 pushed a commit
to chengtt0406/O2Physics
that referenced
this pull request
Dec 6, 2023
…selection flag (AliceO2Group#3586) * Event Mixing added * Event Mixing added * Event Mixing Implemented * Mixed event implemented * Please consider the following formatting changes * Fixed for using and Filter guidelines * Please consider the following formatting changes * Comments implemented * Comments implemented * Fixed for comments * Please consider the following formatting changes * Fixing comment for D-meson as suggested. * Fixed comments * Please consider the following formatting changes * Fixed for error in built * Sort includes and fixed float at line 72-73 I fixed the recent comment to sort all the includes w.r.t. directories and also double changed to float as suggested at line 72-73. * Update correlatorDplusHadrons.cxx PtBins increased by 1 to avoid vector range error. Default selection flag = 7 to make it similar to taskDplus * Please consider the following formatting changes * Fixed vector for size * Fixed vector for the error also in the task * Update correlatorDplusHadrons.cxx * Update taskCorrelationDplusHadrons.cxx * Update PWGHF/HFC/TableProducer/correlatorDplusHadrons.cxx Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch> * Update taskCorrelationDplusHadrons.cxx * Please consider the following formatting changes --------- Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://mattermost.web.cern.ch/alice/pl/qpdqn76tubnitk46txsfs78y3o