Uh oh!
There was an error while loading. Please reload this page.
Next multiplicity - #3794
Merged
Merged
Conversation
njacazio
marked this pull request as ready for review
November 7, 2023 17:32
njacazio
requested review from
a team, alibuild, ddobrigk, iarsene, jgrosseo and ktf
as code ownersNovember 7, 2023 17:32
njacazio
commented
Nov 7, 2023
CollaboratorAuthor
This splits the filling of the tables following the requests from other tasks |
alibuild
commented
Nov 7, 2023
Collaborator
Error while checking build/O2Physics/o2 for a7e17a5 at 2023-11-07 18:48: Full log here. |
ddobrigk
commented
Nov 11, 2023
Collaborator
Thanks a lot @njacazio ! This looks good! :-D ...please don't kill me for this comment, but maybe what we could also do - maybe as a next development after this PR - is consider splitting the barrel counters in a modular way, too. This because these slicers actually are the CPU bottleneck of this task, and quite likely, not all 4 of them are always needed... |
ddobrigk
approved these changes
Nov 11, 2023
Collaborator
Confirmed tested extensively by @njacazio , merging. Thanks! |
njacazio
commented
Nov 11, 2023
CollaboratorAuthor
Hi @ddobrigk sure I agree |
chengtt0406 pushed a commit
to chengtt0406/O2Physics
that referenced
this pull request
Dec 6, 2023
* Next multiplicity * Update multiplicityTable.cxx * Update multiplicityTable.cxx * Please consider the following formatting changes * Update multiplicityTable.cxx --------- Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.