Skip to content

[Common/EventPlane] Updates on initial assignment on constant, structrue of qvectors, and others - #4006

Merged
ddobrigk merged 7 commits into
AliceO2Group:masterfrom
jikim1290:master
Dec 12, 2023
Merged

[Common/EventPlane] Updates on initial assignment on constant, structrue of qvectors, and others#4006
ddobrigk merged 7 commits into
AliceO2Group:masterfrom
jikim1290:master

Conversation

@jikim1290

@jikim1290jikim1290 commented Nov 28, 2023

Copy link
Copy Markdown
Contributor

initial assignment

jikim1290 added a commit to jikim1290/O2Physics that referenced this pull request Nov 28, 2023
@jikim1290
Merge pull request#49from alibuild/alibot-cleanup-4006
193abea
Please consider the following formatting changes to AliceO2Group#4006
@alibuild

alibuild commented Nov 28, 2023

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 193abea at 2023-11-28 07:19:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/4006-slc7_x86-64/0/Common/TableProducer/qVectorsTable.cxx:453:5: error: expected ';' at end of member declaration
/sw/SOURCES/O2Physics/4006-slc7_x86-64/0/Common/TableProducer/qVectorsTable.cxx:453:6: error: expected '}' at end of input
/sw/SOURCES/O2Physics/4006-slc7_x86-64/0/Common/TableProducer/qVectorsTable.cxx:81:116: error: no matching function for call to 'std::vector<float>::vector(<brace-enclosed initializer list>)'
/sw/SOURCES/O2Physics/4006-slc7_x86-64/0/Common/TableProducer/qVectorsTable.cxx:81:117: error: expected '}' before ';' token
/sw/SOURCES/O2Physics/4006-slc7_x86-64/0/Common/TableProducer/qVectorsTable.cxx:81:117: error: could not convert '{"cfgBPosCorr", <expression error>}' from '<brace-enclosed initializer list>' to 'o2::framework::Configurable<std::vector<float> >'
/sw/SOURCES/O2Physics/4006-slc7_x86-64/0/Common/TableProducer/qVectorsTable.cxx:81:117: error: expected ';' before ';' token
/sw/SOURCES/O2Physics/4006-slc7_x86-64/0/Common/TableProducer/qVectorsTable.cxx:453:6: error: expected unqualified-id at end of input
ninja: build stopped: subcommand failed.

Full log here.

jikim1290 added a commit to jikim1290/O2Physics that referenced this pull request Nov 28, 2023
@jikim1290
Merge pull request#50from alibuild/alibot-cleanup-4006
9e6599d
Please consider the following formatting changes to AliceO2Group#4006
@jikim1290jikim1290 changed the title [Common/EventPlane] initial assignment[Common/EventPlane] Updates on initial assignment on constant, structrue of qvectors, and othersDec 11, 2023
@alibuildalibuild mentioned this pull request Dec 11, 2023
Merged
ddobrigk
ddobrigk approved these changes Dec 12, 2023
View reviewed changes

@ddobrigkddobrigk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ddobrigk
ddobrigk merged commit a933cd2 into AliceO2Group:masterDec 12, 2023
hahassan7 pushed a commit to hahassan7/O2Physics that referenced this pull request Feb 1, 2024
@jikim1290junleekim
@alibuild@hahassan7
[Common/EventPlane] Updates on initial assignment on constant, struct…
6ab60cf
…rue of qvectors, and others (AliceO2Group#4006)
* updates on structure and etc
* fix
* Please consider the following formatting changes
* MegaLinter fixes
---------
Co-authored-by: junleekim <junleekim@junleekims-MacBook-Pro.local>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ercolessi pushed a commit to ercolessi/O2Physics that referenced this pull request Feb 28, 2024
@jikim1290junleekim
@alibuild@ercolessi
[Common/EventPlane] Updates on initial assignment on constant, struct…
92ad828
…rue of qvectors, and others (AliceO2Group#4006)
* updates on structure and etc
* fix
* Please consider the following formatting changes
* MegaLinter fixes
---------
Co-authored-by: junleekim <junleekim@junleekims-MacBook-Pro.local>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ddobrigkddobrigkddobrigk approved these changes
@alibuildalibuildAwaiting requested review from alibuildalibuild is a code owner
@jgrosseojgrosseoAwaiting requested review from jgrosseojgrosseo is a code owner
@iarseneiarseneAwaiting requested review from iarseneiarsene is a code owner
@ktfktfAwaiting requested review from ktfktf is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jikim1290@alibuild@ddobrigk