PWGCF: upload PbPb flow analysis for hyperloop by Luzhiyongg · Pull Request #4088 · AliceO2Group/O2Physics

Luzhiyongg · 2023-12-06T12:23:31Z

the code to produce flow observables for PbPb run3 data

victor-gonzalez

Thanks for moving forward the first Flow GF analysis in O2!
Please, consider my comments before approval

victor-gonzalez · 2023-12-07T07:25:32Z

+ if (SampleIndex == 0)
+ FillBootstrap<0>(cent, ptSum_Gap08, weffEvent_WithinGap08, sum_pt_wSquare_WithinGap08, sum_ptSquare_wSquare_WithinGap08, WeffEvent_diff_WithGap08);
+ else if (SampleIndex == 1)
+ FillBootstrap<1>(cent, ptSum_Gap08, weffEvent_WithinGap08, sum_pt_wSquare_WithinGap08, sum_ptSquare_wSquare_WithinGap08, WeffEvent_diff_WithGap08);
+ else if (SampleIndex == 2)
+ FillBootstrap<2>(cent, ptSum_Gap08, weffEvent_WithinGap08, sum_pt_wSquare_WithinGap08, sum_ptSquare_wSquare_WithinGap08, WeffEvent_diff_WithGap08);
+ else if (SampleIndex == 3)
+ FillBootstrap<3>(cent, ptSum_Gap08, weffEvent_WithinGap08, sum_pt_wSquare_WithinGap08, sum_ptSquare_wSquare_WithinGap08, WeffEvent_diff_WithGap08);
+ else if (SampleIndex == 4)
+ FillBootstrap<4>(cent, ptSum_Gap08, weffEvent_WithinGap08, sum_pt_wSquare_WithinGap08, sum_ptSquare_wSquare_WithinGap08, WeffEvent_diff_WithGap08);
+ else if (SampleIndex == 5)
+ FillBootstrap<5>(cent, ptSum_Gap08, weffEvent_WithinGap08, sum_pt_wSquare_WithinGap08, sum_ptSquare_wSquare_WithinGap08, WeffEvent_diff_WithGap08);
+ else if (SampleIndex == 6)
+ FillBootstrap<6>(cent, ptSum_Gap08, weffEvent_WithinGap08, sum_pt_wSquare_WithinGap08, sum_ptSquare_wSquare_WithinGap08, WeffEvent_diff_WithGap08);
+ else if (SampleIndex == 7)
+ FillBootstrap<7>(cent, ptSum_Gap08, weffEvent_WithinGap08, sum_pt_wSquare_WithinGap08, sum_ptSquare_wSquare_WithinGap08, WeffEvent_diff_WithGap08);
+ else if (SampleIndex == 8)
+ FillBootstrap<8>(cent, ptSum_Gap08, weffEvent_WithinGap08, sum_pt_wSquare_WithinGap08, sum_ptSquare_wSquare_WithinGap08, WeffEvent_diff_WithGap08);
+ else if (SampleIndex == 9)
+ FillBootstrap<9>(cent, ptSum_Gap08, weffEvent_WithinGap08, sum_pt_wSquare_WithinGap08, sum_ptSquare_wSquare_WithinGap08, WeffEvent_diff_WithGap08);


Couldn't it be enough to pass the SampleIndex as the template parameter and avoid the chain of ifs?

I also do not like this chain of if-else, but the HIST("") is a static function and do not accept variables. It's welcomed if you have any other idea.

You could receive the histogram pointers and put them in an array?

Hi Jan, thanks for your suggestions, I also find it hard to receive pointers due to the subdirectory:
static HIST("") make it hard to loop the subsamples (Number of subsamples may change in configurable)
I also try to loop over the TDirectory, but static_cast<TList*> will break the subdirectory structure
For my view, it's better to store the pointers in a TList object at the beginning. As it's late at night in Asia, I will make the changes tomorrow

Hi victor, Jan,
I have implemented the changes. Please take a look.

Hi victor, Jan, I have implemented the changes. Please take a look.
Sorry, I am traveling today and only on the phone.
I believe registry.add returns the pointer.
Also I was wondering if it makes sense to use the index as a histogram axis instead by adding one dimension (and using THn)

Hi victor, Jan, I have implemented the changes. Please take a look.
Sorry, I am traveling today and only on the phone.
I believe registry.add returns the pointer.
Also I was wondering if it makes sense to use the index as a histogram axis instead by adding one dimension (and using THn)
Hi Jan,
Yes I can simplify my code using the return pointers from registry.add(). I will do this later.
For my sight, using the index of histograms or using a TProfile2D are the same. But maybe it's due to my lack of experience and I don't know the benefits to use TProfile2D. If you have any comment on this, please tell me.

victor-gonzalez · 2023-12-08T09:11:21Z

+ BootstrapArray[i][0] = new TProfile(Form("hMeanPtWithinGap08_%d", i), Form("hMeanPtWithinGap08_%d", i), nMultiBins, &multiBins[0]);
+ BootstrapArray[i][1] = new TProfile(Form("c22_gap08_Weff_%d", i), Form("c22_gap08_Weff_%d", i), nMultiBins, &multiBins[0]);
+ BootstrapArray[i][2] = new TProfile(Form("c22_gap08_trackMeanPt_%d", i), Form("c22_gap08_trackMeanPt_%d", i), nMultiBins, &multiBins[0]);
+ BootstrapArray[i][3] = new TProfile(Form("PtVariance_partA_WithinGap08_%d", i), Form("PtVariance_partA_WithinGap08_%d", i), nMultiBins, &multiBins[0]);
+ BootstrapArray[i][4] = new TProfile(Form("PtVariance_partB_WithinGap08_%d", i), Form("PtVariance_partB_WithinGap08_%d", i), nMultiBins, &multiBins[0]);
+ for (int j = 0; j < 5; j++) {
+ BootstrapArray[i][j]->Sumw2();
+ fOutputList->Add(BootstrapArray[i][j]);
+ }
+ }


I would keep the sub-directories structure that you had previously by using instead registry.add which, as Jan Fiete said, should return the TProfile pointer which you can store in your array
I would suggest also to, instead of using 0, 1, 2, 3, 4, to select your TProfile within a concrete sub-sample, to use an enum as, for example,
enum theProfiles { kMeanPt = 0, kC22Weff, kC22MeanPt, kPtVarParA, kPtVarParB };
or something similar, which will allow you to remember at each time what you are filling.

sure, I will apply it in next PR

victor-gonzalez · 2023-12-08T09:17:35Z

+ if (weffEvent_WithinGap08 > 1e-6)
+ BootstrapArray[SampleIndex][0]->Fill(cent, ptSum_Gap08 / weffEvent_WithinGap08, weffEvent_WithinGap08);
+ if (weffEvent_WithinGap08 > 1e-6)
+ FillpTvnProfile(corrconfigs.at(7), ptSum_Gap08, weffEvent_WithinGap08, BootstrapArray[SampleIndex][1], BootstrapArray[SampleIndex][2], cent);
+ if (WeffEvent_diff_WithGap08 > 1e-6) {
+ BootstrapArray[SampleIndex][3]->Fill(cent,
+ (ptSum_Gap08 * ptSum_Gap08 - sum_ptSquare_wSquare_WithinGap08) / WeffEvent_diff_WithGap08,
+ WeffEvent_diff_WithGap08);
+ BootstrapArray[SampleIndex][4]->Fill(cent,
+ (weffEvent_WithinGap08 * ptSum_Gap08 - sum_pt_wSquare_WithinGap08) / WeffEvent_diff_WithGap08,
+ WeffEvent_diff_WithGap08);
+ }


If you decide to use the above suggested enum use them here as indexes of your profiles in the corresponding sub-sample

* upload PbPb flow analysis for hyperloop * format source file with git-clang-format * fix the error informed by MegaLinter * add a new line at the end of file according to MegaLinter * remove commented lines * Use TList to store Bootstrap samples * move <vector> up according to MegaLinter * simplify code with return pointers of registry.add

Luzhiyongg added 2 commits December 6, 2023 19:38

upload PbPb flow analysis for hyperloop
ef87d48

format source file with git-clang-format
720de16

Luzhiyongg requested review from alibuild, jgrosseo, saganatt, victor-gonzalez and zchochul as code owners December 6, 2023 12:23

Luzhiyongg added 2 commits December 6, 2023 20:41

fix the error informed by MegaLinter
77627f5

add a new line at the end of file according to MegaLinter
c21235a

victor-gonzalez requested changes Dec 7, 2023
View reviewed changes

Luzhiyongg added 4 commits December 7, 2023 19:10

remove commented lines
95c59ca

Use TList to store Bootstrap samples
8e6661c

move <vector> up according to MegaLinter
efa80e7

simplify code with return pointers of registry.add
bb0c5e6

victor-gonzalez approved these changes Dec 9, 2023
View reviewed changes

victor-gonzalez merged commit 586b3d1 into AliceO2Group:masterDec 9, 2023

Navigation Menu

Uh oh!

PWGCF: upload PbPb flow analysis for hyperloop - #4088

PWGCF: upload PbPb flow analysis for hyperloop#4088
victor-gonzalez merged 8 commits into
AliceO2Group:masterfrom
Luzhiyongg:master

Luzhiyongg commented Dec 6, 2023

Uh oh!

victor-gonzalez left a comment

Uh oh!

Uh oh!

victor-gonzalezDec 7, 2023

Uh oh!

LuzhiyonggDec 7, 2023

Uh oh!

jgrosseoDec 7, 2023

Uh oh!

LuzhiyonggDec 7, 2023•
edited
Loading

Uh oh!

LuzhiyonggDec 8, 2023

Uh oh!

jgrosseoDec 8, 2023

Uh oh!

LuzhiyonggDec 8, 2023

Uh oh!

Uh oh!

victor-gonzalezDec 8, 2023

Uh oh!

LuzhiyonggDec 10, 2023

Uh oh!

victor-gonzalezDec 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Luzhiyongg commented Dec 6, 2023

Uh oh!

victor-gonzalez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LuzhiyonggDec 7, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

LuzhiyonggDec 7, 2023•
edited
Loading