Skip to content

PWGHF: fix cascade index in derived data production and adapt task toXiPi - #4131

Merged
fgrosa merged 18 commits into
AliceO2Group:masterfrom
ZFederica:working
Dec 12, 2023
Merged

PWGHF: fix cascade index in derived data production and adapt task toXiPi#4131
fgrosa merged 18 commits into
AliceO2Group:masterfrom
ZFederica:working

Conversation

@ZFederica

@ZFedericaZFederica commented Dec 11, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor
  • change cascade index in derived data production: globalIndex --> cascadeId
  • adapt candidateCreatorToXiPi
  • remove old struct in candidateCreatorToXiPi
  • now PVRefit is not available in the --> xi pi analysis

@alibuildalibuild mentioned this pull request Dec 11, 2023
Merged
mfaggin
mfaggin reviewed Dec 11, 2023
View reviewed changes
Comment threadPWGHF/TableProducer/candidateCreatorToXiPi.cxx Outdated
@ZFederica@mfaggin
Update PWGHF/TableProducer/candidateCreatorToXiPi.cxx
fd539a2
Co-authored-by: Mattia Faggin <mattia.faggin@cern.ch>
mfaggin
mfaggin reviewed Dec 11, 2023
View reviewed changes
Comment threadPWGHF/TableProducer/candidateCreatorToXiPi.cxx Outdated
mfaggin
mfaggin reviewed Dec 11, 2023
View reviewed changes
Comment threadPWGHF/TableProducer/candidateCreatorToXiPi.cxx Outdated
@alibuildalibuild mentioned this pull request Dec 11, 2023
Closed
@ZFederica
Merge pull request#48from alibuild/alibot-cleanup-4131
171ed8e
Please consider the following formatting changes to AliceO2Group#4131
@mfaggin

mfaggin commented Dec 11, 2023

Copy link
Copy Markdown
Collaborator

Hi @ZFederica looking at your changes they look reasonable. I would just ask to @fgrosa to have a further look just to be sure.

@fgrosa

fgrosa commented Dec 12, 2023

Copy link
Copy Markdown
Collaborator

Hi @ZFederica looking at your changes they look reasonable. I would just ask to @fgrosa to have a further look just to be sure.

The PR looks good to me (great that you also removed the "redundant" process function). Merging!

@fgrosa
fgrosa enabled auto-merge (squash) December 12, 2023 08:37
@fgrosa
fgrosa merged commit 3240eb7 into AliceO2Group:masterDec 12, 2023
@ZFederica
ZFederica deleted the working branch December 13, 2023 15:56
hahassan7 pushed a commit to hahassan7/O2Physics that referenced this pull request Feb 1, 2024
@ZFederica@alibuild
@mfaggin@hahassan7
PWGHF: fix cascade index in derived data production and adapt task to…
2ac923c
…XiPi (AliceO2Group#4131)
* Change cascade index globalIndex-->cascadeId
* Adapt toXiPi creator
* Please consider the following formatting changes
* Please consider the following formatting changes
* MegaLinter fixes
* Fix save indexes and unused variables
* Fix
* Please consider the following formatting changes
* Update PWGHF/TableProducer/candidateCreatorToXiPi.cxx
Co-authored-by: Mattia Faggin <mattia.faggin@cern.ch>
* Remove cascade preselections (outdated)
* Change variable name
* Please consider the following formatting changes
---------
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: Mattia Faggin <mattia.faggin@cern.ch>
ercolessi pushed a commit to ercolessi/O2Physics that referenced this pull request Feb 28, 2024
@ZFederica@alibuild
@mfaggin@ercolessi
PWGHF: fix cascade index in derived data production and adapt task to…
db0345f
…XiPi (AliceO2Group#4131)
* Change cascade index globalIndex-->cascadeId
* Adapt toXiPi creator
* Please consider the following formatting changes
* Please consider the following formatting changes
* MegaLinter fixes
* Fix save indexes and unused variables
* Fix
* Please consider the following formatting changes
* Update PWGHF/TableProducer/candidateCreatorToXiPi.cxx
Co-authored-by: Mattia Faggin <mattia.faggin@cern.ch>
* Remove cascade preselections (outdated)
* Change variable name
* Please consider the following formatting changes
---------
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: Mattia Faggin <mattia.faggin@cern.ch>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfagginmfagginmfaggin left review comments
@fgrosafgrosafgrosa approved these changes
@alibuildalibuildAwaiting requested review from alibuildalibuild is a code owner
@vkuceravkuceraAwaiting requested review from vkuceravkucera is a code owner
@fcolamarfcolamarAwaiting requested review from fcolamarfcolamar is a code owner
@fcatalan92fcatalan92Awaiting requested review from fcatalan92fcatalan92 is a code owner
@mmazzillimmazzilliAwaiting requested review from mmazzillimmazzilli is a code owner
@deepathomsdeepathomsAwaiting requested review from deepathomsdeepathoms is a code owner
@nzardoshnzardoshAwaiting requested review from nzardosh
@NicoleBastidNicoleBastidAwaiting requested review from NicoleBastidNicoleBastid is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ZFederica@mfaggin@fgrosa@alibuild