Skip to content

Add ML inference class for Lc->PKPi and related modifications to the selector - #4319

Merged
fcatalan92 merged 8 commits into
AliceO2Group:masterfrom
gluparel:master
Jan 17, 2024
Merged

Add ML inference class for Lc->PKPi and related modifications to the selector#4319
fcatalan92 merged 8 commits into
AliceO2Group:masterfrom
gluparel:master

Conversation

@gluparel

@gluparelgluparel commented Jan 15, 2024

Copy link
Copy Markdown
Collaborator

No description provided.

@alibuildalibuild mentioned this pull request Jan 15, 2024
Merged
fcatalan92
fcatalan92 requested changes Jan 16, 2024
View reviewed changes

@fcatalan92fcatalan92 left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gluparel, thanks for the developments! There are a couple of points that need to be addressed, see the line-by-line comments. Please address also the megalinter problems, it is enough to merge the PR gluparel#1 that has been opened to your fork.

Comment threadPWGHF/Core/HfMlResponseLcToPKPi.h Outdated
Comment threadPWGHF/TableProducer/candidateSelectorLc.cxx
@alibuildalibuild mentioned this pull request Jan 16, 2024
Closed
fcatalan92
fcatalan92 previously approved these changes Jan 16, 2024
View reviewed changes
@fcatalan92fcatalan92 reopened this Jan 16, 2024
@fcatalan92

fcatalan92 commented Jan 16, 2024

Copy link
Copy Markdown
Collaborator

Hi @gluparel, fine for me now! However, you should solve the clang-format issues before I can merge.

@gluparel

gluparel commented Jan 17, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Hello @fcatalan92. Thanks for the review! the clang-format issue is now solved. Do I need also to merge the pull request for the MegaLinter problem?

@fcatalan92

fcatalan92 commented Jan 17, 2024•
edited
Loading

Copy link
Copy Markdown
Collaborator

Hi @gluparel, no. The automatically generated PR looks problematic. It looks like something broke in the check itself. In any case, we can go ahead.

@fcatalan92
fcatalan92 enabled auto-merge (squash) January 17, 2024 09:44
@fcatalan92
fcatalan92 merged commit 2d35d9c into AliceO2Group:masterJan 17, 2024
stefanopolitano pushed a commit to stefanopolitano/O2Physics that referenced this pull request Jan 17, 2024
@gluparel@alibuild@stefanopolitano
Add ML inference class for Lc->PKPi and related modifications to the …
71e690a
…selector (AliceO2Group#4319)
* Add ML inference class for Lc->PKPi and related modifications to the selector
* clang format
* MegaLinter fixes
* Implement corrections
* correct clang-format
---------
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
hahassan7 pushed a commit to hahassan7/O2Physics that referenced this pull request Feb 1, 2024
@gluparel@alibuild@hahassan7
Add ML inference class for Lc->PKPi and related modifications to the …
3df5fd8
…selector (AliceO2Group#4319)
* Add ML inference class for Lc->PKPi and related modifications to the selector
* clang format
* MegaLinter fixes
* Implement corrections
* correct clang-format
---------
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
basiach pushed a commit to basiach/O2Physics that referenced this pull request Feb 23, 2024
@gluparel@alibuild@basiach
Add ML inference class for Lc->PKPi and related modifications to the …
9653d9c
…selector (AliceO2Group#4319)
* Add ML inference class for Lc->PKPi and related modifications to the selector
* clang format
* MegaLinter fixes
* Implement corrections
* correct clang-format
---------
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ercolessi pushed a commit to ercolessi/O2Physics that referenced this pull request Feb 28, 2024
@gluparel@alibuild@ercolessi
Add ML inference class for Lc->PKPi and related modifications to the …
19c78be
…selector (AliceO2Group#4319)
* Add ML inference class for Lc->PKPi and related modifications to the selector
* clang format
* MegaLinter fixes
* Implement corrections
* correct clang-format
---------
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fcatalan92fcatalan92fcatalan92 approved these changes
@alibuildalibuildAwaiting requested review from alibuildalibuild is a code owner
@vkuceravkuceraAwaiting requested review from vkuceravkucera is a code owner
@fcolamarfcolamarAwaiting requested review from fcolamarfcolamar is a code owner
@fgrosafgrosaAwaiting requested review from fgrosafgrosa is a code owner
@mfagginmfagginAwaiting requested review from mfagginmfaggin is a code owner
@mmazzillimmazzilliAwaiting requested review from mmazzillimmazzilli is a code owner
@deepathomsdeepathomsAwaiting requested review from deepathomsdeepathoms is a code owner
@nzardoshnzardoshAwaiting requested review from nzardosh
@NicoleBastidNicoleBastidAwaiting requested review from NicoleBastidNicoleBastid is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gluparel@fcatalan92@alibuild