Uh oh!
There was an error while loading. Please reload this page.
PWGLF: Fix autodetect in strangeness builders - #4420
Merged
Conversation
Look for Casc/V0 Indices tables instead of Datas tables
ddobrigk
commented
Jan 22, 2024
Collaborator
Thanks a lot @rspijkers for catching this! However, I think the subscription that the autodetect should look for is the |
rspijkers
commented
Jan 22, 2024
ContributorAuthor
Hi @ddobrigk , done! Would it make sense to add some extra logic to the V0-builder autodetect in case one is looking at cascades? Instead of trying to match settings with the cascade-builder (which doesn't make much sense), one can look at the process that subscribes to the cascades and scan that for any V0 settings. |
rspijkers
marked this pull request as ready for review
January 26, 2024 10:45
rspijkers
requested review from
BongHwi, ChiaraDeMartin95, alibuild, chiarapinto, fmazzasc, mbombara, njacazio and skundu692
as code ownersJanuary 26, 2024 10:45
ddobrigk
commented
Jan 26, 2024
Collaborator
@rspijkers thank you very very much! :-D |
hahassan7 pushed a commit
to hahassan7/O2Physics
that referenced
this pull request
Feb 1, 2024
* Fix autodetect in strangeness builders Look for Casc/V0 Indices tables instead of Datas tables * Change from V0/Casc Indices to Cores * Also search devices that subscribe to casc tables for V0 settings * Please consider the following formatting changes (AliceO2Group#9) --------- Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
basiach pushed a commit
to basiach/O2Physics
that referenced
this pull request
Feb 23, 2024
* Fix autodetect in strangeness builders Look for Casc/V0 Indices tables instead of Datas tables * Change from V0/Casc Indices to Cores * Also search devices that subscribe to casc tables for V0 settings * Please consider the following formatting changes (#9) --------- Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Look for Casc/V0 Indices tables instead of Datas tables