Uh oh!
There was an error while loading. Please reload this page.
PWGHF: fix downsampling tree creator Lc. - #4511
Merged
Merged
Conversation
mfaggin
requested review from
NicoleBastid, alibuild, deepathoms, fcatalan92, fcolamar, fgrosa, mmazzilli, nzardosh and vkucera
as code ownersJanuary 29, 2024 17:25
fgrosa
approved these changes
Jan 29, 2024
fgrosa
enabled auto-merge (squash)
January 29, 2024 17:28
mfaggin
commented
Jan 29, 2024
CollaboratorAuthor
thanks @fgrosa |
vkucera
reviewed
Jan 30, 2024
| float FunctionE) { | ||
| double pseudoRndm = trackPos1.pt() * 1000. - (int64_t)(trackPos1.pt() * 1000); | ||
| if (FunctionSelection >= 1 && pseudoRndm < downSampleBkgFactor && candidate.pt() < downSampleBkgPtMax) { | ||
| if (FunctionSelection >= 1 && (candidate.pt() > downSampleBkgPtMax || (pseudoRndm < downSampleBkgFactor && candidate.pt() < downSampleBkgPtMax))) { |
Collaborator
There was a problem hiding this comment.
Shouldn't the && candidate.pt() < downSampleBkgPtMax part be dropped as it is trivially true inside that condition?
hahassan7 pushed a commit
to hahassan7/O2Physics
that referenced
this pull request
Feb 1, 2024
Co-authored-by: Mattia Faggin <mfaggin@cern.ch>
basiach pushed a commit
to basiach/O2Physics
that referenced
this pull request
Feb 23, 2024
Co-authored-by: Mattia Faggin <mfaggin@cern.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.