Skip to content

PWGHF: add Lc ML scores in Sc output. - #4523

Merged
fgrosa merged 3 commits into
AliceO2Group:masterfrom
mfaggin:applyMlLc4Sc
Jan 30, 2024
Merged

PWGHF: add Lc ML scores in Sc output.#4523
fgrosa merged 3 commits into
AliceO2Group:masterfrom
mfaggin:applyMlLc4Sc

Conversation

@mfaggin

@mfagginmfaggin commented Jan 30, 2024

Copy link
Copy Markdown
Collaborator

No description provided.

fgrosa
fgrosa requested changes Jan 30, 2024
View reviewed changes

@fgrosafgrosa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mfaggin, apart from a minor suggestion, I have a doubt about the vector of ML scores. Can you please check? Thanks!

Comment threadPWGHF/D2H/Tasks/taskSigmac.cxx Outdated
Comment threadPWGHF/D2H/Tasks/taskSigmac.cxx Outdated
Comment threadPWGHF/D2H/Tasks/taskSigmac.cxx Outdated
Comment threadPWGHF/D2H/Tasks/taskSigmac.cxx Outdated
Comment threadPWGHF/D2H/Tasks/taskSigmac.cxx Outdated
Comment threadPWGHF/D2H/Tasks/taskSigmac.cxx Outdated
Comment threadPWGHF/D2H/Tasks/taskSigmac.cxx Outdated
Comment threadPWGHF/D2H/Tasks/taskSigmac.cxx Outdated
Comment threadPWGHF/D2H/Tasks/taskSigmac.cxx Outdated
Comment threadPWGHF/D2H/Tasks/taskSigmac.cxx Outdated
@mfaggin

mfaggin commented Jan 30, 2024•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

Hi @mfaggin, apart from a minor suggestion, I have a doubt about the vector of ML scores. Can you please check? Thanks!

thanks @fgrosa indeed you are right: in the selector we always fill with BDT score vectors, which however might be empty is the candidate do not pass all preselections.
I have fixed it in my last commit, thanks

@fgrosa
fgrosa merged commit b64cdd7 into AliceO2Group:masterJan 30, 2024
@mfaggin
mfaggin deleted the applyMlLc4Sc branch January 31, 2024 07:34
hahassan7 pushed a commit to hahassan7/O2Physics that referenced this pull request Feb 1, 2024
@mfagginMattia Faggin@hahassan7
PWGHF: add Lc ML scores in Sc output. (AliceO2Group#4523)
2167ba6
* Add Lc ML scores in Sc output.
* Fix comment.
* Fixe template name and fill BDT score only if non-empty.
---------
Co-authored-by: Mattia Faggin <mfaggin@cern.ch>
basiach pushed a commit to basiach/O2Physics that referenced this pull request Feb 23, 2024
@mfagginMattia Faggin@basiach
PWGHF: add Lc ML scores in Sc output. (AliceO2Group#4523)
f19d554
* Add Lc ML scores in Sc output.
* Fix comment.
* Fixe template name and fill BDT score only if non-empty.
---------
Co-authored-by: Mattia Faggin <mfaggin@cern.ch>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fgrosafgrosafgrosa approved these changes
@alibuildalibuildAwaiting requested review from alibuildalibuild is a code owner
@vkuceravkuceraAwaiting requested review from vkuceravkucera is a code owner
@fcolamarfcolamarAwaiting requested review from fcolamarfcolamar is a code owner
@fcatalan92fcatalan92Awaiting requested review from fcatalan92fcatalan92 is a code owner
@mmazzillimmazzilliAwaiting requested review from mmazzillimmazzilli is a code owner
@deepathomsdeepathomsAwaiting requested review from deepathomsdeepathoms is a code owner
@nzardoshnzardoshAwaiting requested review from nzardosh
@NicoleBastidNicoleBastidAwaiting requested review from NicoleBastidNicoleBastid is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mfaggin@fgrosa