Uh oh!
There was an error while loading. Please reload this page.
PWGLF: Update split-vertex finding procedure - #4526
Merged
Merged
Conversation
fcatalan92
requested review from
BongHwi, ChiaraDeMartin95, alibuild, chiarapinto, fmazzasc, mbombara, njacazio and skundu692
as code ownersJanuary 30, 2024 17:10
mpuccio
enabled auto-merge (squash)
February 1, 2024 16:22
fmazzasc
approved these changes
Feb 1, 2024
basiach pushed a commit
to basiach/O2Physics
that referenced
this pull request
Feb 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@maciacco@mpuccio I updated the finding of splitted vertices as we discussed. Please have a look!
I tested the changes on one AO2D of Pb-Pb LHC23zzh apass1 (red for the new approach)
and on one AO2D of pp LHC22o apass4
The increase in split vertices found seems small (~3% for pp, difficult to quantify for Pb-Pb with one file).