PWGHF: Add D+ -> KKPi flag for MC by fchinu · Pull Request #4616 · AliceO2Group/O2Physics

fchinu · 2024-02-06T15:58:08Z

This PR add the code for flagging MC D+ decaying into KKPi.

The flag was added in the DecayChannelDToKKPi enum for 2 reasons:

The golden channel for the D+ is already condsidered in the DecayType, while this one is only studied for the Ds
Adding another decay channel into the DecayType enum would require an additional analysis dedicated to the D+ -> KKPi, significantly increasing the CPU time for the skimming

[MegaLinter] Apply linters automatic fixes to AliceO2Group#4564

alibuild · 2024-02-07T18:41:07Z

Error while checking build/O2Physics/o2 for c9c356a at 2024-02-07 19:41:

[692/1402] Building CXX object PWGHF/ALICE3/Tasks/CMakeFiles/O2Physicsexe-analysis-hf-task-d0-alice3-barrel.dir/taskD0Alice3Barrel.cxx.o
[693/1402] Linking CXX executable stage/bin/o2-analysis-hf-task-d0-alice3-forward
[694/1402] Linking CXX executable stage/bin/o2-analysis-hf-task-chic
[695/1402] Building CXX object PWGHF/ALICE3/Tasks/CMakeFiles/O2Physicsexe-analysis-hf-task-d0-parametrized-pid.dir/taskD0ParametrizedPid.cxx.o
[696/1402] Building CXX object PWGHF/Tasks/CMakeFiles/O2Physicsexe-analysis-hf-task-mc-efficiency.dir/taskMcEfficiency.cxx.o
/sw/SOURCES/O2Physics/4616-slc7_x86-64/0/PWGHF/Tasks/taskMcEfficiency.cxx: In member function 'void HfTaskMcEfficiency::init(o2::framework::InitContext&)':
/sw/SOURCES/O2Physics/4616-slc7_x86-64/0/PWGHF/Tasks/taskMcEfficiency.cxx:83:262: warning: arithmetic between enumeration type 'RecoDecay::OriginType' and floating-point type 'double' is deprecated [-Wdeprecated-enum-float-conversion]
83 | auto hCandidates = registry.add<StepTHn>("hCandidates", "Candidate count at different steps", {HistType::kStepTHnF, {axisPt, axisMass, axisPdg, axisCPA, {2, -0.5, 1.5, "collision matched"}, {RecoDecay::OriginType::NonPrompt + 1, RecoDecay::OriginType::None - 0.5, RecoDecay::OriginType::NonPrompt + 0.5}}, kHFNSteps});
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
/sw/SOURCES/O2Physics/4616-slc7_x86-64/0/PWGHF/Tasks/taskMcEfficiency.cxx:83:302: warning: arithmetic between enumeration type 'RecoDecay::OriginType' and floating-point type 'double' is deprecated [-Wdeprecated-enum-float-conversion]
83 | auto hCandidates = registry.add<StepTHn>("hCandidates", "Candidate count at different steps", {HistType::kStepTHnF, {axisPt, axisMass, axisPdg, axisCPA, {2, -0.5, 1.5, "collision matched"}, {RecoDecay::OriginType::NonPrompt + 1, RecoDecay::OriginType::None - 0.5, RecoDecay::OriginType::NonPrompt + 0.5}}, kHFNSteps});
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
[697/1402] Linking CXX executable stage/bin/o2-analysis-hf-task-d0-alice3-barrel
[698/1402] Building CXX object PWGHF/TableProducer/CMakeFiles/O2Physicsexe-analysis-hf-derived-data-creator-d0-to-k-pi.dir/derivedDataCreatorD0ToKPi.cxx.o
[699/1402] Linking CXX executable stage/bin/o2-analysis-hf-task-d0-parametrized-pid
[700/1402] Linking CXX executable stage/bin/o2-analysis-hf-task-mc-efficiency
[701/1402] Linking CXX executable stage/bin/o2-analysis-hf-derived-data-creator-d0-to-k-pi
[702/1402] Building CXX object PWGHF/ALICE3/Tasks/CMakeFiles/O2Physicsexe-analysis-hf-task-jpsi.dir/taskJpsi.cxx.o
[703/1402] Building CXX object PWGHF/ALICE3/Tasks/CMakeFiles/O2Physicsexe-analysis-hf-task-lc-alice3.dir/taskLcAlice3.cxx.o
[704/1402] Linking CXX executable stage/bin/o2-analysis-hf-task-jpsi
[705/1402] Linking CXX executable stage/bin/o2-analysis-hf-task-lc-alice3
[706/1402] Building CXX object PWGHF/ALICE3/Tasks/CMakeFiles/O2Physicsexe-analysis-hf-task-lc-parametrized-pid.dir/taskLcParametrizedPid.cxx.o
[707/1402] Building CXX object PWGHF/ALICE3/Tasks/CMakeFiles/O2Physicsexe-analysis-hf-task-x.dir/taskX.cxx.o
[708/1402] Linking CXX executable stage/bin/o2-analysis-hf-task-lc-parametrized-pid
[709/1402] Linking CXX executable stage/bin/o2-analysis-hf-task-x
[710/1402] Building CXX object PWGHF/ALICE3/Tasks/CMakeFiles/O2Physicsexe-analysis-hf-task-qa-pid-rejection.dir/taskQaPidRejection.cxx.o
[711/1402] Building CXX object PWGHF/D2H/TableProducer/CMakeFiles/O2Physicsexe-analysis-hf-candidate-selector-b0-to-d-pi-reduced.dir/candidateSelectorB0ToDPiReduced.cxx.o
[712/1402] Building CXX object PWGHF/D2H/TableProducer/CMakeFiles/O2Physicsexe-analysis-hf-candidate-selector-bplus-to-d0-pi-reduced.dir/candidateSelectorBplusToD0PiReduced.cxx.o
[713/1402] Building CXX object PWGHF/D2H/TableProducer/CMakeFiles/O2Physicsexe-analysis-hf-candidate-creator-b0-reduced.dir/candidateCreatorB0Reduced.cxx.o
[714/1402] Linking CXX executable stage/bin/o2-analysis-hf-task-qa-pid-rejection
[715/1402] Linking CXX executable stage/bin/o2-analysis-hf-candidate-selector-b0-to-d-pi-reduced
[716/1402] Linking CXX executable stage/bin/o2-analysis-hf-candidate-selector-bplus-to-d0-pi-reduced
[717/1402] Linking CXX executable stage/bin/o2-analysis-hf-candidate-creator-b0-reduced
[718/1402] Building CXX object PWGHF/D2H/TableProducer/CMakeFiles/O2Physicsexe-analysis-hf-candidate-creator-bplus-reduced.dir/candidateCreatorBplusReduced.cxx.o
[719/1402] Building CXX object PWGHF/D2H/Tasks/CMakeFiles/O2Physicsexe-analysis-hf-task-bplus-reduced.dir/taskBplusReduced.cxx.o
[720/1402] Linking CXX executable stage/bin/o2-analysis-hf-candidate-creator-bplus-reduced
[721/1402] Linking CXX executable stage/bin/o2-analysis-hf-task-bplus-reduced
[722/1402] Building CXX object PWGHF/D2H/Tasks/CMakeFiles/O2Physicsexe-analysis-hf-task-xicc.dir/taskXicc.cxx.o
[723/1402] Building CXX object PWGHF/D2H/Tasks/CMakeFiles/O2Physicsexe-analysis-hf-task-dplus.dir/taskDplus.cxx.o
[724/1402] Linking CXX executable stage/bin/o2-analysis-hf-task-xicc
[725/1402] Building CXX object PWGHF/D2H/Tasks/CMakeFiles/O2Physicsexe-analysis-hf-task-b0-reduced.dir/taskB0Reduced.cxx.o
[726/1402] Building CXX object PWGHF/D2H/Tasks/CMakeFiles/O2Physicsexe-analysis-hf-task-b0.dir/taskB0.cxx.o
[727/1402] Linking CXX executable stage/bin/o2-analysis-hf-task-dplus
[728/1402] Building CXX object PWGHF/D2H/Tasks/CMakeFiles/O2Physicsexe-analysis-hf-task-bplus.dir/taskBplus.cxx.o
[729/1402] Building CXX object PWGHF/D2H/Tasks/CMakeFiles/O2Physicsexe-analysis-hf-task-lc-to-k0s-p.dir/taskLcToK0sP.cxx.o
[730/1402] Linking CXX executable stage/bin/o2-analysis-hf-task-b0-reduced
[731/1402] Linking CXX executable stage/bin/o2-analysis-hf-task-b0
[732/1402] Linking CXX executable stage/bin/o2-analysis-hf-task-bplus
[733/1402] Linking CXX executable stage/bin/o2-analysis-hf-task-lc-to-k0s-p
[734/1402] Building CXX object PWGHF/D2H/Tasks/CMakeFiles/O2Physicsexe-analysis-hf-task-bs.dir/taskBs.cxx.o

Full log here.

Please consider the following formatting changes to AliceO2Group#4616

fchinu · 2024-02-08T12:36:13Z

Dear @vkucera , thanks a lot for your review!
When we reconstruct the Ds meson, we apply topological, kinematic and PID selection on the decay products, i.e. KKPi. Since the D+ meson also decays into the same final state, by applying these selections we also reconstruct this meson. That means that for data, we reconstruct both D+->KKPi and Ds->KKPi, as shown in 1,2.
However, at the moment, in the MC we only flag Ds->KKPi, so that, for example, we can't evaluate efficiencies for the D+->KKPi. This PR allows one to also have D+->KKPi MC information.
Our idea would be not to add another decay channel to the DecayType enum, since D+ candidates are already selected by the DsToKKPi selections in the track-index-skim-creator, and a lot of effort is going on to optimise this part of the analysis (many thanks to @fgrosa!). Instead, we thought of adding a flag to the DecayChannelDToKKPi enum, which already distinguished between Ds->PhiPi and Ds->K*K decay channels with a KKPi final state, in order to flag the MC selected KKPi decays on whether they are coming from a Ds or a D+.
We agree that this is not completely clean, so to better clarify we are commenting the lines where we turn the DsToKKPi flag on when we select a D+->KKPi

Please consider the following formatting changes to AliceO2Group#4616

vkucera · 2024-02-08T17:14:15Z

Thanks @fchinu for the clarification.

If the intention is to add a flag channel to distinguish Ds± → K± K∓ π± and D± → K± K∓ π±, then I would suggest to avoid duplicating the two large MC matching blocks in the candidate creator and instead extend the existing blocks for Ds± → K± K∓ π± with calls of getMatchedMCRec(..., Pdg::kDPlus,...) and isMatchedMCGen(..., Pdg::kDPlus,...) and deciding the appropriate value of channel accordingly.

alibuild · 2024-02-09T10:35:12Z

Error while checking build/O2Physics/o2 for 82bc1e9 at 2024-02-09 11:35:

## sw/BUILD/O2-latest/log
ninja: build stopped: subcommand failed.

Full log here.

fchinu · 2024-02-09T11:52:24Z

Thank you @vkucera for your suggestion, the code looks much more clean now!
As for the const addition, I can't get it working. The build fails with the log file I am attaching
log.txt

[MegaLinter] Apply linters automatic fixes to AliceO2Group#4616

alibuild · 2024-02-09T11:55:43Z

Error while checking build/O2Physics/o2 for b3c0ccb at 2024-02-09 12:55:

## sw/BUILD/O2-latest/log
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2024-02-09T12:06:27Z

Error while checking build/O2Physics/o2 for 09cc102 at 2024-02-09 13:06:

## sw/BUILD/O2-latest/log
ninja: build stopped: subcommand failed.

Full log here.

vkucera · 2024-02-09T13:36:21Z

Thanks @fchinu for simplifying the code. Please see my further suggestions.
Also please fix FillDplusMc -> fillDplusMc.

alibuild · 2024-02-09T14:16:33Z

Error while checking build/O2Physics/o2 for 2675990 at 2024-02-09 15:16:

## sw/BUILD/O2-latest/log
ninja: build stopped: subcommand failed.

Full log here.

fcatalan92

Hi @fchinu. Thanks a lot for the developments!
I made a few comments, mainly on the implementation choices.

fcatalan92 · 2024-02-09T13:28:57Z

- Configurable<int> decayChannel{"decayChannel", 1, "Switch between decay channels: 1 for Ds->PhiPi->KKpi, 2 for Ds->K0*K->KKPi"};
+ Configurable<int> decayChannelDs{"decayChannelDs", 1, "Switch between decay channels: 1 for Ds->PhiPi->KKpi, 2 for Ds->K0*K->KKPi"};
+ Configurable<int> decayChannelDplusMc{"decayChannelDplusMc", 1, "Switch between decay channels for MC Dplus: 1 for Dplus->PhiPi->KKpi, 2 for Dplus->K0*K->KKPi"};
+ Configurable<bool> FillDplusMc{"fillDplusMc", false, "Switch to fill Dplus MC information"};


Maybe here in the task we can always fill the Dplus histogram. E.g., usually we use the D+ MC info to fix/initialise the peak sigma in the fit to the invariant-mass distribution

fcatalan92 · 2024-02-09T13:33:06Z

+ {"hCPARecSigDs", "3-prong Ds candidates (matched);cosine of pointing angle;entries", {HistType::kTH1F, {{110, -1.1, 1.1}}}},
+ {"hCPARecSigDplus", "3-prong Dplus candidates (matched);cosine of pointing angle;entries", {HistType::kTH1F, {{110, -1.1, 1.1}}}},
 {"hCPARecBkg", "3-prong candidates (unmatched);cosine of pointing angle;entries", {HistType::kTH1F, {{110, -1.1, 1.1}}}},
- {"hEtaRecSig", "3-prong candidates (matched);#it{#eta};entries", {HistType::kTH1F, {{100, -2., 2.}}}},
+ {"hEtaRecSigDs", "3-prong Ds candidates (matched);#it{#eta};entries", {HistType::kTH1F, {{100, -2., 2.}}}},
+ {"hEtaRecSigDplus", "3-prong Dplus candidates (matched);#it{#eta};entries", {HistType::kTH1F, {{100, -2., 2.}}}},
 {"hEtaRecBkg", "3-prong candidates (unmatched);#it{#eta};entries", {HistType::kTH1F, {{100, -2., 2.}}}},
- {"hEtaGen", "MC particles (matched);#it{#eta};entries", {HistType::kTH1F, {{100, -2., 2.}}}}}};
+ {"hEtaGenDs", "MC Ds particles (matched);#it{#eta};entries", {HistType::kTH1F, {{100, -2., 2.}}}},
+ {"hEtaGenDplus", "MC Dplus particles (matched);#it{#eta};entries", {HistType::kTH1F, {{100, -2., 2.}}}}}};


Since now the number of histograms starts to be large, we could have different folders. This can be done in a following PR

fchinu · 2024-02-09T16:10:35Z

Hi @fcatalan92 , @vkucera, thanks for your suggestions! I have implemented all of them, except for the division of the task output in folders, which can be added in a future PR

vkucera

Thanks @fchinu for addressing the remaining comments.

alibuild · 2024-02-09T18:21:32Z

Error while checking build/O2Physics/o2 for 3c2bef7 at 2024-02-09 19:21:

## sw/BUILD/O2-latest/log
ninja: build stopped: subcommand failed.

Full log here.

Introduced in AliceO2Group#4616

Introduced in #4616

* PWGHF: Add nSigma TPC TOF to Ds tree creator output * MegaLinter fixes * PWGHF: Add D+ -> KKPi flag * Please consider the following formatting changes * Add comments and fixed formatting * Please consider the following formatting changes * Refactored candidateCreator D meson selections * MegaLinter fixes * Fix formatting * Imlemented suggestions --------- Co-authored-by: ALICE Action Bot <alibuild@cern.ch>

…up#4826) Introduced in AliceO2Group#4616

fchinuand others added 5 commits February 2, 2024 14:48

PWGHF: Add nSigma TPC TOF to Ds tree creator output
085eafd

Merge085eafdinto2e4d281
559b1f1

MegaLinter fixes
cbab9e0

Merge pull request#3from alibuild/alibot-cleanup-ml-4564
9bfe3b6
[MegaLinter] Apply linters automatic fixes to AliceO2Group#4564

PWGHF: Add D+ -> KKPi flag
7c8d117

fchinu requested review from NicoleBastid, alibuild, deepathoms, fcatalan92, fcolamar, fgrosa, mfaggin, mmazzilli, nzardosh and vkucera as code owners February 6, 2024 15:58

alibuild mentioned this pull request Feb 6, 2024
[MegaLinter] Apply linters automatic fixes to #4616 fchinu/O2Physics#5
Closed

vkucera reviewed Feb 6, 2024
View reviewed changes

Comment threadPWGHF/TableProducer/candidateCreator3Prong.cxx Outdated

vkucera reviewed Feb 6, 2024
View reviewed changes

Comment threadPWGHF/TableProducer/candidateCreator3Prong.cxx

vkucera reviewed Feb 6, 2024
View reviewed changes

Comment threadPWGHF/TableProducer/treeCreatorDsToKKPi.cxx Outdated

vkucera requested changes Feb 6, 2024
View reviewed changes

Comment threadPWGHF/TableProducer/treeCreatorDsToKKPi.cxx Outdated
Comment threadPWGHF/D2H/Tasks/taskDs.cxx Outdated

fchinu added a commit to fchinu/O2Physics that referenced this pull request Feb 8, 2024
Merge pull request#4from alibuild/alibot-cleanup-4616
9982a98
Please consider the following formatting changes to AliceO2Group#4616

fchinu force-pushed the add_Dplus_flag branch from 9982a98 to 7c8d117Compare February 8, 2024 12:36

alibuild mentioned this pull request Feb 8, 2024
[MegaLinter] Apply linters automatic fixes to #4616 fchinu/O2Physics#7
Closed

fchinu force-pushed the add_Dplus_flag branch from ca44031 to 7c8d117Compare February 8, 2024 12:43

fchinuand others added 3 commits February 8, 2024 13:44

Merge branch 'AliceO2Group:master' into add_Dplus_flag
b170b34

Please consider the following formatting changes
a1cac9d

Add comments and fixed formatting
0a6ef3a

fchinu force-pushed the add_Dplus_flag branch from b170b34 to 7c8d117Compare February 8, 2024 12:48

Merge pull request#6from alibuild/alibot-cleanup-4616
82bc1e9
Please consider the following formatting changes to AliceO2Group#4616

vkucera reviewed Feb 8, 2024
View reviewed changes

Comment threadPWGHF/D2H/Tasks/taskDs.cxx

fchinuand others added 2 commits February 9, 2024 12:47

Refactored candidateCreator D meson selections
b3c0ccb

Mergeb3c0ccbintoafc5c7d
c4e20d9

MegaLinter fixes
d87a2cd

alibuild mentioned this pull request Feb 9, 2024
[MegaLinter] Apply linters automatic fixes to #4616 fchinu/O2Physics#9
Merged

Merge pull request#9from alibuild/alibot-cleanup-ml-4616
09cc102
[MegaLinter] Apply linters automatic fixes to AliceO2Group#4616

vkucera requested changes Feb 9, 2024
View reviewed changes

Comment threadPWGHF/TableProducer/candidateCreator3Prong.cxx Outdated
Comment threadPWGHF/TableProducer/candidateCreator3Prong.cxx Outdated
Comment threadPWGHF/TableProducer/candidateCreator3Prong.cxx Outdated
Comment threadPWGHF/TableProducer/candidateCreator3Prong.cxx Outdated

Fix formatting
2675990

fcatalan92 requested changes Feb 9, 2024
View reviewed changes

Imlemented suggestions
3c2bef7

vkucera approved these changes Feb 9, 2024
View reviewed changes

fcatalan92 approved these changes Feb 9, 2024
View reviewed changes

fcatalan92 enabled auto-merge (squash) February 9, 2024 17:24

fcatalan92 merged commit 5e4b5de into AliceO2Group:masterFeb 10, 2024

fchinu deleted the add_Dplus_flag branch February 10, 2024 10:04

vkucera added a commit to vkucera/O2Physics that referenced this pull request Feb 22, 2024
PWGHF: Fix typo in KKPi channel of candidateCreator3Prong
37a28e0
Introduced in AliceO2Group#4616

vkucera mentioned this pull request Feb 22, 2024
PWGHF: Fix typo in KKPi channel of candidateCreator3Prong #4826
Merged

vkucera added a commit that referenced this pull request Feb 22, 2024
PWGHF: Fix typo in KKPi channel of candidateCreator3Prong (#4826)
ec2353a
Introduced in #4616

basiach pushed a commit to basiach/O2Physics that referenced this pull request Feb 23, 2024
PWGHF: Fix typo in KKPi channel of candidateCreator3Prong (AliceO2Gro…
63a3c50
…up#4826) Introduced in AliceO2Group#4616

Uh oh!

Conversation

fchinu commented Feb 6, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alibuild commented Feb 7, 2024

Uh oh!

fchinu commented Feb 8, 2024

Uh oh!

vkucera commented Feb 8, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

alibuild commented Feb 9, 2024

Uh oh!

fchinu commented Feb 9, 2024

Uh oh!

alibuild commented Feb 9, 2024

Uh oh!

alibuild commented Feb 9, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vkucera commented Feb 9, 2024

Uh oh!

alibuild commented Feb 9, 2024

Uh oh!

fcatalan92 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fcatalan92Feb 9, 2024

Choose a reason for hiding this comment

Uh oh!

fcatalan92Feb 9, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fchinu commented Feb 9, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vkucera left a comment

Choose a reason for hiding this comment

Uh oh!

alibuild commented Feb 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

vkucera commented Feb 8, 2024•
edited
Loading

fchinu commented Feb 9, 2024•
edited
Loading