Uh oh!
There was an error while loading. Please reload this page.
Use aggregate initialisation for JetFinder - #4699
Conversation
ktf
commented
Feb 13, 2024
qgp
commented
Feb 13, 2024
Duplicate of#4697 |
ktf
commented
Feb 13, 2024
fine with me, although this version handles the ghost* as before. i do not know if that is actually desirable, though. |
qgp
commented
Feb 14, 2024
@ktf What's wrong with default initialisation (instead of zero initialisation) for these variables? |
ktf
commented
Feb 14, 2024
Before your fix, the structJetFinder {
float etaMin = 0.9;
...
float ghostEtaMin = etaMin;
...
};This is what would have the same effect as the old constructor. |
ktf
commented
Feb 14, 2024
PR updated to show what I mean... |
Uh oh!
There was an error while loading. Please reload this page.
qgp
commented
Feb 14, 2024
Sorry, then I missed your point before. Indeed, I discussed this with Nima and we deliberately chose to initialise the |
ktf
commented
Feb 14, 2024
Ok, fair enough. Thank you for understanding the original issue! |
No description provided.