PWGHF: Adding reduced data model for Ds resonances

[Luca610]

Added tables for charm resonances reduced analysis and data creator for DS1 candidates

[fgrosa]

Hi @Luca610 thank you very much for the implementation of this task!
The main comment I have is that you are pairing D+ and K0S to build Ds1, but the Ds1 decays into D* and K0S. So, depending whether you want to switch to the Ds2* with this first implementation or to stick with the Ds1 (it's the first channel I would look at, since it's narrower and hence easier) you can consider to modify the code. If you want to move to Ds1 though, I would not through away the implementation of the D+K0S channel, but I would simply add the D*+ to have both Ds1 and Ds2* already.

[Luca610]

Thanks for the comments, Fabrizio. Indeed, I confused the decay channels of the 2 resonances I was planning to study.
I will add the decay channel for both in the next version

[fgrosa]

Hi @Luca610 thanks a lot for considering my comments! As discussed offline I think that it would be good to put together all the V0s to have the possibility to have multiple channels included. Moreover, I believe that it would be good to add some selection on the V0, especially the one on the mass that would allow us to decide whether a V0 is accepted as a K0, Lambda, or AntiLambda.
Below you can see some detailed comment

[vkucera]

Suggested change

	DECLARE_SOA_COLUMN(CosP, cosp, float); //! Cos PA of V0 candidate
	DECLARE_SOA_COLUMN(DCA, dca, float); //! DCA of V0 candidate
	DECLARE_SOA_COLUMN(CosP, cosP, float); //! Cos PA of V0 candidate
	DECLARE_SOA_COLUMN(Dca, dca, float); //! DCA of V0 candidate

The type and getter should differ only by the first letter capitalisation. (Can be fixed in another PR.)

[vkucera]

Btw, cosPA or cpa would be better, since cosP is missing the A.

[vkucera]

Where do you use DCAFitter?

[vkucera]

Please respect the conventions on the order of members.

[vkucera]

isSelectedV0 implies that the return type is bool. Better to name it something like getSelectionMapV0.

[vkucera]

Suggested change

	v0_type = isSelectedV0(v0, collision, std::array{posTrack, negTrack}, prongIdsD);
	if (v0_type == 0) {
	continue;
	}
	v0Type = isSelectedV0(v0, collision, std::array{posTrack, negTrack}, prongIdsD);
	if (v0Type == 0) {
	continue;
	}

Underscores are reserved for namespaces.

[vkucera]

Suggested change

	float ptV0 = sqrt(pVecV0[0] * pVecV0[0] + pVecV0[1] * pVecV0[1]); // fill histos
	float ptV0 = RecoDecay::pt(pVecV0); // fill histos

[vkucera]

Btw, state the namespace you use: std::sqrt.

[vkucera]

Suggested change

	registry.add("hV0_type", "V0 selection flag", {HistType::kTH1F, {{8, -0.5, 7.5}}});
	registry.add("hD_type", "D selection flag", {HistType::kTH1F, {{5, -2.5, 2.5}}});
	registry.add("hV0Type", "V0 selection flag", {HistType::kTH1F, {{8, -0.5, 7.5}}});
	registry.add("hDType", "D selection flag", {HistType::kTH1F, {{5, -2.5, 2.5}}});

[Luca610]

@vkucera, Thank you for your comments. Being my first analysis I am still unfamiliar with the conventions, sorry.
I am implementing all comments an I will include them in my next PR! Thank you again!